Upgrade @elastic/eui to 85.0.1 by tkajtoch · Pull Request #162209 · elastic/kibana

tkajtoch · 2023-07-19T08:01:19Z

Summary

eui@84.0.0 ⏩ eui@85.0.1

`85.0.1`

Bug fixes

Fixed EuiFilterGroup's responsive styles (#6983)

`85.0.0`

Updated EuiThemeProvider to set an Emotion theme context that returns the values of useEuiTheme() (#6913)
Added size prop to EuiStepsHorizontal, defaulting to the previous size of m (#6928)
Added new s sizing to EuiStepsHorizontal (#6928)
Added at and key icon glyphs. (#6934)
Added a new cloneElementWithCss Emotion utility (#6939)
Updated EuiPopover to allow consumer control of all focusTrapProps (#6955)

Bug fixes

Fixed EuiDataGrid height calculation bug when browser zoom levels are not 100% (#6895)
Fixed EuiTab not correctly passing selection color state to prepend and append children (#6938)
Fixed EuiInputPopover to allow consumer control of its focus trap via focusTrapProps (#6955)

Breaking changes

EuiProvider will no longer render multiple or duplicate nested instances of itself. If a nested EuiProvider is detected, that instance will return early without further processing, and will warn if configured to do so via setEuiDevProviderWarning. For nested theming, use EuiThemeProvider instead. (#6949)
Removed onTrapDeactivation prop from EuiPopover. Use focusTrapProps.onDeactivation instead (#6955)

CSS-in-JS conversions

Converted EuiFilterGroup and EuiFilterButton to Emotion; Removed styles attached to .euiFilterGroup__popoverPanel (#6957)

- `.presFilterByType__panel` already has its own width Sass, so move the width CSS there instead

…overPanel` - After Emotion conversion, no longer has any styles attached to it - use Emotion CSS instead

…ue to emotion conversion

elasticmachine · 2023-07-24T15:45:22Z

Pinging @elastic/eui-team (EUI)

Heenawter

Presentation changes LGTM 👍

jughosta · 2023-07-25T10:13:57Z

packages/kbn-unified-field-list/src/components/field_list_filters/field_type_filter.tsx

    <EuiPopover
      id="unifiedFieldTypeFilter"
-      panelClassName="euiFilterGroup__popoverPanel"
+      panelProps={{ css: { width: euiTheme.base * 18 } }}


In Discover, the filter button width and the filter item height look larger than it was in 8.9:

Before:

Now:

Thanks @jughosta I'll look into that!

The filter button width should be fixed as with 14e7469 - I hadn't realized folks in Kibana were using EuiFilterButton outside of EuiFilterGroup, so that's my bad :)

Regarding the filter item height - this looks like it was affected by #161592 (Sass styling order). I pushed up a specificity override for now (f5a55e0) which we can remove once more of EUI is on Emotion 🤞

Thanks for your eagle eye on these things @jughosta, you're amazing!!

Thanks for the fixes, @cee-chen! You are amazing! 😉

- `min-width` is now set on `EuiFilterButtons` even outside of `EuiFilterGroup`s, so CSS needs to update to take that into account

clintandrewhall · 2023-07-25T16:02:49Z

packages/content-management/table_list_view_table/src/components/table_sort_select.tsx

      panelPaddingSize="none"
      anchorPosition="downCenter"
-      panelClassName="euiFilterGroup__popoverPanel"
+      panelProps={{ css: { width: euiTheme.base * 18 } }}


nit: would prefer 18 to be a constant. Not sure what that number is supposed to correspond to.

@ryankeairns, you like to call this out often, what do you think?

Y'all are super welcome to set your own constant! The number is what .euiFilterGroup__popoverPanel was setting as a width in CSS/Sass (link), it's just not hidden behind an EUI CSS class anymore, as we are no longer providing component-specific CSS utilities to consumers.

In any case, width is fairly content-specific so we would prefer consumers figure out what width they want to display based on their content and not on a generic.

cee-chen · 2023-07-25T17:58:13Z

@elasticmachine merge upstream

spong

Security Detection Rule Mgmt changes (just two test updates) LGTM! Thanks @tkajtoch! 🙂

jughosta

Data Discovery changes LGTM 👍

tkajtoch · 2023-07-27T10:44:50Z

@elasticmachine merge upstream

ryankeairns

👍 based upon this reply: https://github.com/elastic/kibana/pull/162209/files#r1273854410

cee-chen · 2023-07-27T14:49:02Z

@elasticmachine merge upstream

kibana-ci · 2023-07-27T17:26:04Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: cb499fc

Failed CI Steps

Test Failures

[job] [logs] Security Solution Tests #3 / Alert details expandable flyout right panel overview tab insights section should display threat intelligence section should display threat intelligence section

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`infra`	1397	1401	+4
`visTypeVega`	305	309	+4
total			+8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	421.6KB	421.6KB	+2.0B
`dashboard`	358.2KB	358.2KB	-22.0B
`discover`	547.9KB	547.9KB	+15.0B
`eventAnnotation`	176.2KB	176.2KB	-22.0B
`filesManagement`	89.2KB	89.2KB	-22.0B
`graph`	407.4KB	407.4KB	-22.0B
`infra`	2.0MB	2.0MB	+2.4KB
`lens`	1.4MB	1.4MB	+15.0B
`maps`	2.8MB	2.8MB	-22.0B
`presentationUtil`	129.8KB	129.8KB	-5.0B
`visTypeVega`	1.8MB	1.8MB	+2.4KB
`visualizations`	262.5KB	262.4KB	-22.0B
total			+4.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-css`	296.4KB	294.1KB	-2.4KB
`kbnUiSharedDeps-npmDll`	6.0MB	6.0MB	+6.3KB
total			+4.0KB

History

💔 Build #145163 failed 98f017c
💔 Build #144984 failed cffdd7c
💛 Build #144868 was flaky 43116a7
💛 Build #144748 was flaky 0d0e093
💔 Build #144700 failed f5a55e0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tkajtoch

cee-chen · 2023-07-27T17:32:51Z

@elastic/response-ops As a heads up, we'll be asking @elastic/kibana-operations for an admin merge today as this PR has been open for over a week. If you encounter an issues that you think may be related to the upgrade after the fact (knock on wood), please feel free to ping us.

## Summary `eui@84.0.0` ⏩ `eui@85.0.1` ## [`85.0.1`](https://github.com/elastic/eui/tree/v85.0.1) **Bug fixes** - Fixed `EuiFilterGroup`'s responsive styles ([elastic#6983](elastic/eui#6983)) ## [`85.0.0`](https://github.com/elastic/eui/tree/v85.0.0) - Updated `EuiThemeProvider` to set an Emotion theme context that returns the values of `useEuiTheme()` ([elastic#6913](elastic/eui#6913)) - Added `size` prop to `EuiStepsHorizontal`, defaulting to the previous size of `m` ([elastic#6928](elastic/eui#6928)) - Added new `s` sizing to `EuiStepsHorizontal` ([elastic#6928](elastic/eui#6928)) - Added `at` and `key` icon glyphs. ([elastic#6934](elastic/eui#6934)) - Added a new `cloneElementWithCss` Emotion utility ([elastic#6939](elastic/eui#6939)) - Updated `EuiPopover` to allow consumer control of all `focusTrapProps` ([elastic#6955](elastic/eui#6955)) **Bug fixes** - Fixed `EuiDataGrid` height calculation bug when browser zoom levels are not 100% ([elastic#6895](elastic/eui#6895)) - Fixed `EuiTab` not correctly passing selection color state to `prepend` and `append` children ([elastic#6938](elastic/eui#6938)) - Fixed `EuiInputPopover` to allow consumer control of its focus trap via `focusTrapProps` ([elastic#6955](elastic/eui#6955)) **Breaking changes** - `EuiProvider` will no longer render multiple or duplicate nested instances of itself. If a nested `EuiProvider` is detected, that instance will return early without further processing, and will warn if configured to do so via `setEuiDevProviderWarning`. For nested theming, use `EuiThemeProvider` instead. ([elastic#6949](elastic/eui#6949)) - Removed `onTrapDeactivation` prop from `EuiPopover`. Use `focusTrapProps.onDeactivation` instead ([elastic#6955](elastic/eui#6955)) **CSS-in-JS conversions** - Converted `EuiFilterGroup` and `EuiFilterButton` to Emotion; Removed styles attached to `.euiFilterGroup__popoverPanel` ([elastic#6957](elastic/eui#6957)) --------- Co-authored-by: Cee Chen <constance.chen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

tkajtoch added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes EUI labels Jul 19, 2023

tkajtoch self-assigned this Jul 19, 2023

tkajtoch force-pushed the eui-v85.0.0 branch 3 times, most recently from 9fa8a55 to b2022cd Compare July 24, 2023 09:46

tkajtoch and others added 4 commits July 24, 2023 16:05

Upgrade @elastic/eui to 85.0.0

491dc61

[Presentation] Remove .euiFilterGroup__popoverPanel usage

107b349

- `.presFilterByType__panel` already has its own width Sass, so move the width CSS there instead

[EuiFilterGroup] Remove all other references to `.euiFilterGroup__pop…

7e4eb76

…overPanel` - After Emotion conversion, no longer has any styles attached to it - use Emotion CSS instead

increase EuiFilterButton selector specificity in failing unit tests d…

8569585

…ue to emotion conversion

tkajtoch force-pushed the eui-v85.0.0 branch from b2022cd to 8569585 Compare July 24, 2023 14:06

Heenawter mentioned this pull request Jul 24, 2023

[Controls] [PresentationUtil] QoL improvements to control creation form #162067

Merged

5 tasks

cee-chen added the v8.10.0 label Jul 24, 2023

tkajtoch marked this pull request as ready for review July 24, 2023 15:45

tkajtoch requested review from a team as code owners July 24, 2023 15:45

tkajtoch requested a review from jpdjere July 24, 2023 15:45

jbudz approved these changes Jul 24, 2023

View reviewed changes

Heenawter approved these changes Jul 24, 2023

View reviewed changes

shahzad31 approved these changes Jul 24, 2023

View reviewed changes

Update EUI to v85.0.1

f6320c8

cee-chen changed the title ~~Upgrade @elastic/eui to 85.0.0~~ Upgrade @elastic/eui to 85.0.1 Jul 24, 2023

banderror requested review from spong and removed request for jpdjere July 25, 2023 09:45

jughosta reviewed Jul 25, 2023

View reviewed changes

yuliacech approved these changes Jul 25, 2023

View reviewed changes

cee-chen added 2 commits July 25, 2023 08:49

[EuiFilterButton] Fix Kibana min-width overrides

14e7469

- `min-width` is now set on `EuiFilterButtons` even outside of `EuiFilterGroup`s, so CSS needs to update to take that into account

[EuiContextMenuItem] Fix specificity issue

f5a55e0

clintandrewhall reviewed Jul 25, 2023

View reviewed changes

tsullivan mentioned this pull request Jul 25, 2023

Incorporate EuiCollapsibleNavItem into side nav #162507

Closed

Merge branch 'main' into eui-v85.0.0

0d0e093

spong approved these changes Jul 25, 2023

View reviewed changes

jughosta approved these changes Jul 26, 2023

View reviewed changes

kibanamachine added 2 commits July 26, 2023 05:14

Merge branch 'main' into eui-v85.0.0

43116a7

Merge branch 'main' into eui-v85.0.0

cffdd7c

Merge branch 'main' into eui-v85.0.0

98f017c

angorayc approved these changes Jul 27, 2023

View reviewed changes

michaelolo24 approved these changes Jul 27, 2023

View reviewed changes

ryankeairns approved these changes Jul 27, 2023

View reviewed changes

Merge branch 'main' into eui-v85.0.0

cb499fc

Ikuni17 merged commit 1c42ee9 into elastic:main Jul 27, 2023

Conversation

tkajtoch commented Jul 19, 2023 • edited by cee-chen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

85.0.1

85.0.0

Uh oh!

elasticmachine commented Jul 24, 2023

Uh oh!

Heenawter left a comment

Choose a reason for hiding this comment

Uh oh!

jughosta Jul 25, 2023

Choose a reason for hiding this comment

Uh oh!

tkajtoch Jul 25, 2023

Choose a reason for hiding this comment

Uh oh!

cee-chen Jul 25, 2023

Choose a reason for hiding this comment

Uh oh!

jughosta Jul 26, 2023

Choose a reason for hiding this comment

Uh oh!

clintandrewhall Jul 25, 2023

Choose a reason for hiding this comment

Uh oh!

cee-chen Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Jul 25, 2023

Uh oh!

spong left a comment

Choose a reason for hiding this comment

Uh oh!

jughosta left a comment

Choose a reason for hiding this comment

Uh oh!

tkajtoch commented Jul 27, 2023

Uh oh!

ryankeairns left a comment

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Jul 27, 2023

Uh oh!

kibana-ci commented Jul 27, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

cee-chen commented Jul 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

tkajtoch commented Jul 19, 2023 •

edited by cee-chen

Loading

`85.0.1`

`85.0.0`

cee-chen Jul 25, 2023 •

edited

Loading