Why are you reverting metric?

There have been a lot of problems with new metric visualization.
The old metric was html based, which means browser took care of things like wrapping in new line or sizing of elements.
The new one is svg based, which means we need to do all that. Taking a step back and looking at current implementation again made me realize we don't really use any of svg features and that metric should probably not use svg but be html based as it was.

The new metrics allows splits on aggregations while the old one doesn't. Can you keep that functionality? Some of my metrics use the filters aggregations to show different numbers. I was able to do that with the old one by using the bucket metrics but it was easy to understand with the new metric.

We hope to keep all the functionality, except switching between metric and gauge

jenkins, test this

i kept most options, but removed some which make less sense. let me know what you think

@ppisljar I just pulled down the latest. Feedback below.

It looks like we're defaulting to percent mode with count when creating a new metric. This seems a bit odd to me, what do you think? I believe defaulting to count without percentage mode is the current experience.

Have we done any testing to make sure that metric visualizations created in the last few releases have no issues with the reverted metric?

Quick comparison between configuration options:

Reverted metric viz:

5.x configuration:

Note: colors can be changed in the legend

I don't see any legend on a metric (which makes sense). Maybe we need to re-introduce the color input box if label and/or background color is chosen and remove this label?

I don't think we need to hide/show legend as it doesn't really make sense to have a legend in the metric viz, however it'd be nice to be able to show/hide labels. In most cases, it's duplicate information that is presented in the title of the visualization. Can we get this configuration back? To me, it's unnecessary to show Count here as a label.

This is probably more of an enhancement request. I don't see it in the previous version of metric. It'd be great to add the Vertical split option to a metric

Hope this helps!

thanks @alexfrancoeur I added the show labels option back and also made percentage mode disabled by default. This needs more testing (to make sure old visualizations work ok), also more unit tests should be added.

sorry @ppisljar @alexfrancoeur, it took me a while to look into this in-depth. I think we should get this in v6. A major is an appropriate venue for introducing a new approach like this. In fact, it is not really a "new" approach, we are just redressing the issues introduced in v5 by reusing the old code-base, slightly expanded to include the coloring options.

@alexfrancoeur @timroes Could either of you take a second look? It would be nice if we could pull the trigger on this by the end of this week (yes/no).

@thomasneirynck @ppisljar The legend still seems to be missing. There's currently no way to customize a color for a single metric and for ranges.

@alexfrancoeur i would vote to either:

• put the legend back so the colors could be customized there
• not have the ability to change colors (for now) (preferred)

@ppisljar I'm fine with punting on custom colors for a metric (without a range) now but can we open an issue to track it so we don't forget to come back and address?

Also, if that's the case - shouldn't we remove the color option from style when one range is selected? Seems a bit odd that I can choose to color something but not the actual color.

jenkins, test this

@thomasneirynck i added another commit, so the old saved metrics will work with this, do you want to take another look into this ?

tilemap tests failling (probably no relation to this PR)

jenkins, test this

@ppisljar looks good to me.

The failing tilemap tests are unrelated. It started a couple of days ago. I need to look deeper. Perhaps @jbudz has some more info about this, he looked at it earlier.

jenkins, test this

Backports:

• 6.x: [6.x] Backport. reverts metric visualization (#14052) #14882
• 6.1: [6.1] Backport. reverts metric visualization (#14052) #15177