Skip to content

[6.x] Backport. reverts metric visualization (#14052)#14882

Merged
thomasneirynck merged 1 commit intoelastic:6.xfrom
thomasneirynck:6.x_5f1f28ba413eaa915bc961b48fa616199a4dd2fb
Nov 29, 2017
Merged

[6.x] Backport. reverts metric visualization (#14052)#14882
thomasneirynck merged 1 commit intoelastic:6.xfrom
thomasneirynck:6.x_5f1f28ba413eaa915bc961b48fa616199a4dd2fb

Conversation

@thomasneirynck
Copy link
Copy Markdown
Contributor

No description provided.

@thomasneirynck thomasneirynck added backport This PR is a backport of another PR v6.1.0 labels Nov 9, 2017
@thomasneirynck thomasneirynck changed the title reverts metric visualization (#14052) [6.1] Backport. reverts metric visualization (#14052) Nov 9, 2017
@thomasneirynck
Copy link
Copy Markdown
Contributor Author

jenkins, test this

@thomasneirynck thomasneirynck added blocker Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Nov 27, 2017
@thomasneirynck thomasneirynck changed the title [6.1] Backport. reverts metric visualization (#14052) [6.x] Backport. reverts metric visualization (#14052) Nov 27, 2017
@thomasneirynck thomasneirynck force-pushed the 6.x_5f1f28ba413eaa915bc961b48fa616199a4dd2fb branch from 70b6467 to b77e146 Compare November 27, 2017 23:08
@thomasneirynck
Copy link
Copy Markdown
Contributor Author

manually resolve merge conflicts

@ppisljar
Copy link
Copy Markdown
Contributor

unit and selenium tests are failling

Uses the previous html/css rendering code instead of the svg-based rendering for simple metrics.

This backport required manual edits and js-linting.
@thomasneirynck thomasneirynck force-pushed the 6.x_5f1f28ba413eaa915bc961b48fa616199a4dd2fb branch from b77e146 to 2874633 Compare November 28, 2017 18:41
@thomasneirynck
Copy link
Copy Markdown
Contributor Author

fixed merge issues, rebuilding

@ppisljar
Copy link
Copy Markdown
Contributor

should be exactly the same as 6.1 right ? in that case, lgtm

@thomasneirynck
Copy link
Copy Markdown
Contributor Author

@ppisljar correct, was exactly the same.

Copy link
Copy Markdown
Contributor

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomasneirynck thomasneirynck merged commit dc7345a into elastic:6.x Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v6.1.0 v6.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants