[Unified search] Optimise the bundle size unified search plugin by nlatipov · Pull Request #130662 · elastic/kibana

nlatipov · 2022-04-20T11:38:43Z

Summary

What was done:

escapeKuery , fromKueryExpression , buildQueryFromFilters expression function became asynchronous;
small refactoring;

Bundle structure:

Before:	After:

494,5k	219,2k

…lete-to-unified-search

…ithub.com/nlatipov/kibana into issue-move-autocomplete-to-unified-search

…lete-to-unified-search

…-fix'

…hange-index-pattern-to-data-view

…plete

…le-size-unified-search

elasticmachine · 2022-04-28T16:10:50Z

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

cchaos

FYI, a lot of this Sass stuff has already been done in #128401 (plus more). Should we remove those updates from this PR specifically knowing the same reduction in bundle should happen there?

stratoula · 2022-04-28T16:31:53Z

Yes @cchaos you are right, let's remove the sass related improvements from this PR and check the reduction without them.

nlatipov · 2022-04-28T16:38:24Z

Yes @cchaos you are right, let's remove the sass related improvements from this PR and check the reduction without them.

Ok, let's try. I will return the sass files. And after that, let's look at the changes in the size of the plugin.

stratoula

LGTM!, code review only

nlatipov · 2022-05-02T19:21:51Z

@elasticmachine merge upstream

stratoula · 2022-05-03T09:41:10Z

@nlatipov I think that the @elastic/kibana-design is required to review here because you made a very small change in the index.scss (If I understnd correctly an empty line addition). Do you want to restore this file as it is in main?

nlatipov · 2022-05-03T09:58:21Z

@nlatipov I think that the @elastic/kibana-design is required to review here because you made a very small change in the index.scss (If I understnd correctly an empty line addition). Do you want to restore this file as it is in main?

All right. I wanted to restore this file from main after trying to optimize the bundle. I'm surprised the file is empty. Because it's very important file. And in main branch it has rows. I will try to resolve this issue.

nlatipov · 2022-05-03T11:29:24Z

@stratoula I just restored the file from main, and it looks like there was issue in that the size of the file was changed without making any changes to the file. I fixed it. But it seems that the design team should review this PR, I suppose in this PR there were commits that touched the Sass files. But no changes will merge into mine branch.

cchaos

I dont see any touched Sass files anymore but I'll approve anyway to not block merging.

nlatipov · 2022-05-03T11:36:03Z

@jbudz Could you please re-review this PR?

kibana-ci · 2022-05-03T12:15:36Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`unifiedSearch`	116.6KB	157.2KB	+40.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`unifiedSearch`	87.8KB	54.7KB	-33.0KB

Unknown metric groups

async chunk count

id	before	after	diff
`unifiedSearch`	9	10	+1

History

💔 Build #42025 failed 573505449a85c90af484604cd7a1354d06a9295a
💚 Build #42000 succeeded 2c4fd93
💚 Build #41894 succeeded f09375a
💚 Build #41243 succeeded 52cf210
💚 Build #41162 succeeded cc20fdd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nlatipov

…tic#130662) * feat: move autocomplete logic from data plugin to unified search * minor fix after comments * updated Documentation: data.autocomplete -> unifiedSearch.autocomplete * changed renameFromRoot order for autocomplete * removed extra renameFromRoot in config deprecations, updated test * added configPath for unified search plugin * Update kibana.json * updated path to autocomplete * fix conflict * fix conflict * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * fix Linting * Merge branch 'issue-move-autocomplete-to-unified-search' into issue-change-index-pattern-to-data-view * feat: replace static import to dynamic import for es-query in autocomplete * feat: add unifiedSearch to uptime plugin * refact scss * feat: add comment for filter lazy loading * fix css issue * feat: rollback filter bar changes * update limits * rollback scss files and update limites * fix: restored index.scss file

nlatipov and others added 20 commits April 12, 2022 12:02

feat: move autocomplete logic from data plugin to unified search

17ffceb

minor fix after comments

b0cc1ae

Merge remote-tracking branch 'upstream/main' into issue-move-autocomp…

36c24c1

…lete-to-unified-search

updated Documentation: data.autocomplete -> unifiedSearch.autocomplete

e2e65d6

changed renameFromRoot order for autocomplete

e497a79

removed extra renameFromRoot in config deprecations, updated test

eb9c491

added configPath for unified search plugin

bbccb48

Update kibana.json

e9468b8

Merge branch 'main' into issue-move-autocomplete-to-unified-search

6b75549

Merge branch 'main' into issue-move-autocomplete-to-unified-search

0bb84cf

updated path to autocomplete

baaad42

Merge branch 'issue-move-autocomplete-to-unified-search' of https://g…

d969400

…ithub.com/nlatipov/kibana into issue-move-autocomplete-to-unified-search

Merge remote-tracking branch 'upstream/main' into issue-move-autocomp…

56c0a49

…lete-to-unified-search

Merge remote-tracking branch 'upstream/main' into issue-move-autocomp…

49cd013

…lete-to-unified-search

fix conflict

fe55f2c

fix conflict

ea5815c

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

94147eb

…-fix'

fix Linting

d409271

Merge branch 'issue-move-autocomplete-to-unified-search' into issue-c…

6d8d429

…hange-index-pattern-to-data-view

feat: replace static import to dynamic import for es-query in autocom…

e912410

…plete

nlatipov changed the title ~~Issue optimise bundle size unified search~~ [Unified search] Optimise the bundle size unified search plugin Apr 25, 2022

elastic deleted a comment from kibana-ci Apr 27, 2022

nlatipov added 2 commits April 27, 2022 18:48

feat: add unifiedSearch to uptime plugin

bf13f38

Merge remote-tracking branch 'upstream/main' into issue-optimise-bund…

2912c37

…le-size-unified-search

nlatipov force-pushed the issue-optimise-bundle-size-unified-search branch from f869c95 to 2912c37 Compare April 27, 2022 14:00

elastic deleted a comment from kibana-ci Apr 27, 2022

nlatipov and others added 4 commits April 27, 2022 19:45

refact scss

d98b9a2

feat: add comment for filter lazy loading

3098d69

Merge branch 'main' into issue-optimise-bundle-size-unified-search

de28a21

fix css issue

57138ee

alexwizp added the release_note:skip Skip the PR/issue when compiling release notes label Apr 28, 2022

update limits

bb86e04

nlatipov marked this pull request as ready for review April 28, 2022 16:10

nlatipov requested review from a team as code owners April 28, 2022 16:10

jbudz approved these changes Apr 28, 2022

View reviewed changes

cchaos reviewed Apr 28, 2022

View reviewed changes

rollback scss files and update limites

52cf210

nlatipov requested review from cchaos and jbudz April 28, 2022 18:27

stratoula approved these changes Apr 29, 2022

View reviewed changes

Merge branch 'main' into issue-optimise-bundle-size-unified-search

f09375a

vadimkibana approved these changes May 3, 2022

View reviewed changes

Merge branch 'main' into issue-optimise-bundle-size-unified-search

2c4fd93

nlatipov force-pushed the issue-optimise-bundle-size-unified-search branch from 5735054 to 2c4fd93 Compare May 3, 2022 11:00

fix: restored index.scss file

7f0b42b

cchaos approved these changes May 3, 2022

View reviewed changes

nlatipov merged commit d2e96be into elastic:main May 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Unified search] Optimise the bundle size unified search plugin#130662

[Unified search] Optimise the bundle size unified search plugin#130662
nlatipov merged 33 commits intoelastic:mainfrom
nlatipov:issue-optimise-bundle-size-unified-search

nlatipov commented Apr 20, 2022 •

edited

Loading

Uh oh!

elasticmachine commented Apr 28, 2022

Uh oh!

cchaos left a comment

Uh oh!

stratoula commented Apr 28, 2022

Uh oh!

nlatipov commented Apr 28, 2022 •

edited

Loading

Uh oh!

stratoula left a comment

Uh oh!

nlatipov commented May 2, 2022

Uh oh!

stratoula commented May 3, 2022

Uh oh!

nlatipov commented May 3, 2022

Uh oh!

nlatipov commented May 3, 2022

Uh oh!

cchaos left a comment

Uh oh!

nlatipov commented May 3, 2022

Uh oh!

kibana-ci commented May 3, 2022

async chunk count

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

nlatipov commented Apr 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What was done:

Bundle structure:

Uh oh!

elasticmachine commented Apr 28, 2022

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

stratoula commented Apr 28, 2022

Uh oh!

nlatipov commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

nlatipov commented May 2, 2022

Uh oh!

stratoula commented May 3, 2022

Uh oh!

nlatipov commented May 3, 2022

Uh oh!

nlatipov commented May 3, 2022

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

nlatipov commented May 3, 2022

Uh oh!

kibana-ci commented May 3, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

async chunk count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

nlatipov commented Apr 20, 2022 •

edited

Loading

nlatipov commented Apr 28, 2022 •

edited

Loading