[Unified search] Improves the current filter/search experience by stratoula · Pull Request #128401 · elastic/kibana

stratoula · 2022-03-23T17:18:52Z

Summary

Closes #129093
Closes #127244
Closes #127245
Closes #117048
Closes #75289
Closes #130992

This PR contains all the changes that are related to the unified search phase 1 project. A bunch of things have changed and improved from the design perspective but this phase doesn't add new functionalities. Its goal is to improve the current experience.

What has changed

The search bar has now another prop to display a dataview picker with additional controls (add new dataview, add runtime fields etc). Applications: Lens, discover
We now have one menu for the language switcher, filter controls and saved queries management
The layout has changed significantly when there is no search input (showQueryInput: false). Applicatiions: Controls, Dashboard embedded

Storybook

A storybook was added for previewing the SearchBar and its different appearance depending on specific prop values.
node scripts/storybook --unified_search

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

* [Unified search] Moves dataview picker to the search bar * alter texts * Remove unused file * [ChangeDataView] Design cleanup * Fix services mock failure * Show newly created datavuew on the list * Keep dataview picker in discover in mobile view * Cleanup * Cleanup translations * Fix some discover FTs * Fix management FTs * More test fixes * Added a dismissible tour * Pulled the selectabl list into a new component … for reuse Called `DataViewsList`. I then changed Lens’ config panel’s own EuiSelectableList to use this new component instead. *Didn’t do any test updates* * Fix broken jest test * Use the same picker component on Discover mobile view * Apply some CI fixes * Fix more functional tests * More FTs fixes * Close the tour popover for lens tests * More FTs fixes * Fix lens FTs * Using new `styles.ts` pattern for custom styles and allowing for `fullWidth` buttons * Better tour text and i18n * Update copy * No exclamation point * Cleanup * Fixes on discover tests * Fixes on Lens Fts - create runtime fields * Fixes on edit permission of add field in discover and some FTs fixes * Further Fts fixes * More FTs fixes * Made tour opt-in with `showNewMenuTour` * Refactor the OSS FTs to change less files * Further cleanup on the FTs * Remove unecessary action * Fix dataview creation bug * Add a unit test to the new component * More fixes * Fix OSS a11y tests * Adds another unit test for Lens permissions * Make a change to stabilize the tests * Clear flyout prop as it is not used anymore * Deisgn fixes for mobile view * Address PR comments WIP * Update the layrpanl dataview list when a new dataview is created Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* [Unified search] Redesign search bar * Changes to the saved queries design * Remove `globalQueryBar` from nested under `.kbnTopNavMenu__wrapper` * [Security Solution] Removing overrides of `.globaQueryBar` * Cleanup of `.globalQueryBar` styles and variants * General layout fixes/adjustments * More general layout fixes and better defaults * Enable Clear all button if saved query is applied * Clear should be enabled if searched query is applied but not the save as new * fix some bugs on enabling and disabling the menu options * [design] Working on Load Filter set menu * Indicate selection even before the user clicks apply * prettify the time text * Add delete saved qquery confirmation modal * Some cleaning up * Fix the manage saved queries link * Enable load filter set if saved query is created for the first time * Some fixes on linting and on translations * Clanup scss * Make some fixes * Fix navigatation unit test * Fix translations check * Fix rest jest tests * Fix some functional tests * Fix checks * Fixes the appearance of the searchbar components depending on the flags * Fix OSS tests * Fixes on tests and query bar logic * Fix the OSS ally tests * Fix graph and lens KQL bar display problems, apply saveQuery flag correctly * Fix more tests * Fix security solution test * Undo tweaks for graph * Better fix for Graph - Emulate new look, not old - Uses same context menu panel as the new one - Provides the same button type (filter button) * Fix checks and jest test * Further fixes * Fix language switcher test * Hopefully fixes the rest of the solution tests * Cleanup * Fixes on maps filtering * Fix Discover padding * [Discover] Added New Field button to bottom of fields list * Simple responsive behavior * Quick filter updates * CI fixes * area-label fix * 18n translate the add filed btn in discover * Fix lens functional test * fix functional tests * Refactor and add unit test for the add filter button * Add unit test to the saved management list component * Stabilize lens test * Second try to solve the flakiness * Fix panels depending on the flags * Fix jest tests * Fix double menu when only the queryInput is on * Add storybook for the different layouts of the unified search bar * Fix ci checks * Removee hooks comment * Fix flakiness * Fix problem with lens dataview change * Fix checks * Ensure that the query is submitted * Fixes oon CI * Fixes flakiness * Fix checks CI * Update texts * Cleanup * Fix unskipped funtional test * Fix FT * Update src/plugins/unified_search/public/saved_query_form/save_query_form.tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Fix eslint * Fix checks Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* [Unified search] Redesign search bar * Changes to the saved queries design * Remove `globalQueryBar` from nested under `.kbnTopNavMenu__wrapper` * [Security Solution] Removing overrides of `.globaQueryBar` * Cleanup of `.globalQueryBar` styles and variants * General layout fixes/adjustments * More general layout fixes and better defaults * Enable Clear all button if saved query is applied * Clear should be enabled if searched query is applied but not the save as new * fix some bugs on enabling and disabling the menu options * [design] Working on Load Filter set menu * Indicate selection even before the user clicks apply * prettify the time text * Add delete saved qquery confirmation modal * Some cleaning up * Fix the manage saved queries link * Enable load filter set if saved query is created for the first time * Some fixes on linting and on translations * Clanup scss * Make some fixes * Fix navigatation unit test * Fix translations check * Fix rest jest tests * Fix some functional tests * Fix checks * Fixes the appearance of the searchbar components depending on the flags * Fix OSS tests * Fixes on tests and query bar logic * Fix the OSS ally tests * Fix graph and lens KQL bar display problems, apply saveQuery flag correctly * Fix more tests * Fix security solution test * Undo tweaks for graph * Better fix for Graph - Emulate new look, not old - Uses same context menu panel as the new one - Provides the same button type (filter button) * Fix checks and jest test * Further fixes * Fix language switcher test * Hopefully fixes the rest of the solution tests * Cleanup * Fixes on maps filtering * Fix Discover padding * [Discover] Added New Field button to bottom of fields list * Simple responsive behavior * Quick filter updates * CI fixes * area-label fix * 18n translate the add filed btn in discover * Fix lens functional test * fix functional tests * Refactor and add unit test for the add filter button * Add unit test to the saved management list component * Stabilize lens test * Second try to solve the flakiness * Fix panels depending on the flags * Fix jest tests * Fix double menu when only the queryInput is on * Add storybook for the different layouts of the unified search bar * Fix ci checks * Removee hooks comment * Fix flakiness * Fix problem with lens dataview change * Fix checks * Ensure that the query is submitted * Fixes oon CI * Fixes flakiness * Fix checks CI * Update texts * Cleanup * Fix unskipped funtional test * Fix FT * Fixes filter bar responsiveness * Add filter button option to the main menu * Filter form design pass - Added tooltip around “Add filter” icon button - Fixed padding - Stubbed in “Add” vs “Edit” labels * Query menu icon button tooltip * ‘Update’ not ‘Edit’ button label * Apply different strings for adding filter mode vs edit * Hide Manage SO link if the user donesnt have the permissions * Fix the wrapping of the badges and datepicker badge * Minor props naming fix * Fix checks * Fix mobile * Cleanup * Fix checks * Faux button group * Changes on the search input placeholder * Fix CI Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

stratoula · 2022-05-04T13:28:34Z

@mbondyra glitch is fixed!
About the ally issues, @cchaos can you help? I tried to fix them but I can't find out what is going wrong.

mbondyra · 2022-05-04T16:26:59Z

The problem with DataView menu:

EuiContextMenu implements some kind of focus trap - moving all the elements in the menu inside the EuiContextMenu solves the issue (and it should be fine, because items type is Array<React.ReactElement<any, string | React.JSXElementConstructor<any>>[] | undefined>
EuiSelectable works as intended after 1. is fixed -> we tab through the elements, but then use arrows up and down to move between items. That feels odd though for this particular menu, check out the video:

dataview.mov

stratoula · 2022-05-04T16:56:32Z

@mbondyra thanx a lot for looking into it! I think the arrows in the selectable is how the selectable works in EUI. (I see the same behavior in Lens layer dataview picker)
I pushed your solution e9f03b1 ❤️

cchaos · 2022-05-04T19:15:06Z

@mbondyra & @stratoula I've started a new issue around the return focus issue as a quick investigation shows it's a problem with EuiSelectable within EuiContextMenuPanel, but shouldn't hold up this PR. #131566

mbondyra · 2022-05-04T20:41:37Z

@stratoula for the other problem I've submitted an issue in eui. elastic/eui#5869 It would be great to have it fixed for 8.3, but not blocking this PR. Approved, amazing work 💯

dasansol92

Changes on this file x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/components/search_bar.tsx LGTM 👍

crob611 · 2022-05-05T13:56:14Z

One minor visualization issue I noticed, the hover state has rounded corners where the non hover has hard corners

crob611

Presentation changes LGTM 👍

teresaalvarezsoler · 2022-05-05T14:32:13Z

Fwiw, it's a bit difficult to notice the button that users need to click in order to apply the query changes (above all in big screens). Would it be possible to bring the "Refresh" label back again so it's more clear for users that they need to click there? cc/ @ghudgins

cchaos · 2022-05-05T15:51:08Z

@teresaalvarezsoler I've moved your comment to an issue we provide discussion and follow up on as to not hold up this PR specifically since we'd like to get the core functionality merged. #131641

cchaos · 2022-05-05T15:51:35Z

@crob611 The corners are fine 😄

kibana-ci · 2022-05-06T07:09:29Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`dataViewManagement`	139	132	-7
`discover`	447	444	-3
`unifiedSearch`	157	177	+20
total			+10

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`data`	2854	2855	+1
`unifiedSearch`	75	78	+3
total			+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dashboard`	302.2KB	302.2KB	+3.0B
`dataViewManagement`	121.2KB	117.2KB	-4.0KB
`dataVisualizer`	536.4KB	536.0KB	-393.0B
`discover`	408.1KB	404.9KB	-3.2KB
`graph`	474.3KB	474.8KB	+452.0B
`lens`	1.1MB	1.1MB	+1.6KB
`securitySolution`	4.8MB	4.8MB	-546.0B
`stackAlerts`	199.2KB	199.3KB	+22.0B
`unifiedSearch`	151.4KB	188.3KB	+36.9KB
`visualizations`	165.8KB	165.9KB	+31.0B
total			+30.9KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`unifiedSearch`	11	13	+2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`discover`	40.4KB	40.5KB	+143.0B
`navigation`	9.4KB	9.4KB	-3.0B
`unifiedSearch`	54.7KB	30.6KB	-24.1KB
`visTypeMarkdown`	7.0KB	7.0KB	+34.0B
`visTypeTimelion`	10.1KB	10.2KB	+18.0B
`visualizations`	45.9KB	45.9KB	+18.0B
total			-23.9KB

Unknown metric groups

API count

id	before	after	diff
`data`	3466	3467	+1
`unifiedSearch`	79	82	+3
total			+4

async chunk count

id	before	after	diff
`unifiedSearch`	10	12	+2

ESLint disabled line counts

id	before	after	diff
`discover`	36	33	-3
`unifiedSearch`	15	16	+1
total			-2

Total ESLint disabled count

id	before	after	diff
`discover`	38	35	-3
`unifiedSearch`	15	16	+1
total			-2

History

💚 Build #42688 succeeded c865ad0
💛 Build #42569 was flaky 92f9ad0
💚 Build #42473 succeeded eca5885
💔 Build #42440 failed 42ae00c
💚 Build #42370 succeeded e86baaf
💛 Build #42048 was flaky 504d706

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ic#128401) * [Unified search] Moves dataview picker to the search bar (elastic#126560) * [Unified search] Moves dataview picker to the search bar * alter texts * Remove unused file * [ChangeDataView] Design cleanup * Fix services mock failure * Show newly created datavuew on the list * Keep dataview picker in discover in mobile view * Cleanup * Cleanup translations * Fix some discover FTs * Fix management FTs * More test fixes * Added a dismissible tour * Pulled the selectabl list into a new component … for reuse Called `DataViewsList`. I then changed Lens’ config panel’s own EuiSelectableList to use this new component instead. *Didn’t do any test updates* * Fix broken jest test * Use the same picker component on Discover mobile view * Apply some CI fixes * Fix more functional tests * More FTs fixes * Close the tour popover for lens tests * More FTs fixes * Fix lens FTs * Using new `styles.ts` pattern for custom styles and allowing for `fullWidth` buttons * Better tour text and i18n * Update copy * No exclamation point * Cleanup * Fixes on discover tests * Fixes on Lens Fts - create runtime fields * Fixes on edit permission of add field in discover and some FTs fixes * Further Fts fixes * More FTs fixes * Made tour opt-in with `showNewMenuTour` * Refactor the OSS FTs to change less files * Further cleanup on the FTs * Remove unecessary action * Fix dataview creation bug * Add a unit test to the new component * More fixes * Fix OSS a11y tests * Adds another unit test for Lens permissions * Make a change to stabilize the tests * Clear flyout prop as it is not used anymore * Deisgn fixes for mobile view * Address PR comments WIP * Update the layrpanl dataview list when a new dataview is created Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * fix test * Fix CI * Fix i18n checks * [Unified search] Redesign search bar (elastic#126566) * [Unified search] Redesign search bar * Changes to the saved queries design * Remove `globalQueryBar` from nested under `.kbnTopNavMenu__wrapper` * [Security Solution] Removing overrides of `.globaQueryBar` * Cleanup of `.globalQueryBar` styles and variants * General layout fixes/adjustments * More general layout fixes and better defaults * Enable Clear all button if saved query is applied * Clear should be enabled if searched query is applied but not the save as new * fix some bugs on enabling and disabling the menu options * [design] Working on Load Filter set menu * Indicate selection even before the user clicks apply * prettify the time text * Add delete saved qquery confirmation modal * Some cleaning up * Fix the manage saved queries link * Enable load filter set if saved query is created for the first time * Some fixes on linting and on translations * Clanup scss * Make some fixes * Fix navigatation unit test * Fix translations check * Fix rest jest tests * Fix some functional tests * Fix checks * Fixes the appearance of the searchbar components depending on the flags * Fix OSS tests * Fixes on tests and query bar logic * Fix the OSS ally tests * Fix graph and lens KQL bar display problems, apply saveQuery flag correctly * Fix more tests * Fix security solution test * Undo tweaks for graph * Better fix for Graph - Emulate new look, not old - Uses same context menu panel as the new one - Provides the same button type (filter button) * Fix checks and jest test * Further fixes * Fix language switcher test * Hopefully fixes the rest of the solution tests * Cleanup * Fixes on maps filtering * Fix Discover padding * [Discover] Added New Field button to bottom of fields list * Simple responsive behavior * Quick filter updates * CI fixes * area-label fix * 18n translate the add filed btn in discover * Fix lens functional test * fix functional tests * Refactor and add unit test for the add filter button * Add unit test to the saved management list component * Stabilize lens test * Second try to solve the flakiness * Fix panels depending on the flags * Fix jest tests * Fix double menu when only the queryInput is on * Add storybook for the different layouts of the unified search bar * Fix ci checks * Removee hooks comment * Fix flakiness * Fix problem with lens dataview change * Fix checks * Ensure that the query is submitted * Fixes oon CI * Fixes flakiness * Fix checks CI * Update texts * Cleanup * Fix unskipped funtional test * Fix FT * Update src/plugins/unified_search/public/saved_query_form/save_query_form.tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Fix eslint * Fix checks Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Fix jest * Fix jest tests * Stabilize discover security tests * [Unified search] Further enhancements (elastic#129877) * [Unified search] Redesign search bar * Changes to the saved queries design * Remove `globalQueryBar` from nested under `.kbnTopNavMenu__wrapper` * [Security Solution] Removing overrides of `.globaQueryBar` * Cleanup of `.globalQueryBar` styles and variants * General layout fixes/adjustments * More general layout fixes and better defaults * Enable Clear all button if saved query is applied * Clear should be enabled if searched query is applied but not the save as new * fix some bugs on enabling and disabling the menu options * [design] Working on Load Filter set menu * Indicate selection even before the user clicks apply * prettify the time text * Add delete saved qquery confirmation modal * Some cleaning up * Fix the manage saved queries link * Enable load filter set if saved query is created for the first time * Some fixes on linting and on translations * Clanup scss * Make some fixes * Fix navigatation unit test * Fix translations check * Fix rest jest tests * Fix some functional tests * Fix checks * Fixes the appearance of the searchbar components depending on the flags * Fix OSS tests * Fixes on tests and query bar logic * Fix the OSS ally tests * Fix graph and lens KQL bar display problems, apply saveQuery flag correctly * Fix more tests * Fix security solution test * Undo tweaks for graph * Better fix for Graph - Emulate new look, not old - Uses same context menu panel as the new one - Provides the same button type (filter button) * Fix checks and jest test * Further fixes * Fix language switcher test * Hopefully fixes the rest of the solution tests * Cleanup * Fixes on maps filtering * Fix Discover padding * [Discover] Added New Field button to bottom of fields list * Simple responsive behavior * Quick filter updates * CI fixes * area-label fix * 18n translate the add filed btn in discover * Fix lens functional test * fix functional tests * Refactor and add unit test for the add filter button * Add unit test to the saved management list component * Stabilize lens test * Second try to solve the flakiness * Fix panels depending on the flags * Fix jest tests * Fix double menu when only the queryInput is on * Add storybook for the different layouts of the unified search bar * Fix ci checks * Removee hooks comment * Fix flakiness * Fix problem with lens dataview change * Fix checks * Ensure that the query is submitted * Fixes oon CI * Fixes flakiness * Fix checks CI * Update texts * Cleanup * Fix unskipped funtional test * Fix FT * Fixes filter bar responsiveness * Add filter button option to the main menu * Filter form design pass - Added tooltip around “Add filter” icon button - Fixed padding - Stubbed in “Add” vs “Edit” labels * Query menu icon button tooltip * ‘Update’ not ‘Edit’ button label * Apply different strings for adding filter mode vs edit * Hide Manage SO link if the user donesnt have the permissions * Fix the wrapping of the badges and datepicker badge * Minor props naming fix * Fix checks * Fix mobile * Cleanup * Fix checks * Faux button group * Changes on the search input placeholder * Fix CI Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Fix translations * Fix security solution add filter bug * Filter bar / items: Reduce to only necessary wrappers and styles - Switch to Emotion for styling - Rename `FilterBadgesWrapper` to `FilterItems` - Move `FilterItems` and `FilterItem` so own folder `filter_item/` # Conflicts: # src/plugins/unified_search/public/filter_bar/filter_bar.tsx # src/plugins/unified_search/public/filter_bar/filter_editor/lib/filter_label.tsx # src/plugins/unified_search/public/filter_bar/filter_item/filter_item.tsx # src/plugins/unified_search/public/filter_bar/filter_item/filter_items.tsx # src/plugins/unified_search/public/filter_bar/filter_view/index.tsx # src/plugins/unified_search/public/query_string_input/filter_editor_wrapper.tsx # src/plugins/unified_search/public/search_bar/search_bar.tsx * Fix styles by removing styled-components Also added prop `afterQueryBar` to signify that it needs the top margin # Conflicts: # packages/kbn-babel-preset/styled_components_files.js * Refactor `SearchBar` and `QueryBarTopRow` a bit - Added `showSubmitButton` to explicitely hide the submit button (defaults to true) - SearchBar always renders the `QueryBarTopRow` which now fully controls visibility of the pieces - Renamed class with new `uni` prefix - Tried and failed to use Emotion * Update usages # Conflicts: # x-pack/plugins/security_solution/public/common/components/query_bar/index.tsx * Fix a test * Fix jest test * Attaches filter menu when no add button and better dropdown styles * Fix lint errors * Clearing the query and filters of a saved query should unload the saved query * Do not allow to update the loaded saved query if no filters or no query * Fix Graph by creating reusable `KibanaFilterButtonGroup` * Use EuiTheme for SearchBar styles Updated `displayStyle` for Lens & Discover * Fix displayStyle prop problem * Correct alignment of data visualizer * Super nit comment * Data visualizer improvements * Apply useMemo in editPermission cont in Discover * Fix translations checks * Fix translations checks * Fix filter badge popover bug * [Submit button] Changed to EuiSuperUpdateButton - Quickly adds tooltip content and filled state for more prominence when dirty - Fixed 18n * Fix tests * Align the position with the other tolltips and check that functional tests succeed * Give some time to the tooltip to disappear * Fix tests * Fix CI checks * Address PR comments * Move constants outside render * Apply PR comments * Fix dataview picker glich * lovercase emotion function * Fix a11y problem on dataview picker * Lowercase rest of emotion style functions * Clean up Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

stratoula and others added 20 commits March 21, 2022 17:08

Merge branch 'main' into unified-search-1

a658848

Merge branch 'main' into unified-search-1

391b3b5

Merge branch 'main' into unified-search-1

ca79be1

Merge branch 'main' into unified-search-1

ac9bf8e

fix test

78b52a0

Merge branch 'main' into unified-search-1

aacc187

Merge branch 'main' into unified-search-1

e7498fa

Merge branch 'main' into unified-search-1

d67380c

Fix CI

110067c

Merge branch 'main' into unified-search-1

225ce94

Merge with main and resolve conflicts

4811ecd

Fix i18n checks

f9e6696

Merge branch 'main' into unified-search-1

882f862

Merge branch 'main' into unified-search-1

24fafbb

Merge with main and resolve conflicts

78c151e

Merge with main and resolve conflcits

182b8cb

Fix jest

53e7877

Fix jest tests

6603b29

cchaos mentioned this pull request Apr 14, 2022

[Meta] Unified search experience across kibana #126095

Closed

18 tasks

stratoula added release_note:feature Makes this part of the condensed release notes Feature:Unified search Unified search related tasks labels Apr 14, 2022

stratoula added 3 commits April 18, 2022 09:36

Merge with ES lint commit

3d8c255

Merge with main and resolve conflicts

93a2184

Stabilize discover security tests

0599d9d

stratoula added the v8.3.0 label Apr 18, 2022

Merge branch 'main' into unified-search-1

8e0167c

stratoula changed the title ~~Unified search 1~~ [Unified search] Improves the current search experience Apr 20, 2022

stratoula added 2 commits May 4, 2022 16:05

Apply PR comments

10b616a

Fix dataview picker glich

42ae00c

stratoula added 2 commits May 4, 2022 17:12

Merge with main and resolve conflicta

108f0ad

lovercase emotion function

eca5885

Fix a11y problem on dataview picker

e9f03b1

Lowercase rest of emotion style functions

92f9ad0

cchaos mentioned this pull request May 4, 2022

[Unified Search] Data View Menu: Keyboard focus issues #131566

Closed

mbondyra approved these changes May 4, 2022

View reviewed changes

stratoula added 2 commits May 5, 2022 08:31

Merge branch 'main' into unified-search-1

e398ced

Clean up

c865ad0

dasansol92 approved these changes May 5, 2022

View reviewed changes

crob611 approved these changes May 5, 2022

View reviewed changes

cchaos mentioned this pull request May 5, 2022

[Unified Search] Can we improve the visibility of the refresh button on larger screens? #131641

Closed

cchaos mentioned this pull request May 5, 2022

[Unified Search] Discuss Saved query / Filter set naming #131648

Closed

KOTungseth mentioned this pull request May 5, 2022

[DOCS] [Unified Search] Filter/search experience #131667

Closed

Merge branch 'main' into unified-search-1

54d2949

stratoula merged commit 0d4cc4d into main May 6, 2022

stratoula deleted the unified-search-1 branch May 6, 2022 07:10

KOTungseth mentioned this pull request Jun 9, 2022

[DOCS] Adds the Vis Editor 8.3 docs #134115

Merged

Conversation

stratoula commented Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What has changed

Storybook

Checklist

Uh oh!

stratoula commented May 4, 2022

Uh oh!

mbondyra commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

The problem with DataView menu:

Uh oh!

stratoula commented May 4, 2022

Uh oh!

cchaos commented May 4, 2022

Uh oh!

mbondyra commented May 4, 2022

Uh oh!

dasansol92 left a comment

Choose a reason for hiding this comment

Uh oh!

crob611 commented May 5, 2022

Uh oh!

crob611 left a comment

Choose a reason for hiding this comment

Uh oh!

teresaalvarezsoler commented May 5, 2022

Uh oh!

cchaos commented May 5, 2022

Uh oh!

cchaos commented May 5, 2022

Uh oh!

kibana-ci commented May 6, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

stratoula commented Mar 23, 2022 •

edited

Loading

mbondyra commented May 4, 2022 •

edited

Loading