Stabilize and bring back flaky tests#13034
Merged
stacey-gammon merged 5 commits intoelastic:masterfrom Jul 27, 2017
Merged
Conversation
ea62d34 to
4bc3a89
Compare
fc4b515 to
8f039f3
Compare
stacey-gammon
pushed a commit
to stacey-gammon/kibana
that referenced
this pull request
Jul 26, 2017
Caused last 4 builds to fail on master. Will attempt to bring back in elastic#13034
stacey-gammon
pushed a commit
that referenced
this pull request
Jul 26, 2017
Caused last 4 builds to fail on master. Will attempt to bring back in #13034
stacey-gammon
pushed a commit
to stacey-gammon/kibana
that referenced
this pull request
Jul 26, 2017
Caused last 4 builds to fail on master. Will attempt to bring back in elastic#13034
stacey-gammon
pushed a commit
to stacey-gammon/kibana
that referenced
this pull request
Jul 26, 2017
Caused last 4 builds to fail on master. Will attempt to bring back in elastic#13034
This was referenced Jul 26, 2017
4974747 to
5dc38b0
Compare
stacey-gammon
pushed a commit
that referenced
this pull request
Jul 26, 2017
stacey-gammon
pushed a commit
that referenced
this pull request
Jul 26, 2017
d8058e3 to
1755be2
Compare
1755be2 to
1d227fe
Compare
1d227fe to
2f8417a
Compare
Author
|
Passed once Jenkins, test this |
Author
|
Passed twice 🙏 Jenkins, test this |
Author
|
Passed three times 👏 Jenkins, test this |
The retry was moved internally, around a check for stale elements as well, so this should no longer be neccessary.
Author
|
Passed four times 🎉 Jenkins, test this |
Author
|
Passed five times ❤️ ❤️ jenkins, test this |
Author
|
cc @elastic/kibana-platform - if anyone wants to take a look, go for it, otherwise I plan on relying on just @thomasneirynck's review. :) |
Author
|
Passed 6 times, wooooooooooot!! Do I keep it going???? Jenkins, test this |
Author
|
Passed 7 times in a row, I feel like that is sufficient. |
thomasneirynck
approved these changes
Jul 27, 2017
Contributor
thomasneirynck
left a comment
There was a problem hiding this comment.
This is such a nice cleanup. Also, great win on stabilizing test suite.
stacey-gammon
pushed a commit
to stacey-gammon/kibana
that referenced
this pull request
Jul 27, 2017
* Stabalize tests and bring back flaky test * Try to fix flaky map radius visualize test * fix flaky tile map zoom test * Try to fix flaky zoom test by avoiding zooming in and out with spy panel open * Remove duplicate wrapped retry around find methods The retry was moved internally, around a check for stale elements as well, so this should no longer be neccessary.
This was referenced Jul 27, 2017
Contributor
|
💃 this is awesome!! 💃 |
stacey-gammon
pushed a commit
that referenced
this pull request
Jul 28, 2017
* Stabalize tests and bring back flaky test * Try to fix flaky map radius visualize test * fix flaky tile map zoom test * Try to fix flaky zoom test by avoiding zooming in and out with spy panel open * Remove duplicate wrapped retry around find methods The retry was moved internally, around a check for stale elements as well, so this should no longer be neccessary.
stacey-gammon
pushed a commit
to stacey-gammon/kibana
that referenced
this pull request
Jul 28, 2017
* Stabalize tests and bring back flaky test * Try to fix flaky map radius visualize test * fix flaky tile map zoom test * Try to fix flaky zoom test by avoiding zooming in and out with spy panel open * Remove duplicate wrapped retry around find methods The retry was moved internally, around a check for stale elements as well, so this should no longer be neccessary.
stacey-gammon
pushed a commit
that referenced
this pull request
Jul 28, 2017
* Stabalize tests and bring back flaky test * Try to fix flaky map radius visualize test * fix flaky tile map zoom test * Try to fix flaky zoom test by avoiding zooming in and out with spy panel open * Remove duplicate wrapped retry around find methods The retry was moved internally, around a check for stale elements as well, so this should no longer be neccessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work on stabilizing the tests, including bringing back some that were previously skipped due to flakiness:
findservice functions where applicable instead of going direct to remote so we can concentrate retries in fewer places.stale elementerror. This should alleviate the need for many of the outer retries.