Skip to content

[6.0] Stabilize and bring back flaky tests (#13034)#13160

Merged
stacey-gammon merged 1 commit intoelastic:6.0from
stacey-gammon:6.0/test/stabilize-tests
Jul 28, 2017
Merged

[6.0] Stabilize and bring back flaky tests (#13034)#13160
stacey-gammon merged 1 commit intoelastic:6.0from
stacey-gammon:6.0/test/stabilize-tests

Conversation

@stacey-gammon
Copy link
Copy Markdown

@stacey-gammon stacey-gammon commented Jul 27, 2017

  • Stabalize tests and bring back flaky test

  • Try to fix flaky map radius visualize test

  • fix flaky tile map zoom test

  • Try to fix flaky zoom test by avoiding zooming in and out with spy panel open

  • Remove duplicate wrapped retry around find methods

The retry was moved internally, around a check for stale elements as
well, so this should no longer be neccessary.

backports #13034

@stacey-gammon stacey-gammon added the backport This PR is a backport of another PR label Jul 27, 2017
@stacey-gammon
Copy link
Copy Markdown
Author

stacey-gammon commented Jul 27, 2017

jenkins, test this

@stacey-gammon
Copy link
Copy Markdown
Author

stacey-gammon commented Jul 28, 2017 •
edited
Loading

Ah, the issue is that the remove inline awaits PR was not backported to 6.0, which causes the test subjects service to use the find service, and thus should have the extra stale element checks.

     └-: time changes
11:51:00.305        └-> preserved during navigation
11:51:00.305          └-> "before each" hook: global before each
11:51:00.310            │ debg  Kibana uiSettings are in elasticsearch and the server is reporting a green status
11:51:00.325          │ debg  ensureTimePickerIsOpen: true
11:51:00.325          │ debg  --Clicking Quick button
11:51:00.497          │ debg  click Visualize tab
11:51:00.497          │ debg  clickSelector(a[href*='visualize'])
11:51:00.603          │ debg  doesTestSubjectExist top-nav
11:51:00.673          │ debg  isGlobalLoadingIndicatorHidden
11:51:00.721          │ debg  findByCssSelector [data-test-subj="globalLoadingIndicator"].ng-hide
11:51:00.731          │ debg  click Dashboard tab
11:51:00.731          │ debg  clickSelector(a[href*='dashboard'])
11:51:00.823          │ debg  doesTestSubjectExist top-nav
11:51:00.841          │ debg  isGlobalLoadingIndicatorHidden
11:51:00.841          │ debg  findByCssSelector [data-test-subj="globalLoadingIndicator"].ng-hide
11:51:00.850          │ debg  in findTestSubject: [data-test-subj~="globalTimepickerRange"]
11:51:01.081          │ debg  Taking screenshot "/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/test/functional/screenshots/failure/dashboard app dashboard time time changes preserved during navigation.png"
11:51:01.237        └- ✖ fail: "dashboard app dashboard time time changes preserved during navigation"
11:51:01.240        │        [GET http://localhost:9515/session/650d4e4cbe948a95484d6a00fc426f0e/element/0.008184438231167324-73/displayed] stale element reference: element is not attached to the page document
11:51:01.240        │         (Session info: chrome=59.0.3071.115)
11:51:01.240        │         (Driver info: chromedriver=2.29.461571 (

@stacey-gammon stacey-gammon mentioned this pull request Jul 28, 2017
Merged
Stabilize and bring back flaky tests (elastic#13034)
a963d56 
* Stabalize tests and bring back flaky test

* Try to fix flaky map radius visualize test

* fix flaky tile map zoom test

* Try to fix flaky zoom test by avoiding zooming in and out with spy panel open

* Remove duplicate wrapped retry around find methods

The retry was moved internally, around a check for stale elements as
well, so this should no longer be neccessary.
@stacey-gammon stacey-gammon force-pushed the 6.0/test/stabilize-tests branch from 1819f37 to a963d56 Compare July 28, 2017 13:46
@stacey-gammon stacey-gammon merged commit e55ac10 into elastic:6.0 Jul 28, 2017
@stacey-gammon stacey-gammon deleted the 6.0/test/stabilize-tests branch October 24, 2017 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@stacey-gammon