by default metric should not define color#12993
Merged
ppisljar merged 1 commit intoelastic:masterfrom Jul 28, 2017
Merged
Conversation
Contributor
Author
|
jenkins, test this |
|
+1 |
Contributor
thomasneirynck
left a comment
There was a problem hiding this comment.
LGTM pending passing CI (probably just need to merge in latests master)
c8c69c5 to
83567dd
Compare
ppisljar
added a commit
that referenced
this pull request
Jul 28, 2017
ppisljar
added a commit
that referenced
this pull request
Jul 28, 2017
ppisljar
added a commit
that referenced
this pull request
Jul 28, 2017
ppisljar
added a commit
that referenced
this pull request
Jul 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
review_note: fixes metric visualization colors for dark theme
Resolves: #12724
to reproduce: create a metric, put it on dashboard and set dashboard to dark theme. metric will be hardly visible.
the reason is, that with new metric in 5.5 we introduced an option to override metric color. but changing the metric to have color override defined by default is a breaking change + its not needed.
closes #12724