[Fleet] Add telemetry for integration cards#115413
Merged
thomasneirynck merged 4 commits intoelastic:masterfrom Oct 19, 2021
Merged
[Fleet] Add telemetry for integration cards#115413thomasneirynck merged 4 commits intoelastic:masterfrom
thomasneirynck merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
joshdover
approved these changes
Oct 19, 2021
| const unmount = renderApp(startServices, params, config, kibanaVersion, extensions); | ||
|
|
||
| const Tracker = | ||
| deps.usageCollection?.components.ApplicationUsageTrackingProvider ?? React.Fragment; |
Contributor
There was a problem hiding this comment.
Interesting little trick here with React.Fragment. Any risks to using this vs. a simple 'passthrough' component like:
const Passthrough: React.FC = ({ children }) => children
Contributor
Author
There was a problem hiding this comment.
This is boilerplate from the telemetry-docs
The same syntax is used also in the ML, SIEM, and Maps plugins.
kibana/x-pack/plugins/maps/public/plugin.ts
Line 186 in a67eef4
So I think it should be OK.
Contributor
|
FYI this PR adds a few "featured" cards that we need to track as well. I added note here about how this could be done, but want to mention it here to ensure it doesn't get missed: #115495 (comment) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 19, 2021
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 19, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 19, 2021
…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (30 commits) Fix potential error from undefined (elastic#115562) [App Search, Crawler] Fix validation step panel padding/whitespace (elastic#115542) [Cases][Connectors] ServiceNow ITOM: MVP (elastic#114125) Change default session idle timeout to 8 hours. (elastic#115565) Upgrade EUI to v39.1.1 (elastic#114732) [App Search] Wired up organic results on Curation Suggestions view (elastic#114717) [i18n] remove i18n html extractor (elastic#115004) [Logs/Metrics UI] Add deprecated field configuration to Deprecations API (elastic#115103) [Transform] Add alerting rules management to Transform UI (elastic#115363) Update UI links to Fleet and Agent docs (elastic#115295) [ML] Adding ability to change data view in advanced job wizard (elastic#115191) Change deleteByNamespace to include legacy URL aliases (elastic#115459) [Unified Integrations] Remove and cleanup add data views (elastic#115424) [Discover] Show ignored field values (elastic#115040) [ML] Stop reading the ml.max_open_jobs node attribute (elastic#115524) [Discover] Improve doc viewer code in Discover (elastic#114759) [Security Solutions] Adds security detection rule actions as importable and exportable (elastic#115243) [Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule (elastic#115101) [Fleet] Add telemetry for integration cards (elastic#115413) 🐛 Fix single percentile case when ES is returning no buckets (elastic#115214) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #113835
Adds
data-test-subjattribute and UI-tracker to package-cards.idfor both is of the form:integration-card:[epr|ui_link]:{card-id}For maintainers