[Cases][Connectors] ServiceNow ITOM: MVP by cnasikas · Pull Request #114125 · elastic/kibana

cnasikas · 2021-10-06T15:14:39Z

Summary

Depends on: #105440
Implementation of #114081

doc preview: https://kibana_114125.docs-preview.app.elstc.co/guide/en/kibana/master/action-types.html
then click on "ServiceNow ITOM"

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-10-13T10:57:55Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

elasticmachine · 2021-10-13T10:57:56Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine · 2021-10-13T10:57:57Z

Pinging @elastic/security-threat-hunting-cases (Feature:Cases)

cnasikas · 2021-10-13T10:59:57Z

x-pack/plugins/actions/README.md

 ## user interface

-To make this action usable in the Kibana UI, you will need to provide all the UI editing aspects of the action. The existing action type user interfaces are defined in [`x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types`](../triggers_actions_ui/public/application/components/builtin_action_types). For more information, see the [UI documentation](../triggers_actions_ui/README.md#create-and-register-new-action-type-ui).
+To make this action usable in the Kibana UI, you will need to provide all the UI editing aspects of the action. The existing action type user interfaces are defined in [`x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types`](../triggers_actions_ui/public/application/components/builtin_action_types). For more information, see the [UI documentation](../triggers_actions_ui/README.md#create-and-register-new-action-type-ui).


This was done by an automated formating tool. Nothing is changed.

cnasikas · 2021-10-18T23:39:14Z

@elasticmachine merge upstream

cnasikas · 2021-10-18T23:41:03Z

@elasticmachine merge upstream

cnasikas · 2021-10-19T05:34:29Z

@elasticmachine merge upstream

cnasikas · 2021-10-19T07:50:43Z

@elasticmachine merge upstream

cnasikas · 2021-10-19T09:18:03Z

@elasticmachine merge upstream

cnasikas · 2021-10-19T11:43:09Z

@elasticmachine merge upstream

cnasikas · 2021-10-19T14:09:04Z

@elasticmachine merge upstream

kibanamachine · 2021-10-19T16:39:47Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2764	2765	+1
`triggersActionsUi`	379	382	+3
total			+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	317.5KB	303.9KB	-13.5KB
`triggersActionsUi`	789.4KB	814.2KB	+24.8KB
total			+11.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cases`	80.5KB	80.5KB	+30.0B
`securitySolution`	104.2KB	104.2KB	+28.0B
`triggersActionsUi`	50.8KB	51.8KB	+1.0KB
total			+1.1KB

Unknown metric groups

async chunk count

id	before	after	diff
`cases`	15	16	+1
`triggersActionsUi`	64	66	+2
total			+3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-10-19T16:42:38Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (30 commits) Fix potential error from undefined (elastic#115562) [App Search, Crawler] Fix validation step panel padding/whitespace (elastic#115542) [Cases][Connectors] ServiceNow ITOM: MVP (elastic#114125) Change default session idle timeout to 8 hours. (elastic#115565) Upgrade EUI to v39.1.1 (elastic#114732) [App Search] Wired up organic results on Curation Suggestions view (elastic#114717) [i18n] remove i18n html extractor (elastic#115004) [Logs/Metrics UI] Add deprecated field configuration to Deprecations API (elastic#115103) [Transform] Add alerting rules management to Transform UI (elastic#115363) Update UI links to Fleet and Agent docs (elastic#115295) [ML] Adding ability to change data view in advanced job wizard (elastic#115191) Change deleteByNamespace to include legacy URL aliases (elastic#115459) [Unified Integrations] Remove and cleanup add data views (elastic#115424) [Discover] Show ignored field values (elastic#115040) [ML] Stop reading the ml.max_open_jobs node attribute (elastic#115524) [Discover] Improve doc viewer code in Discover (elastic#114759) [Security Solutions] Adds security detection rule actions as importable and exportable (elastic#115243) [Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule (elastic#115101) [Fleet] Add telemetry for integration cards (elastic#115413) 🐛 Fix single percentile case when ES is returning no buckets (elastic#115214) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>

cnasikas added Team:Threat Hunting Security Solution Threat Hunting Team Feature:Cases Cases feature v7.16.0 Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework Team:Threat Hunting:Cases labels Oct 6, 2021

cnasikas self-assigned this Oct 6, 2021

cnasikas added the Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// label Oct 6, 2021

cnasikas force-pushed the itom_mvp branch 2 times, most recently from 50b5cf3 to 025e0d3 Compare October 8, 2021 13:46

cnasikas added 3 commits October 13, 2021 11:00

Create itom service

1f9ee81

Register itom connector

8bac8f6

Register itom ui connector

76a651a

cnasikas force-pushed the itom_mvp branch from 025e0d3 to 76a651a Compare October 13, 2021 08:01

cnasikas added 2 commits October 13, 2021 13:56

Make severity required

0ae3042

Add additional information

71be5f2

cnasikas force-pushed the itom_mvp branch from 3ad7c28 to 71be5f2 Compare October 13, 2021 10:56

cnasikas marked this pull request as ready for review October 13, 2021 10:57

cnasikas requested review from a team as code owners October 13, 2021 10:57

Remove text from readme

b3dc5a3

cnasikas commented Oct 13, 2021

View reviewed changes

Add backend tests

2b2ad41

cnasikas added release_note:skip Skip the PR/issue when compiling release notes release_note:feature Makes this part of the condensed release notes and removed release_note:skip Skip the PR/issue when compiling release notes labels Oct 13, 2021

cnasikas added 2 commits October 13, 2021 19:52

Add docs

0e73412

Use message key to group alerts

63a4d41

Merge branch 'master' into itom_mvp

c305d37

Merge branch 'master' into itom_mvp

03228e7

Merge branch 'master' into itom_mvp

138d4fe

elastic deleted a comment from kibanamachine Oct 18, 2021

Merge branch 'master' into itom_mvp

235ceee

Merge branch 'master' into itom_mvp

2a95f93

Merge branch 'master' into itom_mvp

11d841d

cnasikas closed this Oct 19, 2021

auto-merge was automatically disabled October 19, 2021 11:43
Pull request was closed

cnasikas reopened this Oct 19, 2021

Merge branch 'master' into itom_mvp

2aba958

cnasikas enabled auto-merge (squash) October 19, 2021 11:43

cnasikas linked an issue Oct 19, 2021 that may be closed by this pull request

[Connectors] ServiceNow ITOM: MVP #114081

Closed

Merge branch 'master' into itom_mvp

d9a079f

cnasikas merged commit 20b11c9 into elastic:master Oct 19, 2021

cnasikas deleted the itom_mvp branch October 19, 2021 16:39

kibanamachine mentioned this pull request Oct 19, 2021

[7.x] [Cases][Connectors] ServiceNow ITOM: MVP (#114125) #115599

Merged

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 19, 2021

[Cases][Connectors] ServiceNow ITOM: MVP (elastic#114125)

f272072

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine added a commit that referenced this pull request Oct 19, 2021

[Cases][Connectors] ServiceNow ITOM: MVP (#114125) (#115599)

12f9c11

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>

Conversation

cnasikas commented Oct 6, 2021 • edited by pmuellr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Oct 13, 2021

Uh oh!

elasticmachine commented Oct 13, 2021

Uh oh!

elasticmachine commented Oct 13, 2021

Uh oh!

cnasikas Oct 13, 2021

Choose a reason for hiding this comment

Uh oh!

cnasikas commented Oct 18, 2021

Uh oh!

cnasikas commented Oct 18, 2021

Uh oh!

cnasikas commented Oct 19, 2021

Uh oh!

cnasikas commented Oct 19, 2021

Uh oh!

cnasikas commented Oct 19, 2021

Uh oh!

cnasikas commented Oct 19, 2021

Uh oh!

cnasikas commented Oct 19, 2021

Uh oh!

kibanamachine commented Oct 19, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

History

Uh oh!

kibanamachine commented Oct 19, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cnasikas commented Oct 6, 2021 •

edited by pmuellr

Loading