Skip to content

[Upgrade Assistant] Update copy to use "issues" instead of "warnings"#111817

Merged
alisonelizabeth merged 3 commits intoelastic:7.xfrom
alisonelizabeth:ua/copy_updates
Sep 10, 2021
Merged

[Upgrade Assistant] Update copy to use "issues" instead of "warnings"#111817
alisonelizabeth merged 3 commits intoelastic:7.xfrom
alisonelizabeth:ua/copy_updates

Conversation

@alisonelizabeth
Copy link
Copy Markdown
Contributor

Follow-up to #111221.

@alisonelizabeth alisonelizabeth added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant v7.16.0 labels Sep 10, 2021
@alisonelizabeth alisonelizabeth marked this pull request as ready for review September 10, 2021 13:00
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Didn't test locally, code LGTM.

@alisonelizabeth
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / general / X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/spaces_only/tests/actions/enqueue·ts.alerting api integration spaces only Actions enqueue should never leaved a failed task, even if max attempts is reached

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 3 times on tracked branches: https://github.com/elastic/kibana/issues/111812

[00:00:00]       │
[00:00:00]         └-: alerting api integration spaces only
[00:00:00]           └-> "before all" hook in "alerting api integration spaces only"
[00:00:00]           └-: Actions
[00:00:00]             └-> "before all" hook in "Actions"
[00:00:00]             └-> "before all" hook in "Actions"
[00:00:00]               │ debg creating space
[00:00:00]               │ debg created space
[00:00:00]               │ debg creating space
[00:00:01]               │ debg created space
[00:00:59]             └-: enqueue
[00:00:59]               └-> "before all" hook for "should handle enqueue request appropriately"
[00:00:59]               └-> "before all" hook for "should handle enqueue request appropriately"
[00:00:59]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana-alerting-test-data] creating index, cause [api], templates [], shards [1]/[1]
[00:00:59]               └-> should handle enqueue request appropriately
[00:00:59]                 └-> "before each" hook: global before each for "should handle enqueue request appropriately"
[00:01:00]                 │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_7.16.0_001/wt3CVgoSSGOt0O7aOy9F3Q] update_mapping [_doc]
[00:01:01]                 │ debg --- retry.try error: Expected 1 but received 0.
[00:01:01]                 │ debg --- retry.try failed again with the same message...
[00:01:02]                 │ debg --- retry.try failed again with the same message...
[00:01:02]                 │ debg --- retry.try failed again with the same message...
[00:01:03]                 │ debg --- retry.try failed again with the same message...
[00:01:03]                 │ debg --- retry.try failed again with the same message...
[00:01:04]                 │ debg --- retry.try failed again with the same message...
[00:01:04]                 │ debg --- retry.try failed again with the same message...
[00:01:05]                 │ proc [kibana]   log   [18:02:25.150] [info][eventLog][plugins] event logged: {"@timestamp":"2021-09-10T18:02:25.149Z","event":{"provider":"actions","action":"execute-start","start":"2021-09-10T18:02:25.148Z"},"kibana":{"task":{"scheduled":"2021-09-10T18:02:21.154Z","schedule_delay":3994000000},"saved_objects":[{"rel":"primary","type":"action","id":"3d5c4e70-1261-11ec-bdba-0382ab969aa6","type_id":"test.index-record","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"7.16.0"},"message":"action started: test.index-record:3d5c4e70-1261-11ec-bdba-0382ab969aa6: My action","ecs":{"version":"1.8.0"}}
[00:01:05]                 │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana-alerting-test-data/7C8QlvhtRBy4Wvh69ikxzA] update_mapping [_doc]
[00:01:05]                 │ debg --- retry.try failed again with the same message...
[00:01:05]                 │ debg --- retry.try failed again with the same message...
[00:01:06]                 │ proc [kibana]   log   [18:02:26.181] [info][eventLog][plugins] event logged: {"@timestamp":"2021-09-10T18:02:26.180Z","event":{"provider":"actions","action":"execute","start":"2021-09-10T18:02:25.148Z","end":"2021-09-10T18:02:26.180Z","duration":1032000000,"outcome":"success"},"kibana":{"task":{"scheduled":"2021-09-10T18:02:21.154Z","schedule_delay":3994000000},"saved_objects":[{"rel":"primary","type":"action","id":"3d5c4e70-1261-11ec-bdba-0382ab969aa6","type_id":"test.index-record","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"7.16.0"},"message":"action executed: test.index-record:3d5c4e70-1261-11ec-bdba-0382ab969aa6: My action","ecs":{"version":"1.8.0"}}
[00:01:06]                 └- ✓ pass  (7.0s) "alerting api integration spaces only Actions enqueue should handle enqueue request appropriately"
[00:01:06]               └-> should cleanup task after a failure
[00:01:06]                 └-> "before each" hook: global before each for "should cleanup task after a failure"
[00:01:08]                 │ debg --- retry.try error: Expected 1 but received 0.
[00:01:08]                 │ debg --- retry.try failed again with the same message...
[00:01:09]                 │ debg --- retry.try failed again with the same message...
[00:01:09]                 │ debg --- retry.try failed again with the same message...
[00:01:10]                 │ debg --- retry.try failed again with the same message...
[00:01:10]                 │ debg --- retry.try failed again with the same message...
[00:01:11]                 │ proc [kibana]   log   [18:02:31.134] [info][eventLog][plugins] event logged: {"@timestamp":"2021-09-10T18:02:31.131Z","event":{"provider":"actions","action":"execute-start","start":"2021-09-10T18:02:31.131Z"},"kibana":{"task":{"scheduled":"2021-09-10T18:02:28.179Z","schedule_delay":2952000000},"saved_objects":[{"rel":"primary","type":"action","id":"418f22b0-1261-11ec-bdba-0382ab969aa6","type_id":"test.failing","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"7.16.0"},"message":"action started: test.failing:418f22b0-1261-11ec-bdba-0382ab969aa6: My action","ecs":{"version":"1.8.0"}}
[00:01:11]                 │ proc [kibana]   log   [18:02:31.189] [warning][actions][plugins] action execution failure: test.failing:418f22b0-1261-11ec-bdba-0382ab969aa6: My action: an error occurred while running the action executor: expected failure for .kibana-alerting-test-data actions-enqueue-2:space1:418f22b0-1261-11ec-bdba-0382ab969aa6
[00:01:11]                 │ proc [kibana]   log   [18:02:31.191] [info][eventLog][plugins] event logged: {"@timestamp":"2021-09-10T18:02:31.190Z","event":{"provider":"actions","action":"execute","start":"2021-09-10T18:02:31.131Z","end":"2021-09-10T18:02:31.189Z","duration":58000000,"outcome":"failure"},"kibana":{"task":{"scheduled":"2021-09-10T18:02:28.179Z","schedule_delay":2952000000},"saved_objects":[{"rel":"primary","type":"action","id":"418f22b0-1261-11ec-bdba-0382ab969aa6","type_id":"test.failing","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"7.16.0"},"message":"action execution failure: test.failing:418f22b0-1261-11ec-bdba-0382ab969aa6: My action","error":{"message":"an error occurred while running the action executor: expected failure for .kibana-alerting-test-data actions-enqueue-2:space1:418f22b0-1261-11ec-bdba-0382ab969aa6"},"ecs":{"version":"1.8.0"}}
[00:01:11]                 │ proc [kibana]   log   [18:02:31.192] [error][actions][plugins] Action '418f22b0-1261-11ec-bdba-0382ab969aa6' failed and will not retry: an error occurred while running the action executor
[00:01:11]                 │ debg --- retry.try error: expected 1 to sort of equal 0
[00:01:11]                 │ debg --- retry.try failed again with the same message...
[00:01:12]                 │ debg --- retry.try failed again with the same message...
[00:01:12]                 │ debg --- retry.try failed again with the same message...
[00:01:13]                 └- ✓ pass  (7.0s) "alerting api integration spaces only Actions enqueue should cleanup task after a failure"
[00:01:13]               └-> should never leaved a failed task, even if max attempts is reached
[00:01:13]                 └-> "before each" hook: global before each for "should never leaved a failed task, even if max attempts is reached"
[00:01:15]                 │ debg --- retry.try error: expected 0 to sort of equal 1
[00:01:15]                 │ debg --- retry.try failed again with the same message...
[00:01:16]                 │ debg --- retry.try failed again with the same message...
[00:01:16]                 │ debg --- retry.try failed again with the same message...
[00:01:17]                 │ proc [kibana]   log   [18:02:37.139] [info][eventLog][plugins] event logged: {"@timestamp":"2021-09-10T18:02:37.138Z","event":{"provider":"actions","action":"execute-start","start":"2021-09-10T18:02:37.138Z"},"kibana":{"task":{"scheduled":"2021-09-10T18:02:35.210Z","schedule_delay":1927000000},"saved_objects":[{"rel":"primary","type":"action","id":"45c0be70-1261-11ec-bdba-0382ab969aa6","type_id":"test.no-attempts-rate-limit","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"7.16.0"},"message":"action started: test.no-attempts-rate-limit:45c0be70-1261-11ec-bdba-0382ab969aa6: My action","ecs":{"version":"1.8.0"}}
[00:01:17]                 │ proc [kibana]   log   [18:02:37.197] [warning][actions][plugins] action execution failure: test.no-attempts-rate-limit:45c0be70-1261-11ec-bdba-0382ab969aa6: My action: unknown error running action; retry at 2021-09-10T18:02:33.297Z
[00:01:17]                 │ proc [kibana]   log   [18:02:37.199] [info][eventLog][plugins] event logged: {"@timestamp":"2021-09-10T18:02:37.198Z","event":{"provider":"actions","action":"execute","start":"2021-09-10T18:02:37.138Z","end":"2021-09-10T18:02:37.197Z","duration":59000000,"outcome":"failure"},"kibana":{"task":{"scheduled":"2021-09-10T18:02:35.210Z","schedule_delay":1927000000},"saved_objects":[{"rel":"primary","type":"action","id":"45c0be70-1261-11ec-bdba-0382ab969aa6","type_id":"test.no-attempts-rate-limit","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"7.16.0"},"message":"action execution failure: test.no-attempts-rate-limit:45c0be70-1261-11ec-bdba-0382ab969aa6: My action","error":{"message":"unknown error running action; retry at 2021-09-10T18:02:33.297Z"},"ecs":{"version":"1.8.0"}}
[00:01:17]                 │ proc [kibana]   log   [18:02:37.199] [error][actions][plugins] Action '45c0be70-1261-11ec-bdba-0382ab969aa6' failed and will not retry: undefined
[00:01:17]                 │ debg --- retry.try failed again with the same message...
[00:01:17]                 │ debg --- retry.try failed again with the same message...
[00:01:18]                 │ debg --- retry.try failed again with the same message...
[00:01:18]                 │ debg --- retry.try failed again with the same message...
[00:01:19]                 │ debg --- retry.try failed again with the same message...
[00:01:19]                 │ debg --- retry.try failed again with the same message...
[00:01:20]                 │ debg --- retry.try failed again with the same message...
[00:01:20]                 │ debg --- retry.try failed again with the same message...
[00:01:21]                 │ debg --- retry.try failed again with the same message...
[00:01:21]                 │ debg --- retry.try failed again with the same message...
[00:01:22]                 │ debg --- retry.try failed again with the same message...
[00:01:22]                 │ debg --- retry.try failed again with the same message...
[00:01:23]                 │ debg --- retry.try failed again with the same message...
[00:01:23]                 │ debg --- retry.try failed again with the same message...
[00:01:24]                 │ debg --- retry.try failed again with the same message...
[00:01:24]                 │ debg --- retry.try failed again with the same message...
[00:01:25]                 │ debg --- retry.try failed again with the same message...
[00:01:25]                 │ debg --- retry.try failed again with the same message...
[00:01:26]                 │ debg --- retry.try failed again with the same message...
[00:01:26]                 │ debg --- retry.try failed again with the same message...
[00:01:27]                 │ debg --- retry.try failed again with the same message...
[00:01:27]                 │ debg --- retry.try failed again with the same message...
[00:01:28]                 │ debg --- retry.try failed again with the same message...
[00:01:28]                 │ debg --- retry.try failed again with the same message...
[00:01:29]                 │ debg --- retry.try failed again with the same message...
[00:01:29]                 │ debg --- retry.try failed again with the same message...
[00:01:30]                 │ debg --- retry.try failed again with the same message...
[00:01:30]                 │ debg --- retry.try failed again with the same message...
[00:01:31]                 │ debg --- retry.try failed again with the same message...
[00:01:32]                 │ debg --- retry.try failed again with the same message...
[00:01:32]                 │ debg --- retry.try failed again with the same message...
[00:01:33]                 │ debg --- retry.try failed again with the same message...
[00:01:33]                 │ debg --- retry.try failed again with the same message...
[00:01:34]                 │ debg --- retry.try failed again with the same message...
[00:01:34]                 │ debg --- retry.try failed again with the same message...
[00:01:35]                 │ debg --- retry.try failed again with the same message...
[00:01:35]                 │ debg --- retry.try failed again with the same message...
[00:01:36]                 │ debg --- retry.try failed again with the same message...
[00:01:36]                 │ debg --- retry.try failed again with the same message...
[00:01:37]                 │ debg --- retry.try failed again with the same message...
[00:01:37]                 │ debg --- retry.try failed again with the same message...
[00:01:38]                 │ debg --- retry.try failed again with the same message...
[00:01:38]                 │ debg --- retry.try failed again with the same message...
[00:01:39]                 │ debg --- retry.try failed again with the same message...
[00:01:39]                 │ debg --- retry.try failed again with the same message...
[00:01:40]                 │ debg --- retry.try failed again with the same message...
[00:01:40]                 │ debg --- retry.try failed again with the same message...
[00:01:41]                 │ debg --- retry.try failed again with the same message...
[00:01:41]                 │ debg --- retry.try failed again with the same message...
[00:01:42]                 │ debg --- retry.try failed again with the same message...
[00:01:42]                 │ debg --- retry.try failed again with the same message...
[00:01:43]                 │ debg --- retry.try failed again with the same message...
[00:01:43]                 │ debg --- retry.try failed again with the same message...
[00:01:44]                 │ debg --- retry.try failed again with the same message...
[00:01:44]                 │ debg --- retry.try failed again with the same message...
[00:01:45]                 │ debg --- retry.try failed again with the same message...
[00:01:45]                 │ debg --- retry.try failed again with the same message...
[00:01:46]                 │ debg --- retry.try failed again with the same message...
[00:01:46]                 │ debg --- retry.try failed again with the same message...
[00:01:47]                 │ debg --- retry.try failed again with the same message...
[00:01:47]                 │ debg --- retry.try failed again with the same message...
[00:01:48]                 │ debg --- retry.try failed again with the same message...
[00:01:48]                 │ debg --- retry.try failed again with the same message...
[00:01:49]                 │ debg --- retry.try failed again with the same message...
[00:01:49]                 │ debg --- retry.try failed again with the same message...
[00:01:50]                 │ debg --- retry.try failed again with the same message...
[00:01:50]                 │ debg --- retry.try failed again with the same message...
[00:01:51]                 │ debg --- retry.try failed again with the same message...
[00:01:51]                 │ debg --- retry.try failed again with the same message...
[00:01:52]                 │ debg --- retry.try failed again with the same message...
[00:01:52]                 │ debg --- retry.try failed again with the same message...
[00:01:53]                 │ debg --- retry.try failed again with the same message...
[00:01:53]                 │ debg --- retry.try failed again with the same message...
[00:01:54]                 │ debg --- retry.try failed again with the same message...
[00:01:54]                 │ debg --- retry.try failed again with the same message...
[00:01:55]                 │ debg --- retry.try failed again with the same message...
[00:01:55]                 │ debg --- retry.try failed again with the same message...
[00:01:56]                 │ debg --- retry.try failed again with the same message...
[00:01:56]                 │ debg --- retry.try failed again with the same message...
[00:01:57]                 │ debg --- retry.try failed again with the same message...
[00:01:57]                 │ debg --- retry.try failed again with the same message...
[00:01:58]                 │ debg --- retry.try failed again with the same message...
[00:01:58]                 │ debg --- retry.try failed again with the same message...
[00:01:59]                 │ debg --- retry.try failed again with the same message...
[00:01:59]                 │ debg --- retry.try failed again with the same message...
[00:02:00]                 │ debg --- retry.try failed again with the same message...
[00:02:00]                 │ debg --- retry.try failed again with the same message...
[00:02:01]                 │ debg --- retry.try failed again with the same message...
[00:02:01]                 │ debg --- retry.try failed again with the same message...
[00:02:02]                 │ debg --- retry.try failed again with the same message...
[00:02:02]                 │ debg --- retry.try failed again with the same message...
[00:02:03]                 │ debg --- retry.try failed again with the same message...
[00:02:04]                 │ debg --- retry.try failed again with the same message...
[00:02:04]                 │ debg --- retry.try failed again with the same message...
[00:02:05]                 │ debg --- retry.try failed again with the same message...
[00:02:05]                 │ debg --- retry.try failed again with the same message...
[00:02:06]                 │ debg --- retry.try failed again with the same message...
[00:02:06]                 │ debg --- retry.try failed again with the same message...
[00:02:07]                 │ debg --- retry.try failed again with the same message...
[00:02:07]                 │ debg --- retry.try failed again with the same message...
[00:02:08]                 │ debg --- retry.try failed again with the same message...
[00:02:08]                 │ debg --- retry.try failed again with the same message...
[00:02:09]                 │ debg --- retry.try failed again with the same message...
[00:02:09]                 │ debg --- retry.try failed again with the same message...
[00:02:10]                 │ debg --- retry.try failed again with the same message...
[00:02:10]                 │ debg --- retry.try failed again with the same message...
[00:02:11]                 │ debg --- retry.try failed again with the same message...
[00:02:11]                 │ debg --- retry.try failed again with the same message...
[00:02:12]                 │ debg --- retry.try failed again with the same message...
[00:02:12]                 │ debg --- retry.try failed again with the same message...
[00:02:13]                 │ debg --- retry.try failed again with the same message...
[00:02:13]                 │ debg --- retry.try failed again with the same message...
[00:02:14]                 │ debg --- retry.try failed again with the same message...
[00:02:14]                 │ debg --- retry.try failed again with the same message...
[00:02:15]                 │ debg --- retry.try failed again with the same message...
[00:02:15]                 │ debg --- retry.try failed again with the same message...
[00:02:16]                 │ debg --- retry.try failed again with the same message...
[00:02:16]                 │ debg --- retry.try failed again with the same message...
[00:02:17]                 │ debg --- retry.try failed again with the same message...
[00:02:17]                 │ debg --- retry.try failed again with the same message...
[00:02:18]                 │ debg --- retry.try failed again with the same message...
[00:02:18]                 │ debg --- retry.try failed again with the same message...
[00:02:19]                 │ debg --- retry.try failed again with the same message...
[00:02:19]                 │ debg --- retry.try failed again with the same message...
[00:02:20]                 │ debg --- retry.try failed again with the same message...
[00:02:20]                 │ debg --- retry.try failed again with the same message...
[00:02:21]                 │ debg --- retry.try failed again with the same message...
[00:02:21]                 │ debg --- retry.try failed again with the same message...
[00:02:22]                 │ debg --- retry.try failed again with the same message...
[00:02:22]                 │ debg --- retry.try failed again with the same message...
[00:02:23]                 │ debg --- retry.try failed again with the same message...
[00:02:23]                 │ debg --- retry.try failed again with the same message...
[00:02:24]                 │ debg --- retry.try failed again with the same message...
[00:02:24]                 │ debg --- retry.try failed again with the same message...
[00:02:25]                 │ debg --- retry.try failed again with the same message...
[00:02:25]                 │ debg --- retry.try failed again with the same message...
[00:02:26]                 │ debg --- retry.try failed again with the same message...
[00:02:26]                 │ debg --- retry.try failed again with the same message...
[00:02:27]                 │ debg --- retry.try failed again with the same message...
[00:02:27]                 │ debg --- retry.try failed again with the same message...
[00:02:28]                 │ debg --- retry.try failed again with the same message...
[00:02:28]                 │ debg --- retry.try failed again with the same message...
[00:02:29]                 │ debg --- retry.try failed again with the same message...
[00:02:29]                 │ debg --- retry.try failed again with the same message...
[00:02:30]                 │ debg --- retry.try failed again with the same message...
[00:02:30]                 │ debg --- retry.try failed again with the same message...
[00:02:31]                 │ debg --- retry.try failed again with the same message...
[00:02:31]                 │ debg --- retry.try failed again with the same message...
[00:02:32]                 │ debg --- retry.try failed again with the same message...
[00:02:32]                 │ debg --- retry.try failed again with the same message...
[00:02:33]                 │ debg --- retry.try failed again with the same message...
[00:02:33]                 │ debg --- retry.try failed again with the same message...
[00:02:34]                 │ debg --- retry.try failed again with the same message...
[00:02:35]                 │ debg --- retry.try failed again with the same message...
[00:02:35]                 │ debg --- retry.try failed again with the same message...
[00:02:36]                 │ debg --- retry.try failed again with the same message...
[00:02:36]                 │ debg --- retry.try failed again with the same message...
[00:02:37]                 │ debg --- retry.try failed again with the same message...
[00:02:37]                 │ debg --- retry.try failed again with the same message...
[00:02:38]                 │ debg --- retry.try failed again with the same message...
[00:02:38]                 │ debg --- retry.try failed again with the same message...
[00:02:39]                 │ debg --- retry.try failed again with the same message...
[00:02:39]                 │ debg --- retry.try failed again with the same message...
[00:02:40]                 │ debg --- retry.try failed again with the same message...
[00:02:40]                 │ debg --- retry.try failed again with the same message...
[00:02:41]                 │ debg --- retry.try failed again with the same message...
[00:02:41]                 │ debg --- retry.try failed again with the same message...
[00:02:42]                 │ debg --- retry.try failed again with the same message...
[00:02:42]                 │ debg --- retry.try failed again with the same message...
[00:02:43]                 │ debg --- retry.try failed again with the same message...
[00:02:43]                 │ debg --- retry.try failed again with the same message...
[00:02:44]                 │ debg --- retry.try failed again with the same message...
[00:02:44]                 │ debg --- retry.try failed again with the same message...
[00:02:45]                 │ debg --- retry.try failed again with the same message...
[00:02:45]                 │ debg --- retry.try failed again with the same message...
[00:02:46]                 │ debg --- retry.try failed again with the same message...
[00:02:46]                 │ debg --- retry.try failed again with the same message...
[00:02:47]                 │ debg --- retry.try failed again with the same message...
[00:02:47]                 │ debg --- retry.try failed again with the same message...
[00:02:48]                 │ debg --- retry.try failed again with the same message...
[00:02:48]                 │ debg --- retry.try failed again with the same message...
[00:02:49]                 │ debg --- retry.try failed again with the same message...
[00:02:49]                 │ debg --- retry.try failed again with the same message...
[00:02:50]                 │ debg --- retry.try failed again with the same message...
[00:02:50]                 │ debg --- retry.try failed again with the same message...
[00:02:51]                 │ debg --- retry.try failed again with the same message...
[00:02:51]                 │ debg --- retry.try failed again with the same message...
[00:02:52]                 │ debg --- retry.try failed again with the same message...
[00:02:52]                 │ debg --- retry.try failed again with the same message...
[00:02:53]                 │ debg --- retry.try failed again with the same message...
[00:02:53]                 │ debg --- retry.try failed again with the same message...
[00:02:54]                 │ debg --- retry.try failed again with the same message...
[00:02:54]                 │ debg --- retry.try failed again with the same message...
[00:02:55]                 │ debg --- retry.try failed again with the same message...
[00:02:55]                 │ debg --- retry.try failed again with the same message...
[00:02:56]                 │ debg --- retry.try failed again with the same message...
[00:02:56]                 │ debg --- retry.try failed again with the same message...
[00:02:57]                 │ debg --- retry.try failed again with the same message...
[00:02:57]                 │ debg --- retry.try failed again with the same message...
[00:02:58]                 │ debg --- retry.try failed again with the same message...
[00:02:58]                 │ debg --- retry.try failed again with the same message...
[00:02:59]                 │ debg --- retry.try failed again with the same message...
[00:02:59]                 │ debg --- retry.try failed again with the same message...
[00:03:00]                 │ debg --- retry.try failed again with the same message...
[00:03:00]                 │ debg --- retry.try failed again with the same message...
[00:03:01]                 │ debg --- retry.try failed again with the same message...
[00:03:01]                 │ debg --- retry.try failed again with the same message...
[00:03:02]                 │ debg --- retry.try failed again with the same message...
[00:03:02]                 │ debg --- retry.try failed again with the same message...
[00:03:03]                 │ debg --- retry.try failed again with the same message...
[00:03:03]                 │ debg --- retry.try failed again with the same message...
[00:03:04]                 │ debg --- retry.try failed again with the same message...
[00:03:04]                 │ debg --- retry.try failed again with the same message...
[00:03:05]                 │ debg --- retry.try failed again with the same message...
[00:03:05]                 │ debg --- retry.try failed again with the same message...
[00:03:06]                 │ debg --- retry.try failed again with the same message...
[00:03:07]                 │ debg --- retry.try failed again with the same message...
[00:03:07]                 │ debg --- retry.try failed again with the same message...
[00:03:08]                 │ debg --- retry.try failed again with the same message...
[00:03:08]                 │ debg --- retry.try failed again with the same message...
[00:03:09]                 │ debg --- retry.try failed again with the same message...
[00:03:09]                 │ debg --- retry.try failed again with the same message...
[00:03:10]                 │ debg --- retry.try failed again with the same message...
[00:03:10]                 │ debg --- retry.try failed again with the same message...
[00:03:11]                 │ debg --- retry.try failed again with the same message...
[00:03:11]                 │ debg --- retry.try failed again with the same message...
[00:03:12]                 │ debg --- retry.try failed again with the same message...
[00:03:12]                 │ debg --- retry.try failed again with the same message...
[00:03:13]                 │ debg --- retry.try failed again with the same message...
[00:03:13]                 │ debg --- retry.try failed again with the same message...
[00:03:14]                 │ debg --- retry.try failed again with the same message...
[00:03:14]                 │ debg --- retry.try failed again with the same message...
[00:03:15]                 │ debg --- retry.try failed again with the same message...
[00:03:15]                 └- ✖ fail: alerting api integration spaces only Actions enqueue should never leaved a failed task, even if max attempts is reached
[00:03:15]                 │      retry.try timeout: Error: expected 0 to sort of equal 1
[00:03:15]                 │     at Assertion.assert (/dev/shm/workspace/parallel/4/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:03:15]                 │     at Assertion.eql (/dev/shm/workspace/parallel/4/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:03:15]                 │     at /dev/shm/workspace/parallel/4/kibana/x-pack/test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:182:91
[00:03:15]                 │     at runMicrotasks (<anonymous>)
[00:03:15]                 │     at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:03:15]                 │     at runAttempt (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry_for_success.ts:27:15)
[00:03:15]                 │     at retryForSuccess (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry_for_success.ts:66:21)
[00:03:15]                 │     at RetryService.try (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry.ts:31:12)
[00:03:15]                 │     at Context.<anonymous> (/dev/shm/workspace/parallel/4/kibana/x-pack/test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:160:7)
[00:03:15]                 │     at Object.apply (/dev/shm/workspace/parallel/4/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:03:15]                 │   Error: retry.try timeout: Error: expected 0 to sort of equal 1
[00:03:15]                 │       at Assertion.assert (/dev/shm/workspace/parallel/4/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:03:15]                 │       at Assertion.eql (/dev/shm/workspace/parallel/4/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:03:15]                 │       at /dev/shm/workspace/parallel/4/kibana/x-pack/test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:182:91
[00:03:15]                 │       at runMicrotasks (<anonymous>)
[00:03:15]                 │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:03:15]                 │       at runAttempt (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry_for_success.ts:27:15)
[00:03:15]                 │       at retryForSuccess (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry_for_success.ts:66:21)
[00:03:15]                 │       at RetryService.try (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry.ts:31:12)
[00:03:15]                 │       at Context.<anonymous> (test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:160:7)
[00:03:15]                 │       at Object.apply (/dev/shm/workspace/parallel/4/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:03:15]                 │       at onFailure (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry_for_success.ts:17:9)
[00:03:15]                 │       at retryForSuccess (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry_for_success.ts:57:13)
[00:03:15]                 │       at RetryService.try (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry.ts:31:12)
[00:03:15]                 │       at Context.<anonymous> (test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:160:7)
[00:03:15]                 │       at Object.apply (/dev/shm/workspace/parallel/4/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:03:15]                 │ 
[00:03:15]                 │ 

Stack Trace

Error: retry.try timeout: Error: expected 0 to sort of equal 1
    at Assertion.assert (/dev/shm/workspace/parallel/4/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/4/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at /dev/shm/workspace/parallel/4/kibana/x-pack/test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:182:91
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at runAttempt (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry_for_success.ts:27:15)
    at retryForSuccess (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry_for_success.ts:66:21)
    at RetryService.try (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry.ts:31:12)
    at Context.<anonymous> (test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:160:7)
    at Object.apply (/dev/shm/workspace/parallel/4/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
    at onFailure (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry_for_success.ts:57:13)
    at RetryService.try (/dev/shm/workspace/parallel/4/kibana/test/common/services/retry/retry.ts:31:12)
    at Context.<anonymous> (test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:160:7)
    at Object.apply (/dev/shm/workspace/parallel/4/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 209.5KB 209.5KB -2.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 27.2KB 27.2KB -4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit 5393b37 into elastic:7.x Sep 10, 2021
@alisonelizabeth alisonelizabeth deleted the ua/copy_updates branch September 10, 2021 20:22
sabarasaba added a commit that referenced this pull request Nov 9, 2021
* Fix link to Cloud deployment URL in upgrade step. (#109528)

* [Upgrade Assistant] Refactor CITs

* Rename UA steps to fix_issues_step and fix_logs_step. (#109526)

* Rename tests accordingly.

* [Upgrade Assistant] Cleanup scss (#109524)

* [Upgrade Assistant] Update readme (#109502)

* Add "Back up data" step to UA (#109543)

* Add backup step with static content and link to Snapshot and Restore.
* Add snapshot_restore locator.
* Remove unnecessary describe block from Upgrade Step tests.
* Remove unused render_app.tsx.

* Change copy references of 'deprecation issues' to 'deprecation warnings'. (#109963)

* [Upgrade Assistant] Address design feedback for ES deprecations page (#109726)

* [Upgrade Assistant] Add checkpoint feature to Overview page (#109449)

* Add on-Cloud state to Upgrade Assistant 'Back up data' step (#109956)

* [Upgrade Assistant] Refactor external links to use locators (#110435)

* [Upgrade Assistant] Use AppContext for services instead of KibanaContext (#109801)

* Remove kibana context dependency in favour of app context

* Add missing type to ContextValue

* Fix mock type

* Refactor app mount flow and types

* Refactor to use useServices hook

* Fix linter issues

* Keep mount_management_section and initialize breadcrumbs and api there

* Remove useServices and usePlugins in favour of just useAppContext

* Remove unnecessary mocks

* [Upgrade Assistant] Enable functional and a11y tests (#109909)

* [Upgrade Assistant] Remove version from UA nav title (#110739)

* [Upgrade Assistant] New Kibana deprecations page (#110101)

* Use injected lib.handleEsError instead of importing it in Upgrade Assistant API route handlers. (#111067)

* Add tests for UA back up data step on Cloud (#111066)

* Update UA to consume snapshotsUrl as provided by the Cloud plugin. (#111239)

* Skip flaky UA Backup step polling test.

* [Upgrade Assistant] Refactor kibana deprecation service mocks (#111168)

* [Upgrade Assistant] Remove unnecessary EuiScreenReaderOnly from stat panels (#111518)

* Remove EuiScreenReaderOnly implementations

* Remove unused translations

* Remove extra string after merge conflict

* Use consistent 'issues' and 'critical' vs. 'warning' terminology in UA. (#111221)

* Refactor UA Overview to support step-completion (#111243)

* Refactor UA Overview to store step-completion state at the root and delegate step-completion logic to each step component.
* Add completion status to logs and issues steps

* [Upgrade Assistant] External links with checkpoint time-range applied (#111252)

* Bound query around last checkpoint date

* Fix tests

* Also test discover url contains search params

* Small refactor

* Keep state about lastCheckpoint in parent component

* Remove space

* Address CR changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Tests for updating step state accordingly if API poll receives count followed by error (#111701)

* Add test for logs count polling

* Test when count api fails

* [Upgrade Assistant] Add a11y tests for es deprecation flyouts (#110843)

* [Upgrade Assistant] Set fix_logs step as incomplete if log collection is not enabled (#111827)

* set step as incomplete if toggle is disabled

* Fix test names

* Remove unnecessary mocks

* [Upgrade Assistant] Update copy to use "issues" instead of "warnings" (#111817)

* Create common deprecation issues panel component in UA (#111231)

* Refine success state behavior and add tests.
* Refactor components into a components directory.
* Refactor SCSS to colocate styles with their components.
* Refactor tests to reduce boilerplate and clarify conditions under test.

* [Upgrade Assistant] Fix Kibana deprecations warning message

* [Upgrade Assistant] Add support for API keys when reindexing (#111451)

* [Upgrade Assistant] Update readme (#112154)

* [Upgrade Assistant] Make infra plugin optional (#111960)

* Make infra plugin optional

* Fix CR requests

* [Upgrade Assistant] Improve flyout information architecture (#111713)

* Make sure longstrings inside flyout body are text-wrap

* Show resolved badge for reindex flyout and row

* Finish off rest of ES deprecation flyouts

* Refactor deprecation badge into its own component

* Add tests for kibana deprecations

* Add tests for es deprecations

* Also check that we have status=error before rendering error callout

* Check for non-complete states instead of just error

* Small refactor

* Default deprecation is not resolvable

* Add a bit more spacing between title and badge

* Address CR changes

* Use EuiSpacer instead of flexitems

* [Upgrade Assistant] Update readme (#112195)

* [Upgrade Assistant] Add integration tests for Overview page (#111370)

* Add a11y tests for when overview page has toggle enabled

* Add functional and accessibility tests for overview page

* Load test files

* Fix linter error

* Navigate before asserting

* Steps have now completion state

* Remove duped word

* Run setup only once, not per test

* Address CR changes

* No need to renavigate to the page

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Add note about compatibility headers (#110469)

* Improve error states for Upgrade Assistant deprecation issues (#112457)

* Simplify error state for deprecation issues panels. Remove <EsStatsError />.

* Rename components from stats -> panel.

* Create common error-reporting component for use in both Kibana and ES deprecations pages.
* Align order of loading, error, and success states between these pages.
* Change references to 'deprecations' -> 'deprecation issues'.

* Fix tests for panels.

* Add API integration test for handling auth error.

* Fix TS errors.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Change count poll time to 15s (#112669)

* [Upgrade Assistant] Add permissions check to logs step (#112420)

* [Upgrade Assistant] Refactor telemetry (#112177)

* [Upgrade Assistant] Check for ML upgrade mode before enabling flyout actions (#112555)

* Add missing error handlers for deprecation logging route (#113109)

* [Upgrade Assistant] Batch reindex docs (#112960)

* [UA] Added batch reindexing docs link to the ES deprecations page. Added a link from "batch reindexing" docs page to "start or resume reindex" docs page and from there to ES reindexing docs page. Also renamed "reindexing operation" to "reindexing task" for consistency.

* [Upgrade Assistant] Added docs build files

* Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* [Upgrade Assistant] Added review suggestions and fixed eslint issues

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Improve error messages for GET /api/upgrade_assistant/reindex/<index> (#112961)

* Add support for single manual steps to Upgrade Assistant. (#113344)

* Revert "[Upgrade Assistant] Refactor telemetry (#112177)" (#113665)

This reverts commit 991d24b.

* [Upgrade Assistant] Use skipFetchFields when creating the indexPattern in order to avoid errors if index doesn't exist (#113821)

* Use skipFetchFields when creating the indexPatter in order to avoid errors when index doesnt exist

* Address CR feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Hide system indices from es deprecations list (#113627)

* Refactor reindex routes into separate single and batch reindex files. Apply version precheck to batch routes. (#113822)

* [Upgrade Assistant] Remove ML/Watcher logic (#113224)

* Add show upgrade flag to url (#114243)

* [Upgrade Assistant] Delete deprecation log cache (#114113)

* [Upgrade Assistant] Add upgrade system indices section (#110593)

* [Upgrade Assistant] Reindexing progress (#114275)

* [Upgrade Assistant] Added reindexing progress in % to the reindex flyout and es deprecations table

* [Upgrade Assistant] Renamed first argument in `getReindexProgressLabel` to `reindexTaskPercComplete` for consistency

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Remove Fix manually heading when there are no manual steps

* Add rolling upgrade interstitials to UA (#112907)

* Refactor FixLogsStep to be explicit in which props are passed to DeprecationLoggingToggle.

* Centralize error-handling logic in the api service, instead of handling it within each individual API request. Covers:
- Cloud backup status
- ES deprecations
- Deprecation logging
- Remove index settings
- ML
- Reindexing

Also:
- Handle 426 error state and surface in UI.
- Move ResponseError type into common/types.

* Add note about intended use case of status API route.

* Add endpoint dedicated to surfacing the cluster upgrade state, and a client-side poll.

* Merge App and AppWithRouter components.

* [Upgrade Assistant] Added "accept changes" header to the warnings list in the reindex flyout (#114798)

* Refactor kibana deprecation tests (#114763)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix linter issues

* Remove unused translation

* Prefer master changes over 7.x for ml docs

* Prefer master changes over 7.x

* Skip tests

* Move everything to a single describe

* Fix types

* Add missing prop to mock

* [Upgrade Assistant] Removed "closed index" warning from reindex flyout (#114861)

* [Upgrade Assistant] Removed "closed index" warning that reindexing might take longer than usual, which is not the case

* [Upgrade Assistant] Also deleted i18n strings that are not needed anymore

* Add LevelIconTips to be more explicit about the difference between critical and warning issues. (#115121)

* Extract common DeprecationFlyoutLearnMoreLink component and change wording to 'Learn more'. (#115117)

* [Upgrade Assistant] Reindexing cancellation (#114636)

* [Upgrade Assistant] Updated the reindexing cancellation to look less like an error

* [Upgrade Assistant] Fixed an i18n issue and updated a jest snapshot

* [Upgrade Assistant] Updated cancelled reindexing state with a unified label and cross icon

* [Upgrade Assistant] Fixed snapshot test

* [Upgrade Assistant] Updated spacing to the reindex cancel button

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix test errors (#115183)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Overview page UI clean up (#115258)

- Scaling down deprecation issue panel title size to flow with typographic hierarchy.
- Removing panel around deprecation logging switch to reduce visual elements.
- Using success instead of green color for migration complete message.

* Revert "Revert "[Upgrade Assistant] Refactor telemetry (#112177)" (#113665)" (#114804)

This reverts commit c385d49.
* Add migration to remove obsolete attributes from telemetry saved object.
* Refactor UA telemetry constants by extracting it from common/types.

* [Upgrade Assistant] Rename upgrade_status to migration_status (#114755)

* [Upgrade Assistant] Swapped reindexing flyouts order (#115046)

* [Upgrade Assistant] Changed reindexing steps order, replaced a warning callout with a text element

* [Upgrade Assistant] Fixed reindex flyout test and changed warning callout from danger color to warning color

* [Upgrade Assistant] Fixed the correct status to show warnings

* [Upgrade Assistant] Fixed i18n strings

* [Upgrade Assistant] Moved reindex with warnings logic into a function

* [Upgrade Assistant] Updated reindex flyout copy

* [Upgrade Assistant] Also added a trailing period to the reindex step 3

* [Upgrade Assistant] Fixed i18n strings and step 3 wording

* [Upgrade Assistant] Added docs changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Hide features that don't need to be migrated from flyout (#115535)

* Filter out system indices that dont require migration on server side
* Rename to attrs to migration
* Update flyout snapshot.

* Refine Upgrade Assistant copy. (#115472)

* Remove unused file

* Fix kibanaVersion dep

* Updated config.ts to fix UA test

UA functional API integration test to check cloud backup status creates a snapshot repo, which fails to be created with my changes to config.ts `'path.repo=/tmp/repo,/tmp/repo_1,/tmp/repo_2,'`. Adding `/tmp/cloud-snapshots/'` to the config fixes the test.

* Address CR changes

* Add missing error handler for system indices migration (#116088)

* Fix broken tests

* Fix test

* Skip tests

* Fix linter errors and import

* [Upgrade Assistant] Fix typo in retrieval of cluster settings (#116335)

* Fix typos

* Fix typo also in server tests

* Make sure log collection remains enabled throughout the test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix type errors

* Fix integration test types

* Fix accessibility test type errors

* Fix linter errors in shared_imports

* Fix functional test types

Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Alison Goryachev <alison.goryachev@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Dmitry Borodyansky <dborodyansky@gmail.com>
spalger pushed a commit to spalger/kibana that referenced this pull request Nov 11, 2021
* Fix link to Cloud deployment URL in upgrade step. (elastic#109528)

* [Upgrade Assistant] Refactor CITs

* Rename UA steps to fix_issues_step and fix_logs_step. (elastic#109526)

* Rename tests accordingly.

* [Upgrade Assistant] Cleanup scss (elastic#109524)

* [Upgrade Assistant] Update readme (elastic#109502)

* Add "Back up data" step to UA (elastic#109543)

* Add backup step with static content and link to Snapshot and Restore.
* Add snapshot_restore locator.
* Remove unnecessary describe block from Upgrade Step tests.
* Remove unused render_app.tsx.

* Change copy references of 'deprecation issues' to 'deprecation warnings'. (elastic#109963)

* [Upgrade Assistant] Address design feedback for ES deprecations page (elastic#109726)

* [Upgrade Assistant] Add checkpoint feature to Overview page (elastic#109449)

* Add on-Cloud state to Upgrade Assistant 'Back up data' step (elastic#109956)

* [Upgrade Assistant] Refactor external links to use locators (elastic#110435)

* [Upgrade Assistant] Use AppContext for services instead of KibanaContext (elastic#109801)

* Remove kibana context dependency in favour of app context

* Add missing type to ContextValue

* Fix mock type

* Refactor app mount flow and types

* Refactor to use useServices hook

* Fix linter issues

* Keep mount_management_section and initialize breadcrumbs and api there

* Remove useServices and usePlugins in favour of just useAppContext

* Remove unnecessary mocks

* [Upgrade Assistant] Enable functional and a11y tests (elastic#109909)

* [Upgrade Assistant] Remove version from UA nav title (elastic#110739)

* [Upgrade Assistant] New Kibana deprecations page (elastic#110101)

* Use injected lib.handleEsError instead of importing it in Upgrade Assistant API route handlers. (elastic#111067)

* Add tests for UA back up data step on Cloud (elastic#111066)

* Update UA to consume snapshotsUrl as provided by the Cloud plugin. (elastic#111239)

* Skip flaky UA Backup step polling test.

* [Upgrade Assistant] Refactor kibana deprecation service mocks (elastic#111168)

* [Upgrade Assistant] Remove unnecessary EuiScreenReaderOnly from stat panels (elastic#111518)

* Remove EuiScreenReaderOnly implementations

* Remove unused translations

* Remove extra string after merge conflict

* Use consistent 'issues' and 'critical' vs. 'warning' terminology in UA. (elastic#111221)

* Refactor UA Overview to support step-completion (elastic#111243)

* Refactor UA Overview to store step-completion state at the root and delegate step-completion logic to each step component.
* Add completion status to logs and issues steps

* [Upgrade Assistant] External links with checkpoint time-range applied (elastic#111252)

* Bound query around last checkpoint date

* Fix tests

* Also test discover url contains search params

* Small refactor

* Keep state about lastCheckpoint in parent component

* Remove space

* Address CR changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Tests for updating step state accordingly if API poll receives count followed by error (elastic#111701)

* Add test for logs count polling

* Test when count api fails

* [Upgrade Assistant] Add a11y tests for es deprecation flyouts (elastic#110843)

* [Upgrade Assistant] Set fix_logs step as incomplete if log collection is not enabled (elastic#111827)

* set step as incomplete if toggle is disabled

* Fix test names

* Remove unnecessary mocks

* [Upgrade Assistant] Update copy to use "issues" instead of "warnings" (elastic#111817)

* Create common deprecation issues panel component in UA (elastic#111231)

* Refine success state behavior and add tests.
* Refactor components into a components directory.
* Refactor SCSS to colocate styles with their components.
* Refactor tests to reduce boilerplate and clarify conditions under test.

* [Upgrade Assistant] Fix Kibana deprecations warning message

* [Upgrade Assistant] Add support for API keys when reindexing (elastic#111451)

* [Upgrade Assistant] Update readme (elastic#112154)

* [Upgrade Assistant] Make infra plugin optional (elastic#111960)

* Make infra plugin optional

* Fix CR requests

* [Upgrade Assistant] Improve flyout information architecture (elastic#111713)

* Make sure longstrings inside flyout body are text-wrap

* Show resolved badge for reindex flyout and row

* Finish off rest of ES deprecation flyouts

* Refactor deprecation badge into its own component

* Add tests for kibana deprecations

* Add tests for es deprecations

* Also check that we have status=error before rendering error callout

* Check for non-complete states instead of just error

* Small refactor

* Default deprecation is not resolvable

* Add a bit more spacing between title and badge

* Address CR changes

* Use EuiSpacer instead of flexitems

* [Upgrade Assistant] Update readme (elastic#112195)

* [Upgrade Assistant] Add integration tests for Overview page (elastic#111370)

* Add a11y tests for when overview page has toggle enabled

* Add functional and accessibility tests for overview page

* Load test files

* Fix linter error

* Navigate before asserting

* Steps have now completion state

* Remove duped word

* Run setup only once, not per test

* Address CR changes

* No need to renavigate to the page

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Add note about compatibility headers (elastic#110469)

* Improve error states for Upgrade Assistant deprecation issues (elastic#112457)

* Simplify error state for deprecation issues panels. Remove <EsStatsError />.

* Rename components from stats -> panel.

* Create common error-reporting component for use in both Kibana and ES deprecations pages.
* Align order of loading, error, and success states between these pages.
* Change references to 'deprecations' -> 'deprecation issues'.

* Fix tests for panels.

* Add API integration test for handling auth error.

* Fix TS errors.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Change count poll time to 15s (elastic#112669)

* [Upgrade Assistant] Add permissions check to logs step (elastic#112420)

* [Upgrade Assistant] Refactor telemetry (elastic#112177)

* [Upgrade Assistant] Check for ML upgrade mode before enabling flyout actions (elastic#112555)

* Add missing error handlers for deprecation logging route (elastic#113109)

* [Upgrade Assistant] Batch reindex docs (elastic#112960)

* [UA] Added batch reindexing docs link to the ES deprecations page. Added a link from "batch reindexing" docs page to "start or resume reindex" docs page and from there to ES reindexing docs page. Also renamed "reindexing operation" to "reindexing task" for consistency.

* [Upgrade Assistant] Added docs build files

* Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* [Upgrade Assistant] Added review suggestions and fixed eslint issues

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Improve error messages for GET /api/upgrade_assistant/reindex/<index> (elastic#112961)

* Add support for single manual steps to Upgrade Assistant. (elastic#113344)

* Revert "[Upgrade Assistant] Refactor telemetry (elastic#112177)" (elastic#113665)

This reverts commit 991d24b.

* [Upgrade Assistant] Use skipFetchFields when creating the indexPattern in order to avoid errors if index doesn't exist (elastic#113821)

* Use skipFetchFields when creating the indexPatter in order to avoid errors when index doesnt exist

* Address CR feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Hide system indices from es deprecations list (elastic#113627)

* Refactor reindex routes into separate single and batch reindex files. Apply version precheck to batch routes. (elastic#113822)

* [Upgrade Assistant] Remove ML/Watcher logic (elastic#113224)

* Add show upgrade flag to url (elastic#114243)

* [Upgrade Assistant] Delete deprecation log cache (elastic#114113)

* [Upgrade Assistant] Add upgrade system indices section (elastic#110593)

* [Upgrade Assistant] Reindexing progress (elastic#114275)

* [Upgrade Assistant] Added reindexing progress in % to the reindex flyout and es deprecations table

* [Upgrade Assistant] Renamed first argument in `getReindexProgressLabel` to `reindexTaskPercComplete` for consistency

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Remove Fix manually heading when there are no manual steps

* Add rolling upgrade interstitials to UA (elastic#112907)

* Refactor FixLogsStep to be explicit in which props are passed to DeprecationLoggingToggle.

* Centralize error-handling logic in the api service, instead of handling it within each individual API request. Covers:
- Cloud backup status
- ES deprecations
- Deprecation logging
- Remove index settings
- ML
- Reindexing

Also:
- Handle 426 error state and surface in UI.
- Move ResponseError type into common/types.

* Add note about intended use case of status API route.

* Add endpoint dedicated to surfacing the cluster upgrade state, and a client-side poll.

* Merge App and AppWithRouter components.

* [Upgrade Assistant] Added "accept changes" header to the warnings list in the reindex flyout (elastic#114798)

* Refactor kibana deprecation tests (elastic#114763)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix linter issues

* Remove unused translation

* Prefer master changes over 7.x for ml docs

* Prefer master changes over 7.x

* Skip tests

* Move everything to a single describe

* Fix types

* Add missing prop to mock

* [Upgrade Assistant] Removed "closed index" warning from reindex flyout (elastic#114861)

* [Upgrade Assistant] Removed "closed index" warning that reindexing might take longer than usual, which is not the case

* [Upgrade Assistant] Also deleted i18n strings that are not needed anymore

* Add LevelIconTips to be more explicit about the difference between critical and warning issues. (elastic#115121)

* Extract common DeprecationFlyoutLearnMoreLink component and change wording to 'Learn more'. (elastic#115117)

* [Upgrade Assistant] Reindexing cancellation (elastic#114636)

* [Upgrade Assistant] Updated the reindexing cancellation to look less like an error

* [Upgrade Assistant] Fixed an i18n issue and updated a jest snapshot

* [Upgrade Assistant] Updated cancelled reindexing state with a unified label and cross icon

* [Upgrade Assistant] Fixed snapshot test

* [Upgrade Assistant] Updated spacing to the reindex cancel button

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix test errors (elastic#115183)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Overview page UI clean up (elastic#115258)

- Scaling down deprecation issue panel title size to flow with typographic hierarchy.
- Removing panel around deprecation logging switch to reduce visual elements.
- Using success instead of green color for migration complete message.

* Revert "Revert "[Upgrade Assistant] Refactor telemetry (elastic#112177)" (elastic#113665)" (elastic#114804)

This reverts commit c385d49.
* Add migration to remove obsolete attributes from telemetry saved object.
* Refactor UA telemetry constants by extracting it from common/types.

* [Upgrade Assistant] Rename upgrade_status to migration_status (elastic#114755)

* [Upgrade Assistant] Swapped reindexing flyouts order (elastic#115046)

* [Upgrade Assistant] Changed reindexing steps order, replaced a warning callout with a text element

* [Upgrade Assistant] Fixed reindex flyout test and changed warning callout from danger color to warning color

* [Upgrade Assistant] Fixed the correct status to show warnings

* [Upgrade Assistant] Fixed i18n strings

* [Upgrade Assistant] Moved reindex with warnings logic into a function

* [Upgrade Assistant] Updated reindex flyout copy

* [Upgrade Assistant] Also added a trailing period to the reindex step 3

* [Upgrade Assistant] Fixed i18n strings and step 3 wording

* [Upgrade Assistant] Added docs changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Hide features that don't need to be migrated from flyout (elastic#115535)

* Filter out system indices that dont require migration on server side
* Rename to attrs to migration
* Update flyout snapshot.

* Refine Upgrade Assistant copy. (elastic#115472)

* Remove unused file

* Fix kibanaVersion dep

* Updated config.ts to fix UA test

UA functional API integration test to check cloud backup status creates a snapshot repo, which fails to be created with my changes to config.ts `'path.repo=/tmp/repo,/tmp/repo_1,/tmp/repo_2,'`. Adding `/tmp/cloud-snapshots/'` to the config fixes the test.

* Address CR changes

* Add missing error handler for system indices migration (elastic#116088)

* Fix broken tests

* Fix test

* Skip tests

* Fix linter errors and import

* [Upgrade Assistant] Fix typo in retrieval of cluster settings (elastic#116335)

* Fix typos

* Fix typo also in server tests

* Make sure log collection remains enabled throughout the test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix type errors

* Fix integration test types

* Fix accessibility test type errors

* Fix linter errors in shared_imports

* Fix functional test types

Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Alison Goryachev <alison.goryachev@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Dmitry Borodyansky <dborodyansky@gmail.com>
spalger pushed a commit that referenced this pull request Nov 11, 2021
* [Upgrade Assistant] Forwardport from 7.x (#114966)

* Fix link to Cloud deployment URL in upgrade step. (#109528)

* [Upgrade Assistant] Refactor CITs

* Rename UA steps to fix_issues_step and fix_logs_step. (#109526)

* Rename tests accordingly.

* [Upgrade Assistant] Cleanup scss (#109524)

* [Upgrade Assistant] Update readme (#109502)

* Add "Back up data" step to UA (#109543)

* Add backup step with static content and link to Snapshot and Restore.
* Add snapshot_restore locator.
* Remove unnecessary describe block from Upgrade Step tests.
* Remove unused render_app.tsx.

* Change copy references of 'deprecation issues' to 'deprecation warnings'. (#109963)

* [Upgrade Assistant] Address design feedback for ES deprecations page (#109726)

* [Upgrade Assistant] Add checkpoint feature to Overview page (#109449)

* Add on-Cloud state to Upgrade Assistant 'Back up data' step (#109956)

* [Upgrade Assistant] Refactor external links to use locators (#110435)

* [Upgrade Assistant] Use AppContext for services instead of KibanaContext (#109801)

* Remove kibana context dependency in favour of app context

* Add missing type to ContextValue

* Fix mock type

* Refactor app mount flow and types

* Refactor to use useServices hook

* Fix linter issues

* Keep mount_management_section and initialize breadcrumbs and api there

* Remove useServices and usePlugins in favour of just useAppContext

* Remove unnecessary mocks

* [Upgrade Assistant] Enable functional and a11y tests (#109909)

* [Upgrade Assistant] Remove version from UA nav title (#110739)

* [Upgrade Assistant] New Kibana deprecations page (#110101)

* Use injected lib.handleEsError instead of importing it in Upgrade Assistant API route handlers. (#111067)

* Add tests for UA back up data step on Cloud (#111066)

* Update UA to consume snapshotsUrl as provided by the Cloud plugin. (#111239)

* Skip flaky UA Backup step polling test.

* [Upgrade Assistant] Refactor kibana deprecation service mocks (#111168)

* [Upgrade Assistant] Remove unnecessary EuiScreenReaderOnly from stat panels (#111518)

* Remove EuiScreenReaderOnly implementations

* Remove unused translations

* Remove extra string after merge conflict

* Use consistent 'issues' and 'critical' vs. 'warning' terminology in UA. (#111221)

* Refactor UA Overview to support step-completion (#111243)

* Refactor UA Overview to store step-completion state at the root and delegate step-completion logic to each step component.
* Add completion status to logs and issues steps

* [Upgrade Assistant] External links with checkpoint time-range applied (#111252)

* Bound query around last checkpoint date

* Fix tests

* Also test discover url contains search params

* Small refactor

* Keep state about lastCheckpoint in parent component

* Remove space

* Address CR changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Tests for updating step state accordingly if API poll receives count followed by error (#111701)

* Add test for logs count polling

* Test when count api fails

* [Upgrade Assistant] Add a11y tests for es deprecation flyouts (#110843)

* [Upgrade Assistant] Set fix_logs step as incomplete if log collection is not enabled (#111827)

* set step as incomplete if toggle is disabled

* Fix test names

* Remove unnecessary mocks

* [Upgrade Assistant] Update copy to use "issues" instead of "warnings" (#111817)

* Create common deprecation issues panel component in UA (#111231)

* Refine success state behavior and add tests.
* Refactor components into a components directory.
* Refactor SCSS to colocate styles with their components.
* Refactor tests to reduce boilerplate and clarify conditions under test.

* [Upgrade Assistant] Fix Kibana deprecations warning message

* [Upgrade Assistant] Add support for API keys when reindexing (#111451)

* [Upgrade Assistant] Update readme (#112154)

* [Upgrade Assistant] Make infra plugin optional (#111960)

* Make infra plugin optional

* Fix CR requests

* [Upgrade Assistant] Improve flyout information architecture (#111713)

* Make sure longstrings inside flyout body are text-wrap

* Show resolved badge for reindex flyout and row

* Finish off rest of ES deprecation flyouts

* Refactor deprecation badge into its own component

* Add tests for kibana deprecations

* Add tests for es deprecations

* Also check that we have status=error before rendering error callout

* Check for non-complete states instead of just error

* Small refactor

* Default deprecation is not resolvable

* Add a bit more spacing between title and badge

* Address CR changes

* Use EuiSpacer instead of flexitems

* [Upgrade Assistant] Update readme (#112195)

* [Upgrade Assistant] Add integration tests for Overview page (#111370)

* Add a11y tests for when overview page has toggle enabled

* Add functional and accessibility tests for overview page

* Load test files

* Fix linter error

* Navigate before asserting

* Steps have now completion state

* Remove duped word

* Run setup only once, not per test

* Address CR changes

* No need to renavigate to the page

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Add note about compatibility headers (#110469)

* Improve error states for Upgrade Assistant deprecation issues (#112457)

* Simplify error state for deprecation issues panels. Remove <EsStatsError />.

* Rename components from stats -> panel.

* Create common error-reporting component for use in both Kibana and ES deprecations pages.
* Align order of loading, error, and success states between these pages.
* Change references to 'deprecations' -> 'deprecation issues'.

* Fix tests for panels.

* Add API integration test for handling auth error.

* Fix TS errors.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Change count poll time to 15s (#112669)

* [Upgrade Assistant] Add permissions check to logs step (#112420)

* [Upgrade Assistant] Refactor telemetry (#112177)

* [Upgrade Assistant] Check for ML upgrade mode before enabling flyout actions (#112555)

* Add missing error handlers for deprecation logging route (#113109)

* [Upgrade Assistant] Batch reindex docs (#112960)

* [UA] Added batch reindexing docs link to the ES deprecations page. Added a link from "batch reindexing" docs page to "start or resume reindex" docs page and from there to ES reindexing docs page. Also renamed "reindexing operation" to "reindexing task" for consistency.

* [Upgrade Assistant] Added docs build files

* Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* [Upgrade Assistant] Added review suggestions and fixed eslint issues

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Improve error messages for GET /api/upgrade_assistant/reindex/<index> (#112961)

* Add support for single manual steps to Upgrade Assistant. (#113344)

* Revert "[Upgrade Assistant] Refactor telemetry (#112177)" (#113665)

This reverts commit 991d24b.

* [Upgrade Assistant] Use skipFetchFields when creating the indexPattern in order to avoid errors if index doesn't exist (#113821)

* Use skipFetchFields when creating the indexPatter in order to avoid errors when index doesnt exist

* Address CR feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Hide system indices from es deprecations list (#113627)

* Refactor reindex routes into separate single and batch reindex files. Apply version precheck to batch routes. (#113822)

* [Upgrade Assistant] Remove ML/Watcher logic (#113224)

* Add show upgrade flag to url (#114243)

* [Upgrade Assistant] Delete deprecation log cache (#114113)

* [Upgrade Assistant] Add upgrade system indices section (#110593)

* [Upgrade Assistant] Reindexing progress (#114275)

* [Upgrade Assistant] Added reindexing progress in % to the reindex flyout and es deprecations table

* [Upgrade Assistant] Renamed first argument in `getReindexProgressLabel` to `reindexTaskPercComplete` for consistency

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Remove Fix manually heading when there are no manual steps

* Add rolling upgrade interstitials to UA (#112907)

* Refactor FixLogsStep to be explicit in which props are passed to DeprecationLoggingToggle.

* Centralize error-handling logic in the api service, instead of handling it within each individual API request. Covers:
- Cloud backup status
- ES deprecations
- Deprecation logging
- Remove index settings
- ML
- Reindexing

Also:
- Handle 426 error state and surface in UI.
- Move ResponseError type into common/types.

* Add note about intended use case of status API route.

* Add endpoint dedicated to surfacing the cluster upgrade state, and a client-side poll.

* Merge App and AppWithRouter components.

* [Upgrade Assistant] Added "accept changes" header to the warnings list in the reindex flyout (#114798)

* Refactor kibana deprecation tests (#114763)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix linter issues

* Remove unused translation

* Prefer master changes over 7.x for ml docs

* Prefer master changes over 7.x

* Skip tests

* Move everything to a single describe

* Fix types

* Add missing prop to mock

* [Upgrade Assistant] Removed "closed index" warning from reindex flyout (#114861)

* [Upgrade Assistant] Removed "closed index" warning that reindexing might take longer than usual, which is not the case

* [Upgrade Assistant] Also deleted i18n strings that are not needed anymore

* Add LevelIconTips to be more explicit about the difference between critical and warning issues. (#115121)

* Extract common DeprecationFlyoutLearnMoreLink component and change wording to 'Learn more'. (#115117)

* [Upgrade Assistant] Reindexing cancellation (#114636)

* [Upgrade Assistant] Updated the reindexing cancellation to look less like an error

* [Upgrade Assistant] Fixed an i18n issue and updated a jest snapshot

* [Upgrade Assistant] Updated cancelled reindexing state with a unified label and cross icon

* [Upgrade Assistant] Fixed snapshot test

* [Upgrade Assistant] Updated spacing to the reindex cancel button

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix test errors (#115183)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Overview page UI clean up (#115258)

- Scaling down deprecation issue panel title size to flow with typographic hierarchy.
- Removing panel around deprecation logging switch to reduce visual elements.
- Using success instead of green color for migration complete message.

* Revert "Revert "[Upgrade Assistant] Refactor telemetry (#112177)" (#113665)" (#114804)

This reverts commit c385d49.
* Add migration to remove obsolete attributes from telemetry saved object.
* Refactor UA telemetry constants by extracting it from common/types.

* [Upgrade Assistant] Rename upgrade_status to migration_status (#114755)

* [Upgrade Assistant] Swapped reindexing flyouts order (#115046)

* [Upgrade Assistant] Changed reindexing steps order, replaced a warning callout with a text element

* [Upgrade Assistant] Fixed reindex flyout test and changed warning callout from danger color to warning color

* [Upgrade Assistant] Fixed the correct status to show warnings

* [Upgrade Assistant] Fixed i18n strings

* [Upgrade Assistant] Moved reindex with warnings logic into a function

* [Upgrade Assistant] Updated reindex flyout copy

* [Upgrade Assistant] Also added a trailing period to the reindex step 3

* [Upgrade Assistant] Fixed i18n strings and step 3 wording

* [Upgrade Assistant] Added docs changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Hide features that don't need to be migrated from flyout (#115535)

* Filter out system indices that dont require migration on server side
* Rename to attrs to migration
* Update flyout snapshot.

* Refine Upgrade Assistant copy. (#115472)

* Remove unused file

* Fix kibanaVersion dep

* Updated config.ts to fix UA test

UA functional API integration test to check cloud backup status creates a snapshot repo, which fails to be created with my changes to config.ts `'path.repo=/tmp/repo,/tmp/repo_1,/tmp/repo_2,'`. Adding `/tmp/cloud-snapshots/'` to the config fixes the test.

* Address CR changes

* Add missing error handler for system indices migration (#116088)

* Fix broken tests

* Fix test

* Skip tests

* Fix linter errors and import

* [Upgrade Assistant] Fix typo in retrieval of cluster settings (#116335)

* Fix typos

* Fix typo also in server tests

* Make sure log collection remains enabled throughout the test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix type errors

* Fix integration test types

* Fix accessibility test type errors

* Fix linter errors in shared_imports

* Fix functional test types

Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Alison Goryachev <alison.goryachev@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Dmitry Borodyansky <dborodyansky@gmail.com>

* commit with @elastic.co email

Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Alison Goryachev <alison.goryachev@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Dmitry Borodyansky <dborodyansky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants