Skip to content

[Upgrade Assistant] Refactor external links to use locators#110435

Merged
sabarasaba merged 3 commits intoelastic:7.xfrom
sabarasaba:ua/use_locator_geturl
Aug 30, 2021
Merged

[Upgrade Assistant] Refactor external links to use locators#110435
sabarasaba merged 3 commits intoelastic:7.xfrom
sabarasaba:ua/use_locator_geturl

Conversation

@sabarasaba
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba commented Aug 30, 2021

This PR refactors usage of getUrlForApp in favour of app locator for discovery.

Fixes: #109537

@sabarasaba sabarasaba added chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant v7.16.0 labels Aug 30, 2021
@sabarasaba sabarasaba self-assigned this Aug 30, 2021
@sabarasaba sabarasaba marked this pull request as ready for review August 30, 2021 12:11
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 30, 2021

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@sabarasaba sabarasaba requested a review from cjcenizal August 30, 2021 12:11
@sabarasaba
Copy link
Copy Markdown
Member Author

sabarasaba commented Aug 30, 2021

@elasticmachine merge upstream

sabarasaba
sabarasaba commented Aug 30, 2021
View reviewed changes
...ns/upgrade_assistant/public/application/components/overview/fix_logs_step/external_links.tsx
return;
}

const url = await locator.getUrl({ indexPatternId });
Copy link
Copy Markdown
Member Author

@sabarasaba sabarasaba Aug 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useUrl didnt seem to work, so I left it as getUrl for now

cjcenizal
cjcenizal approved these changes Aug 30, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Didn't test locally.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 30, 2021

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/anomaly_detection/custom_urls·ts.machine learning anomaly detection custom urls adds a custom URL to Dashboard in the edit job flyout

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 4 times on tracked branches: https://github.com/elastic/kibana/issues/106053

[00:00:00]       │
[00:00:00]         └-: machine learning
[00:00:00]           └-> "before all" hook in "machine learning"
[00:00:00]           └-: 
[00:00:00]             └-> "before all" hook in ""
[00:00:00]             └-> "before all" hook in ""
[00:00:00]               │ debg creating role ft_ml_source
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_source]
[00:00:00]               │ debg creating role ft_ml_source_readonly
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_source_readonly]
[00:00:00]               │ debg creating role ft_ml_dest
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_dest]
[00:00:00]               │ debg creating role ft_ml_dest_readonly
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_dest_readonly]
[00:00:00]               │ debg creating role ft_ml_ui_extras
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_ui_extras]
[00:00:00]               │ debg creating role ft_default_space_ml_all
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_all]
[00:00:00]               │ debg creating role ft_default_space1_ml_all
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space1_ml_all]
[00:00:00]               │ debg creating role ft_all_spaces_ml_all
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_all_spaces_ml_all]
[00:00:00]               │ debg creating role ft_default_space_ml_read
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_read]
[00:00:00]               │ debg creating role ft_default_space1_ml_read
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space1_ml_read]
[00:00:00]               │ debg creating role ft_all_spaces_ml_read
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_all_spaces_ml_read]
[00:00:00]               │ debg creating role ft_default_space_ml_none
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_none]
[00:00:00]               │ debg creating user ft_ml_poweruser
[00:00:00]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser]
[00:00:00]               │ debg created user ft_ml_poweruser
[00:00:00]               │ debg creating user ft_ml_poweruser_spaces
[00:00:00]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_spaces]
[00:00:00]               │ debg created user ft_ml_poweruser_spaces
[00:00:00]               │ debg creating user ft_ml_poweruser_space1
[00:00:00]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_space1]
[00:00:00]               │ debg created user ft_ml_poweruser_space1
[00:00:00]               │ debg creating user ft_ml_poweruser_all_spaces
[00:00:00]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_all_spaces]
[00:00:00]               │ debg created user ft_ml_poweruser_all_spaces
[00:00:00]               │ debg creating user ft_ml_viewer
[00:00:01]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer]
[00:00:01]               │ debg created user ft_ml_viewer
[00:00:01]               │ debg creating user ft_ml_viewer_spaces
[00:00:01]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_spaces]
[00:00:01]               │ debg created user ft_ml_viewer_spaces
[00:00:01]               │ debg creating user ft_ml_viewer_space1
[00:00:01]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_space1]
[00:00:01]               │ debg created user ft_ml_viewer_space1
[00:00:01]               │ debg creating user ft_ml_viewer_all_spaces
[00:00:01]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_all_spaces]
[00:00:01]               │ debg created user ft_ml_viewer_all_spaces
[00:00:01]               │ debg creating user ft_ml_unauthorized
[00:00:01]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_unauthorized]
[00:00:01]               │ debg created user ft_ml_unauthorized
[00:00:01]               │ debg creating user ft_ml_unauthorized_spaces
[00:00:01]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_unauthorized_spaces]
[00:00:01]               │ debg created user ft_ml_unauthorized_spaces
[00:08:08]             └-: anomaly detection
[00:08:08]               └-> "before all" hook in "anomaly detection"
[00:39:25]               └-: custom urls
[00:39:25]                 └-> "before all" hook for "opens the custom URLs tab in the edit job flyout"
[00:39:25]                 └-> "before all" hook for "opens the custom URLs tab in the edit job flyout"
[00:39:25]                   │ info [x-pack/test/functional/es_archives/ml/farequote] Loading "mappings.json"
[00:39:25]                   │ info [x-pack/test/functional/es_archives/ml/farequote] Loading "data.json.gz"
[00:39:25]                   │ info [x-pack/test/functional/es_archives/ml/farequote] Skipped restore for existing index "ft_farequote"
[00:39:26]                   │ERROR browser[SEVERE] http://localhost:6171/api/ml/annotations - Failed to load resource: the server responded with a status of 400 (Bad Request)
[00:39:26]                   │ debg Searching for 'index-pattern' with title 'ft_farequote'...
[00:39:26]                   │ debg  > Found '807de5e0-099e-11ec-a3c3-63d2b346fec0'
[00:39:26]                   │ debg Index pattern with title 'ft_farequote' already exists. Nothing to create.
[00:39:26]                   │ debg Searching for 'dashboard' with title 'ML Test'...
[00:39:26]                   │ debg  > Not found
[00:39:26]                   │ debg Creating dashboard with title 'ML Test'
[00:39:26]                   │ debg  > Created with id 'df297c80-09a3-11ec-a3c3-63d2b346fec0'
[00:39:26]                   │ debg applying update to kibana config: {"dateFormat:tz":"UTC"}
[00:39:27]                   │ debg Creating anomaly detection job with id 'fq_multi_1_custom_urls' ...
[00:39:27]                   │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.ml-anomalies-shared] creating index, cause [api], templates [.ml-anomalies-], shards [1]/[1]
[00:39:27]                   │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.ml-anomalies-shared]
[00:39:27]                   │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.ml-annotations-6] creating index, cause [api], templates [], shards [1]/[1]
[00:39:27]                   │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.ml-annotations-6]
[00:39:28]                   │ info [o.e.c.m.MetadataMappingService] [node-01] [.ml-anomalies-shared/A73w5JFVQAaJ4e-hyKc_SQ] update_mapping [_doc]
[00:39:28]                   │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.ml-config] creating index, cause [auto(bulk api)], templates [], shards [1]/[1]
[00:39:28]                   │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.ml-config]
[00:39:28]                   │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.ml-notifications-000002] creating index, cause [auto(bulk api)], templates [.ml-notifications-000002], shards [1]/[1]
[00:39:28]                   │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.ml-notifications-000002]
[00:39:28]                   │ debg Waiting up to 5000ms for 'fq_multi_1_custom_urls' to exist...
[00:39:28]                   │ debg > AD job created.
[00:39:28]                   │ debg Creating datafeed with id 'datafeed-fq_multi_1_custom_urls' ...
[00:39:29]                   │ debg Waiting up to 5000ms for 'datafeed-fq_multi_1_custom_urls' to exist...
[00:39:29]                   │ debg > Datafeed created.
[00:39:29]                   │ debg Opening anomaly detection job 'fq_multi_1_custom_urls'...
[00:39:29]                   │ info [o.e.x.m.j.p.a.AutodetectProcessManager] [node-01] Opening job [fq_multi_1_custom_urls]
[00:39:29]                   │ info [o.e.x.c.m.u.MlIndexAndAlias] [node-01] About to create first concrete index [.ml-state-000001] with alias [.ml-state-write]
[00:39:29]                   │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.ml-state-000001] creating index, cause [api], templates [.ml-state], shards [1]/[1]
[00:39:29]                   │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.ml-state-000001]
[00:39:29]                   │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.ml-state-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [ml-size-based-ilm-policy]
[00:39:29]                   │ info [o.e.x.m.j.p.a.AutodetectProcessManager] [node-01] [fq_multi_1_custom_urls] Loading model snapshot [N/A], job latest_record_timestamp [N/A]
[00:39:30]                   │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.ml-state-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [ml-size-based-ilm-policy]
[00:39:30]                   │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.ml-state-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [ml-size-based-ilm-policy]
[00:39:30]                   │ info [o.e.x.m.p.l.CppLogMessageHandler] [node-01] [fq_multi_1_custom_urls] [autodetect/190180] [CResourceMonitor.cc@82] Setting model memory limit to 20 MB
[00:39:30]                   │ debg > AD job opened.
[00:39:30]                   │ debg Starting datafeed 'datafeed-fq_multi_1_custom_urls' with start: '0', end: '1630336000625'...
[00:39:30]                   │ info [o.e.x.m.d.DatafeedJob] [node-01] [fq_multi_1_custom_urls] Datafeed started (from: 1970-01-01T00:00:00.000Z to: 2021-08-30T15:06:40.625Z) with frequency [600000ms]
[00:39:30]                   │ debg > Datafeed started.
[00:39:30]                   │ debg Waiting up to 120000ms for datafeed state to be stopped...
[00:39:30]                   │ debg Fetching datafeed state for datafeed datafeed-fq_multi_1_custom_urls
[00:39:30]                   │ debg --- retry.waitForWithTimeout error: expected job state to be stopped but got started
[00:39:30]                   │ info [o.e.c.m.MetadataMappingService] [node-01] [.ml-anomalies-shared/A73w5JFVQAaJ4e-hyKc_SQ] update_mapping [_doc]
[00:39:30]                   │ info [o.e.x.m.j.p.DataCountsReporter] [node-01] [fq_multi_1_custom_urls] 10000 records written to autodetect; missingFieldCount=0, invalidDateCount=0, outOfOrderCount=0
[00:39:31]                   │ debg Fetching datafeed state for datafeed datafeed-fq_multi_1_custom_urls
[00:39:31]                   │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:39:31]                   │ info [o.e.x.m.j.p.DataCountsReporter] [node-01] [fq_multi_1_custom_urls] 20000 records written to autodetect; missingFieldCount=0, invalidDateCount=0, outOfOrderCount=0
[00:39:31]                   │ debg Fetching datafeed state for datafeed datafeed-fq_multi_1_custom_urls
[00:39:31]                   │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:39:31]                   │ info [o.e.x.m.j.p.DataCountsReporter] [node-01] [fq_multi_1_custom_urls] 30000 records written to autodetect; missingFieldCount=0, invalidDateCount=0, outOfOrderCount=0
[00:39:32]                   │ debg Fetching datafeed state for datafeed datafeed-fq_multi_1_custom_urls
[00:39:32]                   │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:39:32]                   │ info [o.e.x.m.j.p.DataCountsReporter] [node-01] [fq_multi_1_custom_urls] 40000 records written to autodetect; missingFieldCount=0, invalidDateCount=0, outOfOrderCount=0
[00:39:32]                   │ debg Fetching datafeed state for datafeed datafeed-fq_multi_1_custom_urls
[00:39:32]                   │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:39:32]                   │ info [o.e.x.m.j.p.DataCountsReporter] [node-01] [fq_multi_1_custom_urls] 50000 records written to autodetect; missingFieldCount=0, invalidDateCount=0, outOfOrderCount=0
[00:39:33]                   │ debg Fetching datafeed state for datafeed datafeed-fq_multi_1_custom_urls
[00:39:33]                   │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:39:33]                   │ info [o.e.x.m.j.p.DataCountsReporter] [node-01] [fq_multi_1_custom_urls] 60000 records written to autodetect; missingFieldCount=0, invalidDateCount=0, outOfOrderCount=0
[00:39:33]                   │ debg Fetching datafeed state for datafeed datafeed-fq_multi_1_custom_urls
[00:39:33]                   │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:39:33]                   │ info [o.e.x.m.j.p.DataCountsReporter] [node-01] [fq_multi_1_custom_urls] 70000 records written to autodetect; missingFieldCount=0, invalidDateCount=0, outOfOrderCount=0
[00:39:34]                   │ debg Fetching datafeed state for datafeed datafeed-fq_multi_1_custom_urls
[00:39:34]                   │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:39:34]                   │ info [o.e.x.m.j.p.DataCountsReporter] [node-01] [fq_multi_1_custom_urls] 80000 records written to autodetect; missingFieldCount=0, invalidDateCount=0, outOfOrderCount=0
[00:39:34]                   │ debg Fetching datafeed state for datafeed datafeed-fq_multi_1_custom_urls
[00:39:34]                   │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:39:35]                   │ debg Fetching datafeed state for datafeed datafeed-fq_multi_1_custom_urls
[00:39:35]                   │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:39:35]                   │ debg Fetching datafeed state for datafeed datafeed-fq_multi_1_custom_urls
[00:39:35]                   │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:39:36]                   │ info [o.e.x.m.d.DatafeedJob] [node-01] [fq_multi_1_custom_urls] Lookback has finished
[00:39:36]                   │ info [o.e.x.m.d.DatafeedRunner] [node-01] [no_realtime] attempt to stop datafeed [datafeed-fq_multi_1_custom_urls] for job [fq_multi_1_custom_urls]
[00:39:36]                   │ info [o.e.x.m.d.DatafeedRunner] [node-01] [no_realtime] try lock [20s] to stop datafeed [datafeed-fq_multi_1_custom_urls] for job [fq_multi_1_custom_urls]...
[00:39:36]                   │ info [o.e.x.m.d.DatafeedRunner] [node-01] [no_realtime] stopping datafeed [datafeed-fq_multi_1_custom_urls] for job [fq_multi_1_custom_urls], acquired [true]...
[00:39:36]                   │ info [o.e.x.m.d.DatafeedRunner] [node-01] [no_realtime] datafeed [datafeed-fq_multi_1_custom_urls] for job [fq_multi_1_custom_urls] has been stopped
[00:39:36]                   │ info [o.e.x.m.j.p.a.AutodetectProcessManager] [node-01] Closing job [fq_multi_1_custom_urls], because [close job (api)]
[00:39:36]                   │ info [o.e.x.m.p.l.CppLogMessageHandler] [node-01] [fq_multi_1_custom_urls] [autodetect/190180] [CCmdSkeleton.cc@66] Handled 86274 records
[00:39:36]                   │ info [o.e.x.m.p.l.CppLogMessageHandler] [node-01] [fq_multi_1_custom_urls] [autodetect/190180] [CAnomalyJob.cc@1601] Pruning obsolete models
[00:39:36]                   │ debg Fetching datafeed state for datafeed datafeed-fq_multi_1_custom_urls
[00:39:36]                   │ debg Waiting up to 120000ms for job state to be closed...
[00:39:36]                   │ debg Fetching anomaly detection job stats for job fq_multi_1_custom_urls...
[00:39:36]                   │ debg > AD job stats fetched.
[00:39:36]                   │ debg --- retry.waitForWithTimeout error: expected job state to be closed but got closing
[00:39:36]                   │ info [o.e.c.m.MetadataMappingService] [node-01] [.ml-anomalies-shared/A73w5JFVQAaJ4e-hyKc_SQ] update_mapping [_doc]
[00:39:36]                   │ info [o.e.x.m.p.AbstractNativeProcess] [node-01] [fq_multi_1_custom_urls] State output finished
[00:39:36]                   │ info [o.e.x.m.j.p.a.o.AutodetectResultProcessor] [node-01] [fq_multi_1_custom_urls] 240 buckets parsed from autodetect output
[00:39:36]                   │ debg Fetching anomaly detection job stats for job fq_multi_1_custom_urls...
[00:39:36]                   │ debg > AD job stats fetched.
[00:39:36]                   │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:39:37]                   │ debg Fetching anomaly detection job stats for job fq_multi_1_custom_urls...
[00:39:37]                   │ debg > AD job stats fetched.
[00:39:37]                   │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:39:37]                   │ info [o.e.x.m.j.p.a.AutodetectCommunicator] [node-01] [fq_multi_1_custom_urls] autodetect connection for job closed
[00:39:37]                   │ debg Fetching anomaly detection job stats for job fq_multi_1_custom_urls...
[00:39:37]                   │ debg > AD job stats fetched.
[00:39:37]                   │ debg SecurityPage.forceLogout
[00:39:37]                   │ debg Find.existsByDisplayedByCssSelector('.login-form') with timeout=100
[00:39:37]                   │ debg --- retry.tryForTime error: .login-form is not displayed
[00:39:38]                   │ debg Redirecting to /logout to force the logout
[00:39:38]                   │ debg Waiting on the login form to appear
[00:39:38]                   │ debg Waiting for Login Page to appear.
[00:39:38]                   │ debg Waiting up to 100000ms for login page...
[00:39:38]                   │ debg browser[INFO] http://localhost:6171/logout?_t=1630336008537 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:39:38]                   │
[00:39:38]                   │ debg browser[INFO] http://localhost:6171/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:39:38]                   │ debg Find.existsByDisplayedByCssSelector('.login-form') with timeout=2500
[00:39:41]                   │ERROR browser[SEVERE] http://localhost:6171/api/alerts/list_alert_types - Failed to load resource: the server responded with a status of 401 (Unauthorized)
[00:39:41]                   │ debg browser[INFO] http://localhost:6171/43951/bundles/core/core.entry.js 12:152119 "Detected an unhandled Promise rejection.
[00:39:41]                   │      Error: Unauthorized"
[00:39:41]                   │ERROR browser[SEVERE] http://localhost:6171/43951/bundles/core/core.entry.js 5:2752 
[00:39:41]                   │ debg browser[INFO] http://localhost:6171/login?msg=LOGGED_OUT 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:39:41]                   │
[00:39:41]                   │ debg browser[INFO] http://localhost:6171/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:39:41]                   │ debg --- retry.tryForTime error: .login-form is not displayed
[00:39:41]                   │ERROR browser[SEVERE] http://localhost:6171/api/licensing/info - Failed to load resource: the server responded with a status of 401 (Unauthorized)
[00:39:42]                   │ debg Find.existsByDisplayedByCssSelector('.login-form') with timeout=2500
[00:39:42]                   │ debg TestSubjects.exists(loginForm)
[00:39:42]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="loginForm"]') with timeout=2500
[00:39:42]                   │ debg Waiting for Login Form to appear.
[00:39:42]                   │ debg Waiting up to 100000ms for login form...
[00:39:42]                   │ debg TestSubjects.exists(loginForm)
[00:39:42]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="loginForm"]') with timeout=2500
[00:39:42]                   │ debg TestSubjects.setValue(loginUsername, ft_ml_poweruser)
[00:39:42]                   │ debg TestSubjects.click(loginUsername)
[00:39:42]                   │ debg Find.clickByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:39:42]                   │ debg Find.findByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:39:42]                   │ debg TestSubjects.setValue(loginPassword, mlp001)
[00:39:42]                   │ debg TestSubjects.click(loginPassword)
[00:39:42]                   │ debg Find.clickByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:39:42]                   │ debg Find.findByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:39:42]                   │ debg TestSubjects.click(loginSubmit)
[00:39:42]                   │ debg Find.clickByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:39:42]                   │ debg Find.findByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:39:43]                   │ debg Waiting for login result, expected: chrome.
[00:39:43]                   │ debg Find.findByCssSelector('[data-test-subj="userMenuAvatar"]') with timeout=20000
[00:39:43]                   │ proc [kibana]   log   [15:06:53.199] [info][plugins][routes][security] Logging in with provider "basic" (basic)
[00:39:45]                   │ debg browser[INFO] http://localhost:6171/app/home 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:39:45]                   │
[00:39:45]                   │ debg browser[INFO] http://localhost:6171/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:39:45]                   │ debg Finished login process currentUrl = http://localhost:6171/app/home#/
[00:39:45]                   │ debg Waiting up to 20000ms for logout button visible...
[00:39:45]                   │ debg TestSubjects.exists(userMenuButton)
[00:39:45]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenuButton"]') with timeout=2500
[00:39:45]                   │ debg TestSubjects.exists(userMenu)
[00:39:45]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"]') with timeout=2500
[00:39:48]                   │ debg --- retry.tryForTime error: [data-test-subj="userMenu"] is not displayed
[00:39:48]                   │ debg TestSubjects.click(userMenuButton)
[00:39:48]                   │ debg Find.clickByCssSelector('[data-test-subj="userMenuButton"]') with timeout=10000
[00:39:48]                   │ debg Find.findByCssSelector('[data-test-subj="userMenuButton"]') with timeout=10000
[00:39:48]                   │ debg TestSubjects.exists(userMenu)
[00:39:48]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"]') with timeout=120000
[00:39:49]                   │ debg TestSubjects.exists(userMenu > logoutLink)
[00:39:49]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"] [data-test-subj="logoutLink"]') with timeout=2500
[00:39:49]                 └-> opens the custom URLs tab in the edit job flyout
[00:39:49]                   └-> "before each" hook: global before each for "opens the custom URLs tab in the edit job flyout"
[00:39:49]                   │ debg === TEST STEP === load the job management page
[00:39:49]                   │ debg navigating to ml url: http://localhost:6171/app/ml
[00:39:49]                   │ debg navigate to: http://localhost:6171/app/ml
[00:39:49]                   │ debg browser[INFO] http://localhost:6171/app/ml?_t=1630336019232 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:39:49]                   │
[00:39:49]                   │ debg browser[INFO] http://localhost:6171/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:39:49]                   │ debg ... sleep(700) start
[00:39:49]                   │ debg ... sleep(700) end
[00:39:49]                   │ debg returned from get, calling refresh
[00:39:50]                   │ debg browser[INFO] http://localhost:6171/app/ml?_t=1630336019232 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:39:50]                   │
[00:39:50]                   │ debg browser[INFO] http://localhost:6171/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:39:51]                   │ debg currentUrl = http://localhost:6171/app/ml
[00:39:51]                   │          appUrl = http://localhost:6171/app/ml
[00:39:51]                   │ debg TestSubjects.find(kibanaChrome)
[00:39:51]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:39:51]                   │ debg ... sleep(501) start
[00:39:51]                   │ debg ... sleep(501) end
[00:39:51]                   │ debg in navigateTo url = http://localhost:6171/app/ml/overview
[00:39:51]                   │ debg --- retry.tryForTime error: URL changed, waiting for it to settle
[00:39:52]                   │ debg ... sleep(501) start
[00:39:52]                   │ debg ... sleep(501) end
[00:39:52]                   │ debg in navigateTo url = http://localhost:6171/app/ml/overview
[00:39:52]                   │ debg TestSubjects.exists(mlApp)
[00:39:52]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlApp"]') with timeout=2000
[00:39:52]                   │ debg TestSubjects.click(~mlMainTab & ~anomalyDetection)
[00:39:52]                   │ debg Find.clickByCssSelector('[data-test-subj~="mlMainTab"][data-test-subj~="anomalyDetection"]') with timeout=10000
[00:39:52]                   │ debg Find.findByCssSelector('[data-test-subj~="mlMainTab"][data-test-subj~="anomalyDetection"]') with timeout=10000
[00:39:52]                   │ debg TestSubjects.exists(~mlMainTab & ~anomalyDetection & ~selected)
[00:39:52]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="mlMainTab"][data-test-subj~="anomalyDetection"][data-test-subj~="selected"]') with timeout=120000
[00:39:53]                   │ debg TestSubjects.exists(mlPageJobManagement)
[00:39:53]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlPageJobManagement"]') with timeout=120000
[00:39:53]                   │ debg === TEST STEP === open the custom URLs tab in the edit job flyout
[00:39:53]                   │ debg TestSubjects.exists(mlActionButtonDeleteJob)
[00:39:53]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlActionButtonDeleteJob"]') with timeout=2500
[00:39:55]                   │ debg --- retry.tryForTime error: [data-test-subj="mlActionButtonDeleteJob"] is not displayed
[00:39:56]                   │ debg TestSubjects.click(~mlJobListTable > ~row-fq_multi_1_custom_urls > euiCollapsedItemActionsButton)
[00:39:56]                   │ debg Find.clickByCssSelector('[data-test-subj~="mlJobListTable"] [data-test-subj~="row-fq_multi_1_custom_urls"] [data-test-subj="euiCollapsedItemActionsButton"]') with timeout=10000
[00:39:56]                   │ debg Find.findByCssSelector('[data-test-subj~="mlJobListTable"] [data-test-subj~="row-fq_multi_1_custom_urls"] [data-test-subj="euiCollapsedItemActionsButton"]') with timeout=10000
[00:39:56]                   │ debg TestSubjects.exists(mlActionButtonDeleteJob)
[00:39:56]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlActionButtonDeleteJob"]') with timeout=5000
[00:39:56]                   │ debg TestSubjects.click(mlActionButtonEditJob)
[00:39:56]                   │ debg Find.clickByCssSelector('[data-test-subj="mlActionButtonEditJob"]') with timeout=10000
[00:39:56]                   │ debg Find.findByCssSelector('[data-test-subj="mlActionButtonEditJob"]') with timeout=10000
[00:39:56]                   │ debg TestSubjects.exists(mlJobEditFlyout)
[00:39:56]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlJobEditFlyout"]') with timeout=120000
[00:39:56]                   │ debg TestSubjects.click(mlEditJobFlyout-customUrls)
[00:39:56]                   │ debg Find.clickByCssSelector('[data-test-subj="mlEditJobFlyout-customUrls"]') with timeout=10000
[00:39:56]                   │ debg Find.findByCssSelector('[data-test-subj="mlEditJobFlyout-customUrls"]') with timeout=10000
[00:39:57]                   │ debg TestSubjects.exists(mlJobOpenCustomUrlFormButton)
[00:39:57]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlJobOpenCustomUrlFormButton"]') with timeout=5000
[00:39:57]                   │ debg TestSubjects.exists(mlEditJobFlyoutCloseButton)
[00:39:57]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlEditJobFlyoutCloseButton"]') with timeout=2500
[00:39:57]                   │ debg TestSubjects.click(mlEditJobFlyoutCloseButton)
[00:39:57]                   │ debg Find.clickByCssSelector('[data-test-subj="mlEditJobFlyoutCloseButton"]') with timeout=10000
[00:39:57]                   │ debg Find.findByCssSelector('[data-test-subj="mlEditJobFlyoutCloseButton"]') with timeout=10000
[00:39:57]                   │ debg TestSubjects.missingOrFail(mlJobEditFlyout)
[00:39:57]                   │ debg Find.waitForDeletedByCssSelector('[data-test-subj="mlJobEditFlyout"]') with timeout=2500
[00:39:57]                   └- ✓ pass  (8.7s) "machine learning  anomaly detection custom urls opens the custom URLs tab in the edit job flyout"
[00:39:57]                 └-> adds a custom URL with query entities to Discover in the edit job flyout
[00:39:57]                   └-> "before each" hook: global before each for "adds a custom URL with query entities to Discover in the edit job flyout"
[00:39:57]                   │ debg TestSubjects.exists(mlActionButtonDeleteJob)
[00:39:57]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlActionButtonDeleteJob"]') with timeout=2500
[00:40:00]                   │ debg --- retry.tryForTime error: [data-test-subj="mlActionButtonDeleteJob"] is not displayed
[00:40:00]                   │ debg TestSubjects.click(~mlJobListTable > ~row-fq_multi_1_custom_urls > euiCollapsedItemActionsButton)
[00:40:00]                   │ debg Find.clickByCssSelector('[data-test-subj~="mlJobListTable"] [data-test-subj~="row-fq_multi_1_custom_urls"] [data-test-subj="euiCollapsedItemActionsButton"]') with timeout=10000
[00:40:00]                   │ debg Find.findByCssSelector('[data-test-subj~="mlJobListTable"] [data-test-subj~="row-fq_multi_1_custom_urls"] [data-test-subj="euiCollapsedItemActionsButton"]') with timeout=10000
[00:40:00]                   │ debg TestSubjects.exists(mlActionButtonDeleteJob)
[00:40:00]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlActionButtonDeleteJob"]') with timeout=5000
[00:40:00]                   │ debg TestSubjects.click(mlActionButtonEditJob)
[00:40:00]                   │ debg Find.clickByCssSelector('[data-test-subj="mlActionButtonEditJob"]') with timeout=10000
[00:40:00]                   │ debg Find.findByCssSelector('[data-test-subj="mlActionButtonEditJob"]') with timeout=10000
[00:40:00]                   │ debg TestSubjects.exists(mlJobEditFlyout)
[00:40:00]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlJobEditFlyout"]') with timeout=120000
[00:40:01]                   │ debg TestSubjects.click(mlEditJobFlyout-customUrls)
[00:40:01]                   │ debg Find.clickByCssSelector('[data-test-subj="mlEditJobFlyout-customUrls"]') with timeout=10000
[00:40:01]                   │ debg Find.findByCssSelector('[data-test-subj="mlEditJobFlyout-customUrls"]') with timeout=10000
[00:40:01]                   │ debg TestSubjects.exists(mlJobOpenCustomUrlFormButton)
[00:40:01]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlJobOpenCustomUrlFormButton"]') with timeout=5000
[00:40:01]                   │ debg TestSubjects.findAll(mlJobEditCustomUrlItemLabel)
[00:40:01]                   │ debg Find.allByCssSelector('[data-test-subj="mlJobEditCustomUrlItemLabel"]') with timeout=10000
[00:40:11]                   │ debg TestSubjects.exists(mlJobOpenCustomUrlFormButton)
[00:40:11]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlJobOpenCustomUrlFormButton"]') with timeout=5000
[00:40:11]                   │ debg TestSubjects.click(mlJobOpenCustomUrlFormButton)
[00:40:11]                   │ debg Find.clickByCssSelector('[data-test-subj="mlJobOpenCustomUrlFormButton"]') with timeout=10000
[00:40:11]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobOpenCustomUrlFormButton"]') with timeout=10000
[00:40:11]                   │ debg TestSubjects.exists(mlJobCustomUrlForm)
[00:40:11]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlJobCustomUrlForm"]') with timeout=120000
[00:40:11]                   │ debg TestSubjects.setValue(mlJobCustomUrlLabelInput, Show data)
[00:40:11]                   │ debg TestSubjects.click(mlJobCustomUrlLabelInput)
[00:40:11]                   │ debg Find.clickByCssSelector('[data-test-subj="mlJobCustomUrlLabelInput"]') with timeout=10000
[00:40:11]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlLabelInput"]') with timeout=10000
[00:40:11]                   │ debg TestSubjects.getAttribute(mlJobCustomUrlLabelInput, value, tryTimeout=120000, findTimeout=10000)
[00:40:11]                   │ debg TestSubjects.find(mlJobCustomUrlLabelInput)
[00:40:11]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlLabelInput"]') with timeout=10000
[00:40:11]                   │ debg TestSubjects.find(mlJobCustomUrlLinkToTypeInput)
[00:40:11]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlLinkToTypeInput"]') with timeout=10000
[00:40:12]                   │ debg TestSubjects.find(mlJobCustomUrlLinkToTypeInput)
[00:40:12]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlLinkToTypeInput"]') with timeout=10000
[00:40:12]                   │ debg TestSubjects.find(mlJobCustomUrlDiscoverIndexPatternInput)
[00:40:12]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlDiscoverIndexPatternInput"]') with timeout=10000
[00:40:12]                   │ debg TestSubjects.find(mlJobCustomUrlDiscoverIndexPatternInput)
[00:40:12]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlDiscoverIndexPatternInput"]') with timeout=10000
[00:40:12]                   │ debg comboBox.set, comboBoxSelector: mlJobCustomUrlQueryEntitiesInput > comboBoxInput
[00:40:12]                   │ debg TestSubjects.find(mlJobCustomUrlQueryEntitiesInput > comboBoxInput)
[00:40:12]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlQueryEntitiesInput"] [data-test-subj="comboBoxInput"]') with timeout=10000
[00:40:12]                   │ debg comboBox.setElement, value: airline
[00:40:12]                   │ debg comboBox.isOptionSelected, value: airline
[00:40:14]                   │ debg TestSubjects.exists(~comboBoxOptionsList)
[00:40:14]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=2500
[00:40:14]                   │ debg Find.allByCssSelector('.euiFilterSelectItem[title^="airline"]') with timeout=2500
[00:40:14]                   │ debg TestSubjects.exists(~comboBoxOptionsList)
[00:40:14]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=2500
[00:40:14]                   │ debg comboBox.getComboBoxSelectedOptions, comboBoxSelector: mlJobCustomUrlQueryEntitiesInput > comboBoxInput
[00:40:14]                   │ debg TestSubjects.find(mlJobCustomUrlQueryEntitiesInput > comboBoxInput)
[00:40:14]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlQueryEntitiesInput"] [data-test-subj="comboBoxInput"]') with timeout=10000
[00:40:14]                   │ debg TestSubjects.find(mlJobCustomUrlTimeRangeInput)
[00:40:14]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlTimeRangeInput"]') with timeout=10000
[00:40:14]                   │ debg TestSubjects.find(mlJobCustomUrlTimeRangeInput)
[00:40:14]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlTimeRangeInput"]') with timeout=10000
[00:40:14]                   │ debg TestSubjects.click(mlJobAddCustomUrl)
[00:40:14]                   │ debg Find.clickByCssSelector('[data-test-subj="mlJobAddCustomUrl"]') with timeout=10000
[00:40:14]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobAddCustomUrl"]') with timeout=10000
[00:40:15]                   │ debg TestSubjects.exists(mlJobEditCustomUrlLabelInput_0)
[00:40:15]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlJobEditCustomUrlLabelInput_0"]') with timeout=120000
[00:40:15]                   │ debg TestSubjects.getAttribute(mlJobEditCustomUrlLabelInput_0, value, tryTimeout=120000, findTimeout=10000)
[00:40:15]                   │ debg TestSubjects.find(mlJobEditCustomUrlLabelInput_0)
[00:40:15]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobEditCustomUrlLabelInput_0"]') with timeout=10000
[00:40:15]                   │ debg TestSubjects.click(mlEditJobFlyoutSaveButton)
[00:40:15]                   │ debg Find.clickByCssSelector('[data-test-subj="mlEditJobFlyoutSaveButton"]') with timeout=10000
[00:40:15]                   │ debg Find.findByCssSelector('[data-test-subj="mlEditJobFlyoutSaveButton"]') with timeout=10000
[00:40:15]                   │ debg TestSubjects.missingOrFail(mlJobEditFlyout)
[00:40:15]                   │ debg Find.waitForDeletedByCssSelector('[data-test-subj="mlJobEditFlyout"]') with timeout=5000
[00:40:16]                   └- ✓ pass  (18.3s) "machine learning  anomaly detection custom urls adds a custom URL with query entities to Discover in the edit job flyout"
[00:40:16]                 └-> adds a custom URL to Dashboard in the edit job flyout
[00:40:16]                   └-> "before each" hook: global before each for "adds a custom URL to Dashboard in the edit job flyout"
[00:40:16]                   │ debg TestSubjects.exists(mlActionButtonDeleteJob)
[00:40:16]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlActionButtonDeleteJob"]') with timeout=2500
[00:40:18]                   │ debg --- retry.tryForTime error: [data-test-subj="mlActionButtonDeleteJob"] is not displayed
[00:40:19]                   │ debg TestSubjects.click(~mlJobListTable > ~row-fq_multi_1_custom_urls > euiCollapsedItemActionsButton)
[00:40:19]                   │ debg Find.clickByCssSelector('[data-test-subj~="mlJobListTable"] [data-test-subj~="row-fq_multi_1_custom_urls"] [data-test-subj="euiCollapsedItemActionsButton"]') with timeout=10000
[00:40:19]                   │ debg Find.findByCssSelector('[data-test-subj~="mlJobListTable"] [data-test-subj~="row-fq_multi_1_custom_urls"] [data-test-subj="euiCollapsedItemActionsButton"]') with timeout=10000
[00:40:19]                   │ debg TestSubjects.exists(mlActionButtonDeleteJob)
[00:40:19]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlActionButtonDeleteJob"]') with timeout=5000
[00:40:19]                   │ debg TestSubjects.click(mlActionButtonEditJob)
[00:40:19]                   │ debg Find.clickByCssSelector('[data-test-subj="mlActionButtonEditJob"]') with timeout=10000
[00:40:19]                   │ debg Find.findByCssSelector('[data-test-subj="mlActionButtonEditJob"]') with timeout=10000
[00:40:19]                   │ debg TestSubjects.exists(mlJobEditFlyout)
[00:40:19]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlJobEditFlyout"]') with timeout=120000
[00:40:19]                   │ debg TestSubjects.click(mlEditJobFlyout-customUrls)
[00:40:19]                   │ debg Find.clickByCssSelector('[data-test-subj="mlEditJobFlyout-customUrls"]') with timeout=10000
[00:40:19]                   │ debg Find.findByCssSelector('[data-test-subj="mlEditJobFlyout-customUrls"]') with timeout=10000
[00:40:19]                   │ debg TestSubjects.exists(mlJobOpenCustomUrlFormButton)
[00:40:19]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlJobOpenCustomUrlFormButton"]') with timeout=5000
[00:40:19]                   │ debg TestSubjects.findAll(mlJobEditCustomUrlItemLabel)
[00:40:19]                   │ debg Find.allByCssSelector('[data-test-subj="mlJobEditCustomUrlItemLabel"]') with timeout=10000
[00:40:19]                   │ debg TestSubjects.exists(mlJobOpenCustomUrlFormButton)
[00:40:19]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlJobOpenCustomUrlFormButton"]') with timeout=5000
[00:40:19]                   │ debg TestSubjects.click(mlJobOpenCustomUrlFormButton)
[00:40:19]                   │ debg Find.clickByCssSelector('[data-test-subj="mlJobOpenCustomUrlFormButton"]') with timeout=10000
[00:40:19]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobOpenCustomUrlFormButton"]') with timeout=10000
[00:40:19]                   │ debg TestSubjects.exists(mlJobCustomUrlForm)
[00:40:19]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlJobCustomUrlForm"]') with timeout=120000
[00:40:19]                   │ debg TestSubjects.setValue(mlJobCustomUrlLabelInput, Show dashboard)
[00:40:19]                   │ debg TestSubjects.click(mlJobCustomUrlLabelInput)
[00:40:19]                   │ debg Find.clickByCssSelector('[data-test-subj="mlJobCustomUrlLabelInput"]') with timeout=10000
[00:40:19]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlLabelInput"]') with timeout=10000
[00:40:20]                   │ debg TestSubjects.getAttribute(mlJobCustomUrlLabelInput, value, tryTimeout=120000, findTimeout=10000)
[00:40:20]                   │ debg TestSubjects.find(mlJobCustomUrlLabelInput)
[00:40:20]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlLabelInput"]') with timeout=10000
[00:40:20]                   │ debg TestSubjects.find(mlJobCustomUrlLinkToTypeInput)
[00:40:20]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlLinkToTypeInput"]') with timeout=10000
[00:40:20]                   │ debg TestSubjects.find(mlJobCustomUrlLinkToTypeInput)
[00:40:20]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlLinkToTypeInput"]') with timeout=10000
[00:40:20]                   │ debg TestSubjects.find(mlJobCustomUrlDashboardNameInput)
[00:40:20]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlDashboardNameInput"]') with timeout=10000
[00:40:20]                   │ debg TestSubjects.find(mlJobCustomUrlDashboardNameInput)
[00:40:20]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlDashboardNameInput"]') with timeout=10000
[00:40:20]                   │ debg comboBox.getComboBoxSelectedOptions, comboBoxSelector: mlJobCustomUrlQueryEntitiesInput > comboBoxInput
[00:40:20]                   │ debg TestSubjects.find(mlJobCustomUrlQueryEntitiesInput > comboBoxInput)
[00:40:20]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlQueryEntitiesInput"] [data-test-subj="comboBoxInput"]') with timeout=10000
[00:40:20]                   │ debg TestSubjects.find(mlJobCustomUrlTimeRangeInput)
[00:40:20]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlTimeRangeInput"]') with timeout=10000
[00:40:20]                   │ debg TestSubjects.find(mlJobCustomUrlTimeRangeInput)
[00:40:20]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlTimeRangeInput"]') with timeout=10000
[00:40:20]                   │ debg TestSubjects.setValue(mlJobCustomUrlTimeRangeIntervalInput, 1h)
[00:40:20]                   │ debg TestSubjects.click(mlJobCustomUrlTimeRangeIntervalInput)
[00:40:20]                   │ debg Find.clickByCssSelector('[data-test-subj="mlJobCustomUrlTimeRangeIntervalInput"]') with timeout=10000
[00:40:20]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlTimeRangeIntervalInput"]') with timeout=10000
[00:40:20]                   │ debg TestSubjects.getAttribute(mlJobCustomUrlTimeRangeIntervalInput, value, tryTimeout=120000, findTimeout=10000)
[00:40:20]                   │ debg TestSubjects.find(mlJobCustomUrlTimeRangeIntervalInput)
[00:40:20]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobCustomUrlTimeRangeIntervalInput"]') with timeout=10000
[00:40:20]                   │ debg TestSubjects.click(mlJobAddCustomUrl)
[00:40:20]                   │ debg Find.clickByCssSelector('[data-test-subj="mlJobAddCustomUrl"]') with timeout=10000
[00:40:20]                   │ debg Find.findByCssSelector('[data-test-subj="mlJobAddCustomUrl"]') with timeout=10000
[00:40:20]                   │ debg TestSubjects.exists(mlJobEditCustomUrlLabelInput_1)
[00:40:20]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlJobEditCustomUrlLabelInput_1"]') with timeout=120000
[00:40:23]                   │ERROR browser[SEVERE] http://localhost:6171/43951/bundles/plugin/ml/8.0.0/ml.chunk.6.js 16:1377360 "Error building custom URL from settings:" Error: requires type and id
[00:40:23]                   │          at saved_objects_client_SavedObjectsClient.get (http://localhost:6171/43951/bundles/core/core.entry.js:13:74422)
[00:40:23]                   │          at http://localhost:6171/43951/bundles/plugin/ml/8.0.0/ml.chunk.6.js:17:1357370
[00:40:23]                   │          at new Promise (<anonymous>)
[00:40:23]                   │          at http://localhost:6171/43951/bundles/plugin/ml/8.0.0/ml.chunk.6.js:17:1357223
[00:40:23]                   │          at buildCustomUrlFromSettings (http://localhost:6171/43951/bundles/plugin/ml/8.0.0/ml.chunk.6.js:17:1358373)
[00:40:23]                   │          at http://localhost:6171/43951/bundles/plugin/ml/8.0.0/ml.chunk.6.js:17:1377144
[00:40:23]                   │          at Object.g (http://localhost:6171/43951/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:390:1036)
[00:40:23]                   │          at T (http://localhost:6171/43951/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:390:1179)
[00:40:23]                   │          at http://localhost:6171/43951/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:390:1325
[00:40:23]                   │          at k (http://localhost:6171/43951/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:390:1411)
[00:40:23]                   │ debg --- retry.tryForTime error: [data-test-subj="mlJobEditCustomUrlLabelInput_1"] is not displayed
[00:40:26]                   │ debg --- retry.tryForTime failed again with the same message...
[00:40:29]                   │ debg --- retry.tryForTime failed again with the same message...
[00:40:32]                   │ debg --- retry.tryForTime failed again with the same message...
[00:40:35]                   │ debg --- retry.tryForTime failed again with the same message...
[00:40:38]                   │ debg --- retry.tryForTime failed again with the same message...
[00:40:41]                   │ debg --- retry.tryForTime failed again with the same message...
[00:40:44]                   │ debg --- retry.tryForTime failed again with the same message...
[00:40:47]                   │ debg --- retry.tryForTime failed again with the same message...
[00:40:50]                   │ debg --- retry.tryForTime failed again with the same message...
[00:40:53]                   │ debg --- retry.tryForTime failed again with the same message...
[00:40:56]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:00]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:03]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:06]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:09]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:12]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:15]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:18]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:21]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:24]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:27]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:30]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:33]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:36]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:39]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:42]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:45]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:48]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:51]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:54]                   │ debg --- retry.tryForTime failed again with the same message...
[00:41:57]                   │ debg --- retry.tryForTime failed again with the same message...
[00:42:00]                   │ debg --- retry.tryForTime failed again with the same message...
[00:42:03]                   │ debg --- retry.tryForTime failed again with the same message...
[00:42:06]                   │ debg --- retry.tryForTime failed again with the same message...
[00:42:09]                   │ debg --- retry.tryForTime failed again with the same message...
[00:42:12]                   │ debg --- retry.tryForTime failed again with the same message...
[00:42:16]                   │ debg --- retry.tryForTime failed again with the same message...
[00:42:19]                   │ debg --- retry.tryForTime failed again with the same message...
[00:42:22]                   │ debg --- retry.tryForTime failed again with the same message...
[00:42:22]                   │ info Taking screenshot "/dev/shm/workspace/parallel/7/kibana/x-pack/test/functional/screenshots/failure/machine learning  anomaly detection custom urls adds a custom URL to Dashboard in the edit job flyout.png"
[00:42:22]                   │ info Current URL is: http://localhost:6171/app/ml/jobs?_g=(refreshInterval%3A(pause%3A!f%2Cvalue%3A30000))&_a=(jobs%3A(pageIndex%3A0%2CpageSize%3A10%2CqueryText%3A''%2CsortDirection%3Aasc%2CsortField%3Aid))
[00:42:22]                   │ info Saving page source to: /dev/shm/workspace/parallel/7/kibana/x-pack/test/functional/failure_debug/html/machine learning  anomaly detection custom urls adds a custom URL to Dashboard in the edit job flyout.html
[00:42:22]                   └- ✖ fail: machine learning  anomaly detection custom urls adds a custom URL to Dashboard in the edit job flyout
[00:42:22]                   │      Error: expected testSubject(mlJobEditCustomUrlLabelInput_1) to exist
[00:42:22]                   │       at TestSubjects.existOrFail (/dev/shm/workspace/parallel/7/kibana/test/functional/services/common/test_subjects.ts:45:13)
[00:42:22]                   │       at Object.assertCustomUrlLabel (test/functional/services/ml/custom_urls.ts:106:7)
[00:42:22]                   │       at MlJobTable.addDashboardCustomUrl (test/functional/services/ml/job_table.ts:633:7)
[00:42:22]                   │       at Context.<anonymous> (test/functional/apps/ml/anomaly_detection/custom_urls.ts:116:7)
[00:42:22]                   │       at Object.apply (/dev/shm/workspace/parallel/7/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:42:22]                   │ 
[00:42:22]                   │

Stack Trace

Error: expected testSubject(mlJobEditCustomUrlLabelInput_1) to exist
    at TestSubjects.existOrFail (/dev/shm/workspace/parallel/7/kibana/test/functional/services/common/test_subjects.ts:45:13)
    at Object.assertCustomUrlLabel (test/functional/services/ml/custom_urls.ts:106:7)
    at MlJobTable.addDashboardCustomUrl (test/functional/services/ml/job_table.ts:633:7)
    at Context.<anonymous> (test/functional/apps/ml/anomaly_detection/custom_urls.ts:116:7)
    at Object.apply (/dev/shm/workspace/parallel/7/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 211.6KB 211.4KB -254.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 19.1KB 19.0KB -36.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba sabarasaba merged commit efdc7d5 into elastic:7.x Aug 30, 2021
@cjcenizal cjcenizal mentioned this pull request Aug 30, 2021
Closed
sabarasaba added a commit to sabarasaba/kibana that referenced this pull request Oct 20, 2021
@sabarasaba
[Upgrade Assistant] Refactor external links to use locators (elastic#…
57e2b55 
…110435)
sabarasaba added a commit to sabarasaba/kibana that referenced this pull request Oct 26, 2021
@sabarasaba
[Upgrade Assistant] Refactor external links to use locators (elastic#…
a47436d 
…110435)
sabarasaba added a commit to sabarasaba/kibana that referenced this pull request Oct 26, 2021
@sabarasaba
[Upgrade Assistant] Refactor external links to use locators (elastic#…
870b262 
…110435)
sabarasaba added a commit that referenced this pull request Nov 9, 2021
@sabarasaba @cjcenizal
@alisonelizabeth @kibanamachine @yuliacech @jrodewig @dborodyansky
[Upgrade Assistant] Forwardport from 7.x (#114966)
8819bd8 
* Fix link to Cloud deployment URL in upgrade step. (#109528)

* [Upgrade Assistant] Refactor CITs

* Rename UA steps to fix_issues_step and fix_logs_step. (#109526)

* Rename tests accordingly.

* [Upgrade Assistant] Cleanup scss (#109524)

* [Upgrade Assistant] Update readme (#109502)

* Add "Back up data" step to UA (#109543)

* Add backup step with static content and link to Snapshot and Restore.
* Add snapshot_restore locator.
* Remove unnecessary describe block from Upgrade Step tests.
* Remove unused render_app.tsx.

* Change copy references of 'deprecation issues' to 'deprecation warnings'. (#109963)

* [Upgrade Assistant] Address design feedback for ES deprecations page (#109726)

* [Upgrade Assistant] Add checkpoint feature to Overview page (#109449)

* Add on-Cloud state to Upgrade Assistant 'Back up data' step (#109956)

* [Upgrade Assistant] Refactor external links to use locators (#110435)

* [Upgrade Assistant] Use AppContext for services instead of KibanaContext (#109801)

* Remove kibana context dependency in favour of app context

* Add missing type to ContextValue

* Fix mock type

* Refactor app mount flow and types

* Refactor to use useServices hook

* Fix linter issues

* Keep mount_management_section and initialize breadcrumbs and api there

* Remove useServices and usePlugins in favour of just useAppContext

* Remove unnecessary mocks

* [Upgrade Assistant] Enable functional and a11y tests (#109909)

* [Upgrade Assistant] Remove version from UA nav title (#110739)

* [Upgrade Assistant] New Kibana deprecations page (#110101)

* Use injected lib.handleEsError instead of importing it in Upgrade Assistant API route handlers. (#111067)

* Add tests for UA back up data step on Cloud (#111066)

* Update UA to consume snapshotsUrl as provided by the Cloud plugin. (#111239)

* Skip flaky UA Backup step polling test.

* [Upgrade Assistant] Refactor kibana deprecation service mocks (#111168)

* [Upgrade Assistant] Remove unnecessary EuiScreenReaderOnly from stat panels (#111518)

* Remove EuiScreenReaderOnly implementations

* Remove unused translations

* Remove extra string after merge conflict

* Use consistent 'issues' and 'critical' vs. 'warning' terminology in UA. (#111221)

* Refactor UA Overview to support step-completion (#111243)

* Refactor UA Overview to store step-completion state at the root and delegate step-completion logic to each step component.
* Add completion status to logs and issues steps

* [Upgrade Assistant] External links with checkpoint time-range applied (#111252)

* Bound query around last checkpoint date

* Fix tests

* Also test discover url contains search params

* Small refactor

* Keep state about lastCheckpoint in parent component

* Remove space

* Address CR changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Tests for updating step state accordingly if API poll receives count followed by error (#111701)

* Add test for logs count polling

* Test when count api fails

* [Upgrade Assistant] Add a11y tests for es deprecation flyouts (#110843)

* [Upgrade Assistant] Set fix_logs step as incomplete if log collection is not enabled (#111827)

* set step as incomplete if toggle is disabled

* Fix test names

* Remove unnecessary mocks

* [Upgrade Assistant] Update copy to use "issues" instead of "warnings" (#111817)

* Create common deprecation issues panel component in UA (#111231)

* Refine success state behavior and add tests.
* Refactor components into a components directory.
* Refactor SCSS to colocate styles with their components.
* Refactor tests to reduce boilerplate and clarify conditions under test.

* [Upgrade Assistant] Fix Kibana deprecations warning message

* [Upgrade Assistant] Add support for API keys when reindexing (#111451)

* [Upgrade Assistant] Update readme (#112154)

* [Upgrade Assistant] Make infra plugin optional (#111960)

* Make infra plugin optional

* Fix CR requests

* [Upgrade Assistant] Improve flyout information architecture (#111713)

* Make sure longstrings inside flyout body are text-wrap

* Show resolved badge for reindex flyout and row

* Finish off rest of ES deprecation flyouts

* Refactor deprecation badge into its own component

* Add tests for kibana deprecations

* Add tests for es deprecations

* Also check that we have status=error before rendering error callout

* Check for non-complete states instead of just error

* Small refactor

* Default deprecation is not resolvable

* Add a bit more spacing between title and badge

* Address CR changes

* Use EuiSpacer instead of flexitems

* [Upgrade Assistant] Update readme (#112195)

* [Upgrade Assistant] Add integration tests for Overview page (#111370)

* Add a11y tests for when overview page has toggle enabled

* Add functional and accessibility tests for overview page

* Load test files

* Fix linter error

* Navigate before asserting

* Steps have now completion state

* Remove duped word

* Run setup only once, not per test

* Address CR changes

* No need to renavigate to the page

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Add note about compatibility headers (#110469)

* Improve error states for Upgrade Assistant deprecation issues (#112457)

* Simplify error state for deprecation issues panels. Remove <EsStatsError />.

* Rename components from stats -> panel.

* Create common error-reporting component for use in both Kibana and ES deprecations pages.
* Align order of loading, error, and success states between these pages.
* Change references to 'deprecations' -> 'deprecation issues'.

* Fix tests for panels.

* Add API integration test for handling auth error.

* Fix TS errors.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Change count poll time to 15s (#112669)

* [Upgrade Assistant] Add permissions check to logs step (#112420)

* [Upgrade Assistant] Refactor telemetry (#112177)

* [Upgrade Assistant] Check for ML upgrade mode before enabling flyout actions (#112555)

* Add missing error handlers for deprecation logging route (#113109)

* [Upgrade Assistant] Batch reindex docs (#112960)

* [UA] Added batch reindexing docs link to the ES deprecations page. Added a link from "batch reindexing" docs page to "start or resume reindex" docs page and from there to ES reindexing docs page. Also renamed "reindexing operation" to "reindexing task" for consistency.

* [Upgrade Assistant] Added docs build files

* Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* [Upgrade Assistant] Added review suggestions and fixed eslint issues

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Improve error messages for GET /api/upgrade_assistant/reindex/<index> (#112961)

* Add support for single manual steps to Upgrade Assistant. (#113344)

* Revert "[Upgrade Assistant] Refactor telemetry (#112177)" (#113665)

This reverts commit 991d24b.

* [Upgrade Assistant] Use skipFetchFields when creating the indexPattern in order to avoid errors if index doesn't exist (#113821)

* Use skipFetchFields when creating the indexPatter in order to avoid errors when index doesnt exist

* Address CR feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Hide system indices from es deprecations list (#113627)

* Refactor reindex routes into separate single and batch reindex files. Apply version precheck to batch routes. (#113822)

* [Upgrade Assistant] Remove ML/Watcher logic (#113224)

* Add show upgrade flag to url (#114243)

* [Upgrade Assistant] Delete deprecation log cache (#114113)

* [Upgrade Assistant] Add upgrade system indices section (#110593)

* [Upgrade Assistant] Reindexing progress (#114275)

* [Upgrade Assistant] Added reindexing progress in % to the reindex flyout and es deprecations table

* [Upgrade Assistant] Renamed first argument in `getReindexProgressLabel` to `reindexTaskPercComplete` for consistency

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Remove Fix manually heading when there are no manual steps

* Add rolling upgrade interstitials to UA (#112907)

* Refactor FixLogsStep to be explicit in which props are passed to DeprecationLoggingToggle.

* Centralize error-handling logic in the api service, instead of handling it within each individual API request. Covers:
- Cloud backup status
- ES deprecations
- Deprecation logging
- Remove index settings
- ML
- Reindexing

Also:
- Handle 426 error state and surface in UI.
- Move ResponseError type into common/types.

* Add note about intended use case of status API route.

* Add endpoint dedicated to surfacing the cluster upgrade state, and a client-side poll.

* Merge App and AppWithRouter components.

* [Upgrade Assistant] Added "accept changes" header to the warnings list in the reindex flyout (#114798)

* Refactor kibana deprecation tests (#114763)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix linter issues

* Remove unused translation

* Prefer master changes over 7.x for ml docs

* Prefer master changes over 7.x

* Skip tests

* Move everything to a single describe

* Fix types

* Add missing prop to mock

* [Upgrade Assistant] Removed "closed index" warning from reindex flyout (#114861)

* [Upgrade Assistant] Removed "closed index" warning that reindexing might take longer than usual, which is not the case

* [Upgrade Assistant] Also deleted i18n strings that are not needed anymore

* Add LevelIconTips to be more explicit about the difference between critical and warning issues. (#115121)

* Extract common DeprecationFlyoutLearnMoreLink component and change wording to 'Learn more'. (#115117)

* [Upgrade Assistant] Reindexing cancellation (#114636)

* [Upgrade Assistant] Updated the reindexing cancellation to look less like an error

* [Upgrade Assistant] Fixed an i18n issue and updated a jest snapshot

* [Upgrade Assistant] Updated cancelled reindexing state with a unified label and cross icon

* [Upgrade Assistant] Fixed snapshot test

* [Upgrade Assistant] Updated spacing to the reindex cancel button

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix test errors (#115183)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Overview page UI clean up (#115258)

- Scaling down deprecation issue panel title size to flow with typographic hierarchy.
- Removing panel around deprecation logging switch to reduce visual elements.
- Using success instead of green color for migration complete message.

* Revert "Revert "[Upgrade Assistant] Refactor telemetry (#112177)" (#113665)" (#114804)

This reverts commit c385d49.
* Add migration to remove obsolete attributes from telemetry saved object.
* Refactor UA telemetry constants by extracting it from common/types.

* [Upgrade Assistant] Rename upgrade_status to migration_status (#114755)

* [Upgrade Assistant] Swapped reindexing flyouts order (#115046)

* [Upgrade Assistant] Changed reindexing steps order, replaced a warning callout with a text element

* [Upgrade Assistant] Fixed reindex flyout test and changed warning callout from danger color to warning color

* [Upgrade Assistant] Fixed the correct status to show warnings

* [Upgrade Assistant] Fixed i18n strings

* [Upgrade Assistant] Moved reindex with warnings logic into a function

* [Upgrade Assistant] Updated reindex flyout copy

* [Upgrade Assistant] Also added a trailing period to the reindex step 3

* [Upgrade Assistant] Fixed i18n strings and step 3 wording

* [Upgrade Assistant] Added docs changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Hide features that don't need to be migrated from flyout (#115535)

* Filter out system indices that dont require migration on server side
* Rename to attrs to migration
* Update flyout snapshot.

* Refine Upgrade Assistant copy. (#115472)

* Remove unused file

* Fix kibanaVersion dep

* Updated config.ts to fix UA test

UA functional API integration test to check cloud backup status creates a snapshot repo, which fails to be created with my changes to config.ts `'path.repo=/tmp/repo,/tmp/repo_1,/tmp/repo_2,'`. Adding `/tmp/cloud-snapshots/'` to the config fixes the test.

* Address CR changes

* Add missing error handler for system indices migration (#116088)

* Fix broken tests

* Fix test

* Skip tests

* Fix linter errors and import

* [Upgrade Assistant] Fix typo in retrieval of cluster settings (#116335)

* Fix typos

* Fix typo also in server tests

* Make sure log collection remains enabled throughout the test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix type errors

* Fix integration test types

* Fix accessibility test type errors

* Fix linter errors in shared_imports

* Fix functional test types

Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Alison Goryachev <alison.goryachev@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Dmitry Borodyansky <dborodyansky@gmail.com>
spalger pushed a commit to spalger/kibana that referenced this pull request Nov 11, 2021
@sabarasaba @cjcenizal
@alisonelizabeth @kibanamachine @yuliacech @jrodewig @dborodyansky
[Upgrade Assistant] Forwardport from 7.x (elastic#114966)
6f5f755 
* Fix link to Cloud deployment URL in upgrade step. (elastic#109528)

* [Upgrade Assistant] Refactor CITs

* Rename UA steps to fix_issues_step and fix_logs_step. (elastic#109526)

* Rename tests accordingly.

* [Upgrade Assistant] Cleanup scss (elastic#109524)

* [Upgrade Assistant] Update readme (elastic#109502)

* Add "Back up data" step to UA (elastic#109543)

* Add backup step with static content and link to Snapshot and Restore.
* Add snapshot_restore locator.
* Remove unnecessary describe block from Upgrade Step tests.
* Remove unused render_app.tsx.

* Change copy references of 'deprecation issues' to 'deprecation warnings'. (elastic#109963)

* [Upgrade Assistant] Address design feedback for ES deprecations page (elastic#109726)

* [Upgrade Assistant] Add checkpoint feature to Overview page (elastic#109449)

* Add on-Cloud state to Upgrade Assistant 'Back up data' step (elastic#109956)

* [Upgrade Assistant] Refactor external links to use locators (elastic#110435)

* [Upgrade Assistant] Use AppContext for services instead of KibanaContext (elastic#109801)

* Remove kibana context dependency in favour of app context

* Add missing type to ContextValue

* Fix mock type

* Refactor app mount flow and types

* Refactor to use useServices hook

* Fix linter issues

* Keep mount_management_section and initialize breadcrumbs and api there

* Remove useServices and usePlugins in favour of just useAppContext

* Remove unnecessary mocks

* [Upgrade Assistant] Enable functional and a11y tests (elastic#109909)

* [Upgrade Assistant] Remove version from UA nav title (elastic#110739)

* [Upgrade Assistant] New Kibana deprecations page (elastic#110101)

* Use injected lib.handleEsError instead of importing it in Upgrade Assistant API route handlers. (elastic#111067)

* Add tests for UA back up data step on Cloud (elastic#111066)

* Update UA to consume snapshotsUrl as provided by the Cloud plugin. (elastic#111239)

* Skip flaky UA Backup step polling test.

* [Upgrade Assistant] Refactor kibana deprecation service mocks (elastic#111168)

* [Upgrade Assistant] Remove unnecessary EuiScreenReaderOnly from stat panels (elastic#111518)

* Remove EuiScreenReaderOnly implementations

* Remove unused translations

* Remove extra string after merge conflict

* Use consistent 'issues' and 'critical' vs. 'warning' terminology in UA. (elastic#111221)

* Refactor UA Overview to support step-completion (elastic#111243)

* Refactor UA Overview to store step-completion state at the root and delegate step-completion logic to each step component.
* Add completion status to logs and issues steps

* [Upgrade Assistant] External links with checkpoint time-range applied (elastic#111252)

* Bound query around last checkpoint date

* Fix tests

* Also test discover url contains search params

* Small refactor

* Keep state about lastCheckpoint in parent component

* Remove space

* Address CR changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Tests for updating step state accordingly if API poll receives count followed by error (elastic#111701)

* Add test for logs count polling

* Test when count api fails

* [Upgrade Assistant] Add a11y tests for es deprecation flyouts (elastic#110843)

* [Upgrade Assistant] Set fix_logs step as incomplete if log collection is not enabled (elastic#111827)

* set step as incomplete if toggle is disabled

* Fix test names

* Remove unnecessary mocks

* [Upgrade Assistant] Update copy to use "issues" instead of "warnings" (elastic#111817)

* Create common deprecation issues panel component in UA (elastic#111231)

* Refine success state behavior and add tests.
* Refactor components into a components directory.
* Refactor SCSS to colocate styles with their components.
* Refactor tests to reduce boilerplate and clarify conditions under test.

* [Upgrade Assistant] Fix Kibana deprecations warning message

* [Upgrade Assistant] Add support for API keys when reindexing (elastic#111451)

* [Upgrade Assistant] Update readme (elastic#112154)

* [Upgrade Assistant] Make infra plugin optional (elastic#111960)

* Make infra plugin optional

* Fix CR requests

* [Upgrade Assistant] Improve flyout information architecture (elastic#111713)

* Make sure longstrings inside flyout body are text-wrap

* Show resolved badge for reindex flyout and row

* Finish off rest of ES deprecation flyouts

* Refactor deprecation badge into its own component

* Add tests for kibana deprecations

* Add tests for es deprecations

* Also check that we have status=error before rendering error callout

* Check for non-complete states instead of just error

* Small refactor

* Default deprecation is not resolvable

* Add a bit more spacing between title and badge

* Address CR changes

* Use EuiSpacer instead of flexitems

* [Upgrade Assistant] Update readme (elastic#112195)

* [Upgrade Assistant] Add integration tests for Overview page (elastic#111370)

* Add a11y tests for when overview page has toggle enabled

* Add functional and accessibility tests for overview page

* Load test files

* Fix linter error

* Navigate before asserting

* Steps have now completion state

* Remove duped word

* Run setup only once, not per test

* Address CR changes

* No need to renavigate to the page

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Add note about compatibility headers (elastic#110469)

* Improve error states for Upgrade Assistant deprecation issues (elastic#112457)

* Simplify error state for deprecation issues panels. Remove <EsStatsError />.

* Rename components from stats -> panel.

* Create common error-reporting component for use in both Kibana and ES deprecations pages.
* Align order of loading, error, and success states between these pages.
* Change references to 'deprecations' -> 'deprecation issues'.

* Fix tests for panels.

* Add API integration test for handling auth error.

* Fix TS errors.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Change count poll time to 15s (elastic#112669)

* [Upgrade Assistant] Add permissions check to logs step (elastic#112420)

* [Upgrade Assistant] Refactor telemetry (elastic#112177)

* [Upgrade Assistant] Check for ML upgrade mode before enabling flyout actions (elastic#112555)

* Add missing error handlers for deprecation logging route (elastic#113109)

* [Upgrade Assistant] Batch reindex docs (elastic#112960)

* [UA] Added batch reindexing docs link to the ES deprecations page. Added a link from "batch reindexing" docs page to "start or resume reindex" docs page and from there to ES reindexing docs page. Also renamed "reindexing operation" to "reindexing task" for consistency.

* [Upgrade Assistant] Added docs build files

* Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* [Upgrade Assistant] Added review suggestions and fixed eslint issues

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Improve error messages for GET /api/upgrade_assistant/reindex/<index> (elastic#112961)

* Add support for single manual steps to Upgrade Assistant. (elastic#113344)

* Revert "[Upgrade Assistant] Refactor telemetry (elastic#112177)" (elastic#113665)

This reverts commit 991d24b.

* [Upgrade Assistant] Use skipFetchFields when creating the indexPattern in order to avoid errors if index doesn't exist (elastic#113821)

* Use skipFetchFields when creating the indexPatter in order to avoid errors when index doesnt exist

* Address CR feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Hide system indices from es deprecations list (elastic#113627)

* Refactor reindex routes into separate single and batch reindex files. Apply version precheck to batch routes. (elastic#113822)

* [Upgrade Assistant] Remove ML/Watcher logic (elastic#113224)

* Add show upgrade flag to url (elastic#114243)

* [Upgrade Assistant] Delete deprecation log cache (elastic#114113)

* [Upgrade Assistant] Add upgrade system indices section (elastic#110593)

* [Upgrade Assistant] Reindexing progress (elastic#114275)

* [Upgrade Assistant] Added reindexing progress in % to the reindex flyout and es deprecations table

* [Upgrade Assistant] Renamed first argument in `getReindexProgressLabel` to `reindexTaskPercComplete` for consistency

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Remove Fix manually heading when there are no manual steps

* Add rolling upgrade interstitials to UA (elastic#112907)

* Refactor FixLogsStep to be explicit in which props are passed to DeprecationLoggingToggle.

* Centralize error-handling logic in the api service, instead of handling it within each individual API request. Covers:
- Cloud backup status
- ES deprecations
- Deprecation logging
- Remove index settings
- ML
- Reindexing

Also:
- Handle 426 error state and surface in UI.
- Move ResponseError type into common/types.

* Add note about intended use case of status API route.

* Add endpoint dedicated to surfacing the cluster upgrade state, and a client-side poll.

* Merge App and AppWithRouter components.

* [Upgrade Assistant] Added "accept changes" header to the warnings list in the reindex flyout (elastic#114798)

* Refactor kibana deprecation tests (elastic#114763)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix linter issues

* Remove unused translation

* Prefer master changes over 7.x for ml docs

* Prefer master changes over 7.x

* Skip tests

* Move everything to a single describe

* Fix types

* Add missing prop to mock

* [Upgrade Assistant] Removed "closed index" warning from reindex flyout (elastic#114861)

* [Upgrade Assistant] Removed "closed index" warning that reindexing might take longer than usual, which is not the case

* [Upgrade Assistant] Also deleted i18n strings that are not needed anymore

* Add LevelIconTips to be more explicit about the difference between critical and warning issues. (elastic#115121)

* Extract common DeprecationFlyoutLearnMoreLink component and change wording to 'Learn more'. (elastic#115117)

* [Upgrade Assistant] Reindexing cancellation (elastic#114636)

* [Upgrade Assistant] Updated the reindexing cancellation to look less like an error

* [Upgrade Assistant] Fixed an i18n issue and updated a jest snapshot

* [Upgrade Assistant] Updated cancelled reindexing state with a unified label and cross icon

* [Upgrade Assistant] Fixed snapshot test

* [Upgrade Assistant] Updated spacing to the reindex cancel button

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix test errors (elastic#115183)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Overview page UI clean up (elastic#115258)

- Scaling down deprecation issue panel title size to flow with typographic hierarchy.
- Removing panel around deprecation logging switch to reduce visual elements.
- Using success instead of green color for migration complete message.

* Revert "Revert "[Upgrade Assistant] Refactor telemetry (elastic#112177)" (elastic#113665)" (elastic#114804)

This reverts commit c385d49.
* Add migration to remove obsolete attributes from telemetry saved object.
* Refactor UA telemetry constants by extracting it from common/types.

* [Upgrade Assistant] Rename upgrade_status to migration_status (elastic#114755)

* [Upgrade Assistant] Swapped reindexing flyouts order (elastic#115046)

* [Upgrade Assistant] Changed reindexing steps order, replaced a warning callout with a text element

* [Upgrade Assistant] Fixed reindex flyout test and changed warning callout from danger color to warning color

* [Upgrade Assistant] Fixed the correct status to show warnings

* [Upgrade Assistant] Fixed i18n strings

* [Upgrade Assistant] Moved reindex with warnings logic into a function

* [Upgrade Assistant] Updated reindex flyout copy

* [Upgrade Assistant] Also added a trailing period to the reindex step 3

* [Upgrade Assistant] Fixed i18n strings and step 3 wording

* [Upgrade Assistant] Added docs changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Hide features that don't need to be migrated from flyout (elastic#115535)

* Filter out system indices that dont require migration on server side
* Rename to attrs to migration
* Update flyout snapshot.

* Refine Upgrade Assistant copy. (elastic#115472)

* Remove unused file

* Fix kibanaVersion dep

* Updated config.ts to fix UA test

UA functional API integration test to check cloud backup status creates a snapshot repo, which fails to be created with my changes to config.ts `'path.repo=/tmp/repo,/tmp/repo_1,/tmp/repo_2,'`. Adding `/tmp/cloud-snapshots/'` to the config fixes the test.

* Address CR changes

* Add missing error handler for system indices migration (elastic#116088)

* Fix broken tests

* Fix test

* Skip tests

* Fix linter errors and import

* [Upgrade Assistant] Fix typo in retrieval of cluster settings (elastic#116335)

* Fix typos

* Fix typo also in server tests

* Make sure log collection remains enabled throughout the test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix type errors

* Fix integration test types

* Fix accessibility test type errors

* Fix linter errors in shared_imports

* Fix functional test types

Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Alison Goryachev <alison.goryachev@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Dmitry Borodyansky <dborodyansky@gmail.com>
spalger pushed a commit that referenced this pull request Nov 11, 2021
@sabarasaba @cjcenizal
@alisonelizabeth @kibanamachine @yuliacech @jrodewig @dborodyansky
[8.0] [Upgrade Assistant] Forwardport from 7.x (#114966) (#118410)
3e90fbc 
* [Upgrade Assistant] Forwardport from 7.x (#114966)

* Fix link to Cloud deployment URL in upgrade step. (#109528)

* [Upgrade Assistant] Refactor CITs

* Rename UA steps to fix_issues_step and fix_logs_step. (#109526)

* Rename tests accordingly.

* [Upgrade Assistant] Cleanup scss (#109524)

* [Upgrade Assistant] Update readme (#109502)

* Add "Back up data" step to UA (#109543)

* Add backup step with static content and link to Snapshot and Restore.
* Add snapshot_restore locator.
* Remove unnecessary describe block from Upgrade Step tests.
* Remove unused render_app.tsx.

* Change copy references of 'deprecation issues' to 'deprecation warnings'. (#109963)

* [Upgrade Assistant] Address design feedback for ES deprecations page (#109726)

* [Upgrade Assistant] Add checkpoint feature to Overview page (#109449)

* Add on-Cloud state to Upgrade Assistant 'Back up data' step (#109956)

* [Upgrade Assistant] Refactor external links to use locators (#110435)

* [Upgrade Assistant] Use AppContext for services instead of KibanaContext (#109801)

* Remove kibana context dependency in favour of app context

* Add missing type to ContextValue

* Fix mock type

* Refactor app mount flow and types

* Refactor to use useServices hook

* Fix linter issues

* Keep mount_management_section and initialize breadcrumbs and api there

* Remove useServices and usePlugins in favour of just useAppContext

* Remove unnecessary mocks

* [Upgrade Assistant] Enable functional and a11y tests (#109909)

* [Upgrade Assistant] Remove version from UA nav title (#110739)

* [Upgrade Assistant] New Kibana deprecations page (#110101)

* Use injected lib.handleEsError instead of importing it in Upgrade Assistant API route handlers. (#111067)

* Add tests for UA back up data step on Cloud (#111066)

* Update UA to consume snapshotsUrl as provided by the Cloud plugin. (#111239)

* Skip flaky UA Backup step polling test.

* [Upgrade Assistant] Refactor kibana deprecation service mocks (#111168)

* [Upgrade Assistant] Remove unnecessary EuiScreenReaderOnly from stat panels (#111518)

* Remove EuiScreenReaderOnly implementations

* Remove unused translations

* Remove extra string after merge conflict

* Use consistent 'issues' and 'critical' vs. 'warning' terminology in UA. (#111221)

* Refactor UA Overview to support step-completion (#111243)

* Refactor UA Overview to store step-completion state at the root and delegate step-completion logic to each step component.
* Add completion status to logs and issues steps

* [Upgrade Assistant] External links with checkpoint time-range applied (#111252)

* Bound query around last checkpoint date

* Fix tests

* Also test discover url contains search params

* Small refactor

* Keep state about lastCheckpoint in parent component

* Remove space

* Address CR changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Tests for updating step state accordingly if API poll receives count followed by error (#111701)

* Add test for logs count polling

* Test when count api fails

* [Upgrade Assistant] Add a11y tests for es deprecation flyouts (#110843)

* [Upgrade Assistant] Set fix_logs step as incomplete if log collection is not enabled (#111827)

* set step as incomplete if toggle is disabled

* Fix test names

* Remove unnecessary mocks

* [Upgrade Assistant] Update copy to use "issues" instead of "warnings" (#111817)

* Create common deprecation issues panel component in UA (#111231)

* Refine success state behavior and add tests.
* Refactor components into a components directory.
* Refactor SCSS to colocate styles with their components.
* Refactor tests to reduce boilerplate and clarify conditions under test.

* [Upgrade Assistant] Fix Kibana deprecations warning message

* [Upgrade Assistant] Add support for API keys when reindexing (#111451)

* [Upgrade Assistant] Update readme (#112154)

* [Upgrade Assistant] Make infra plugin optional (#111960)

* Make infra plugin optional

* Fix CR requests

* [Upgrade Assistant] Improve flyout information architecture (#111713)

* Make sure longstrings inside flyout body are text-wrap

* Show resolved badge for reindex flyout and row

* Finish off rest of ES deprecation flyouts

* Refactor deprecation badge into its own component

* Add tests for kibana deprecations

* Add tests for es deprecations

* Also check that we have status=error before rendering error callout

* Check for non-complete states instead of just error

* Small refactor

* Default deprecation is not resolvable

* Add a bit more spacing between title and badge

* Address CR changes

* Use EuiSpacer instead of flexitems

* [Upgrade Assistant] Update readme (#112195)

* [Upgrade Assistant] Add integration tests for Overview page (#111370)

* Add a11y tests for when overview page has toggle enabled

* Add functional and accessibility tests for overview page

* Load test files

* Fix linter error

* Navigate before asserting

* Steps have now completion state

* Remove duped word

* Run setup only once, not per test

* Address CR changes

* No need to renavigate to the page

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Add note about compatibility headers (#110469)

* Improve error states for Upgrade Assistant deprecation issues (#112457)

* Simplify error state for deprecation issues panels. Remove <EsStatsError />.

* Rename components from stats -> panel.

* Create common error-reporting component for use in both Kibana and ES deprecations pages.
* Align order of loading, error, and success states between these pages.
* Change references to 'deprecations' -> 'deprecation issues'.

* Fix tests for panels.

* Add API integration test for handling auth error.

* Fix TS errors.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Change count poll time to 15s (#112669)

* [Upgrade Assistant] Add permissions check to logs step (#112420)

* [Upgrade Assistant] Refactor telemetry (#112177)

* [Upgrade Assistant] Check for ML upgrade mode before enabling flyout actions (#112555)

* Add missing error handlers for deprecation logging route (#113109)

* [Upgrade Assistant] Batch reindex docs (#112960)

* [UA] Added batch reindexing docs link to the ES deprecations page. Added a link from "batch reindexing" docs page to "start or resume reindex" docs page and from there to ES reindexing docs page. Also renamed "reindexing operation" to "reindexing task" for consistency.

* [Upgrade Assistant] Added docs build files

* Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

* [Upgrade Assistant] Added review suggestions and fixed eslint issues

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Improve error messages for GET /api/upgrade_assistant/reindex/<index> (#112961)

* Add support for single manual steps to Upgrade Assistant. (#113344)

* Revert "[Upgrade Assistant] Refactor telemetry (#112177)" (#113665)

This reverts commit 991d24b.

* [Upgrade Assistant] Use skipFetchFields when creating the indexPattern in order to avoid errors if index doesn't exist (#113821)

* Use skipFetchFields when creating the indexPatter in order to avoid errors when index doesnt exist

* Address CR feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Hide system indices from es deprecations list (#113627)

* Refactor reindex routes into separate single and batch reindex files. Apply version precheck to batch routes. (#113822)

* [Upgrade Assistant] Remove ML/Watcher logic (#113224)

* Add show upgrade flag to url (#114243)

* [Upgrade Assistant] Delete deprecation log cache (#114113)

* [Upgrade Assistant] Add upgrade system indices section (#110593)

* [Upgrade Assistant] Reindexing progress (#114275)

* [Upgrade Assistant] Added reindexing progress in % to the reindex flyout and es deprecations table

* [Upgrade Assistant] Renamed first argument in `getReindexProgressLabel` to `reindexTaskPercComplete` for consistency

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Remove Fix manually heading when there are no manual steps

* Add rolling upgrade interstitials to UA (#112907)

* Refactor FixLogsStep to be explicit in which props are passed to DeprecationLoggingToggle.

* Centralize error-handling logic in the api service, instead of handling it within each individual API request. Covers:
- Cloud backup status
- ES deprecations
- Deprecation logging
- Remove index settings
- ML
- Reindexing

Also:
- Handle 426 error state and surface in UI.
- Move ResponseError type into common/types.

* Add note about intended use case of status API route.

* Add endpoint dedicated to surfacing the cluster upgrade state, and a client-side poll.

* Merge App and AppWithRouter components.

* [Upgrade Assistant] Added "accept changes" header to the warnings list in the reindex flyout (#114798)

* Refactor kibana deprecation tests (#114763)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix linter issues

* Remove unused translation

* Prefer master changes over 7.x for ml docs

* Prefer master changes over 7.x

* Skip tests

* Move everything to a single describe

* Fix types

* Add missing prop to mock

* [Upgrade Assistant] Removed "closed index" warning from reindex flyout (#114861)

* [Upgrade Assistant] Removed "closed index" warning that reindexing might take longer than usual, which is not the case

* [Upgrade Assistant] Also deleted i18n strings that are not needed anymore

* Add LevelIconTips to be more explicit about the difference between critical and warning issues. (#115121)

* Extract common DeprecationFlyoutLearnMoreLink component and change wording to 'Learn more'. (#115117)

* [Upgrade Assistant] Reindexing cancellation (#114636)

* [Upgrade Assistant] Updated the reindexing cancellation to look less like an error

* [Upgrade Assistant] Fixed an i18n issue and updated a jest snapshot

* [Upgrade Assistant] Updated cancelled reindexing state with a unified label and cross icon

* [Upgrade Assistant] Fixed snapshot test

* [Upgrade Assistant] Updated spacing to the reindex cancel button

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix test errors (#115183)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Overview page UI clean up (#115258)

- Scaling down deprecation issue panel title size to flow with typographic hierarchy.
- Removing panel around deprecation logging switch to reduce visual elements.
- Using success instead of green color for migration complete message.

* Revert "Revert "[Upgrade Assistant] Refactor telemetry (#112177)" (#113665)" (#114804)

This reverts commit c385d49.
* Add migration to remove obsolete attributes from telemetry saved object.
* Refactor UA telemetry constants by extracting it from common/types.

* [Upgrade Assistant] Rename upgrade_status to migration_status (#114755)

* [Upgrade Assistant] Swapped reindexing flyouts order (#115046)

* [Upgrade Assistant] Changed reindexing steps order, replaced a warning callout with a text element

* [Upgrade Assistant] Fixed reindex flyout test and changed warning callout from danger color to warning color

* [Upgrade Assistant] Fixed the correct status to show warnings

* [Upgrade Assistant] Fixed i18n strings

* [Upgrade Assistant] Moved reindex with warnings logic into a function

* [Upgrade Assistant] Updated reindex flyout copy

* [Upgrade Assistant] Also added a trailing period to the reindex step 3

* [Upgrade Assistant] Fixed i18n strings and step 3 wording

* [Upgrade Assistant] Added docs changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Upgrade Assistant] Hide features that don't need to be migrated from flyout (#115535)

* Filter out system indices that dont require migration on server side
* Rename to attrs to migration
* Update flyout snapshot.

* Refine Upgrade Assistant copy. (#115472)

* Remove unused file

* Fix kibanaVersion dep

* Updated config.ts to fix UA test

UA functional API integration test to check cloud backup status creates a snapshot repo, which fails to be created with my changes to config.ts `'path.repo=/tmp/repo,/tmp/repo_1,/tmp/repo_2,'`. Adding `/tmp/cloud-snapshots/'` to the config fixes the test.

* Address CR changes

* Add missing error handler for system indices migration (#116088)

* Fix broken tests

* Fix test

* Skip tests

* Fix linter errors and import

* [Upgrade Assistant] Fix typo in retrieval of cluster settings (#116335)

* Fix typos

* Fix typo also in server tests

* Make sure log collection remains enabled throughout the test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Fix type errors

* Fix integration test types

* Fix accessibility test type errors

* Fix linter errors in shared_imports

* Fix functional test types

Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Alison Goryachev <alison.goryachev@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Dmitry Borodyansky <dborodyansky@gmail.com>

* commit with @elastic.co email

Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Alison Goryachev <alison.goryachev@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Dmitry Borodyansky <dborodyansky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cjcenizal cjcenizal cjcenizal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sabarasaba sabarasaba

Labels

chore Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sabarasaba @elasticmachine @kibanamachine @cjcenizal