[Core deprecations] Add title field to deprecation info by Bamieh · Pull Request #109840 · elastic/kibana

Bamieh · 2021-08-24T13:40:35Z

Summary

Use i18n for all current deprecations + update all documentations to include i18n guidelines and i18n in the examples.
Update deprecation service README to include best practices for writing deprecations
Add support for deprecation title. The title will be displayed in multiple places in the Upgrade assistant.
- Config deprecation title for unused, rename, renameFromRoot and unusedFromRoot:
```
Setting {path} is deprecated
```
- Custom config deprecation default title
```
{domainId} has a deprecated setting
```
- deprecation title on fetch failure
```
Failed to fetch deprecations for {domainId}
```
- deprecation title for plugin deprecations: no default and required for each deprecation.

Context: #109166
Closes #99625
Closes #99072

Note to reviewers:

Since the title field is required I've also added titles to the following list of deprecations. If your team is requested a review please filter changes by codeowners and verify that the title makes sense.

Updated deprecation titles

src/plugins/data/server/index_patterns/deprecations/scripted_fields.ts
src/plugins/timelion/server/deprecations.ts
x-pack/plugins/reporting/server/deprecations/migrate_existing_indices_ilm_policy.ts
x-pack/plugins/reporting/server/deprecations/reporting_role.ts

alisonelizabeth

General approach LGTM. I'd recommend bringing in someone from the docs team as well to review the copy changes once this is ready for review.

…add_title_field

alisonelizabeth

This looks great @Bamieh! Tested locally. Thanks for working on it. Left a couple nits mostly around the copy, but probably best if @gchaps takes a look as well.

packages/kbn-config/src/deprecation/deprecation_factory.ts

src/core/server/deprecations/README.mdx

x-pack/plugins/upgrade_assistant/__jest__/client_integration/kibana.test.ts

jportner

Code review only -- snapshot changes in x-pack/plugins/security/server/config_deprecations.test.ts LGTM

jloleysens

Thanks for making these changes @Bamieh ! App services changes look good, though I think we should update the titles to something a bit more helpful.

I agree with @alisonelizabeth that getting proper copy review before (or soon after) merging would be best.

x-pack/plugins/reporting/server/deprecations/reporting_role.ts

x-pack/plugins/reporting/server/deprecations/migrate_existing_indices_ilm_policy.ts

jloleysens · 2021-08-26T13:29:21Z

src/plugins/data/server/index_patterns/deprecations/scripted_fields.ts

        {
-          message: `You have ${indexPatternsWithScriptedFields.length} index patterns (${titlesPreview}...) that use scripted fields. Scripted fields are deprecated and will be removed in future. Use runtime fields instead.`,
+          title: i18n.translate('data.deprecations.scriptedFieldsTitle', {
+            defaultMessage: 'Found scripted fields',


Suggested change

defaultMessage: 'Found scripted fields',

defaultMessage: 'Found index patterns using scripted fields',

CC @mattkime for the accuracy of this title.

debadair

I didn't provide suggestions for every occurrence, as it was repetitive. I can if it's helpful, but felt like I was just repeating myself. :-) In general:

Avoid repeating the title in the message.
Avoid using quotes for emphasis.
Make sure there is end punctuation on the messages.
Where possible, lead with the action the user has to take, rather than the context.

docs/development/core/server/kibana-plugin-core-server.deprecationsservicesetup.md

debadair · 2021-08-30T22:38:04Z

docs/development/core/server/kibana-plugin-core-server.deprecationsservicesetup.md

+           i18n.translate('xpack.timelion.deprecations.worksheets.manualStepOneMessage', {
+             defaultMessage: 'Navigate to the Kibana Dashboard and click "Create dashboard".',
+           }),
+           i18n.translate('xpack.timelion.deprecations.worksheets.manualStepTwoMessage', {
+             defaultMessage: 'Select Timelion from the "New Visualization" window.',
+           }),


This feels incomplete--or at least unclear where you need to select Timelion.

This is just an example so I only kept the first two steps

packages/kbn-config/src/deprecation/deprecation_factory.test.ts

src/core/server/deprecations/README.mdx

stratoula

Kibana app code changes LGTM, code review only

…add_title_field

kibanamachine · 2021-08-31T16:14:40Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 623579c
Storybooks Preview
Flaky suites:
- xpack-kibana-ciGroup12

Test Failures

Kibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/exception_operators_data_types/ip_array·ts.detection engine api security and spaces enabled Detection exceptions data types and operators Rule exception operators for data type ip "is in list" operator will return 1 result if we have a list that includes all ips

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/89052

[00:00:00]       │
[00:00:00]         └-: detection engine api security and spaces enabled
[00:00:00]           └-> "before all" hook in "detection engine api security and spaces enabled"
[00:00:00]           └-: 
[00:00:00]             └-> "before all" hook in ""
[00:00:00]             └-: Detection exceptions data types and operators
[00:00:00]               └-> "before all" hook in "Detection exceptions data types and operators"
[00:00:00]               └-: 
[00:00:00]                 └-> "before all" hook in ""
[00:06:05]                 └-: Rule exception operators for data type ip
[00:06:05]                   └-> "before all" hook in "Rule exception operators for data type ip"
[00:06:05]                   └-> "before all" hook in "Rule exception operators for data type ip"
[00:06:05]                     │ info [x-pack/test/functional/es_archives/rule_exceptions/ip_as_array] Loading "mappings.json"
[00:06:05]                     │ info [x-pack/test/functional/es_archives/rule_exceptions/ip_as_array] Loading "data.json"
[00:06:06]                     │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [ip_as_array] creating index, cause [api], templates [], shards [1]/[1]
[00:06:06]                     │ info [x-pack/test/functional/es_archives/rule_exceptions/ip_as_array] Created index "ip_as_array"
[00:06:06]                     │ debg [x-pack/test/functional/es_archives/rule_exceptions/ip_as_array] "ip_as_array" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:06:06]                     │ info [x-pack/test/functional/es_archives/rule_exceptions/ip_as_array] Indexed 4 docs into "ip_as_array"
[00:09:30]                   └-: "is in list" operator
[00:09:30]                     └-> "before all" hook for "will return 3 results if we have a list that includes 1 ip"
[00:09:30]                     └-> will return 3 results if we have a list that includes 1 ip
[00:09:30]                       └-> "before each" hook: global before each for "will return 3 results if we have a list that includes 1 ip"
[00:09:30]                       └-> "before each" hook for "will return 3 results if we have a list that includes 1 ip"
[00:09:30]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [node-01] adding index lifecycle policy [.siem-signals-default]
[00:09:30]                         │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] adding index template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:09:30]                         │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1]
[00:09:30]                         │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:09:30]                         │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.siem-signals-default]
[00:09:30]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [node-01] adding index lifecycle policy [.lists-default]
[00:09:30]                         │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.siem-signals-default]
[00:09:30]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [node-01] adding index lifecycle policy [.items-default]
[00:09:30]                         │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] adding template [.lists-default] for index patterns [.lists-default-*]
[00:09:30]                         │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] adding template [.items-default] for index patterns [.items-default-*]
[00:09:30]                         │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.lists-default-000001] creating index, cause [api], templates [.lists-default], shards [1]/[1]
[00:09:30]                         │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.lists-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.lists-default]
[00:09:30]                         │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.items-default-000001] creating index, cause [api], templates [.items-default], shards [1]/[1]
[00:09:30]                       │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.items-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.items-default]
[00:09:30]                       │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.lists-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.lists-default]
[00:09:30]                       │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.items-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.items-default]
[00:09:30]                       │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.lists-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.lists-default]
[00:09:30]                       │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.items-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.items-default]
[00:09:40]                       │ proc [kibana]   log   [15:05:27.816] [info][eventLog][plugins] event logged: {"@timestamp":"2021-08-31T15:05:27.815Z","event":{"provider":"alerting","action":"execute-start","kind":"alert","category":["siem"],"start":"2021-08-31T15:05:27.815Z"},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"dd24e090-0a6c-11ec-9c9e-efee86215f82","type_id":"siem.signals"}],"task":{"scheduled":"2021-08-31T15:05:25.500Z","schedule_delay":2315000000},"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"8.0.0"},"rule":{"id":"dd24e090-0a6c-11ec-9c9e-efee86215f82","license":"basic","category":"siem.signals","ruleset":"siem"},"message":"alert execution start: \"dd24e090-0a6c-11ec-9c9e-efee86215f82\"","ecs":{"version":"1.8.0"}}
[00:09:43]                       │ proc [kibana]   log   [15:05:30.551] [info][plugins][securitySolution] [+] Finished indexing 3  signals searched between date ranges [
[00:09:43]                       │ proc [kibana]   {
[00:09:43]                       │ proc [kibana]     "to": "2021-08-31T15:05:29.547Z",
[00:09:43]                       │ proc [kibana]     "from": "1900-01-01T00:00:00.000Z",
[00:09:43]                       │ proc [kibana]     "maxSignals": 100
[00:09:43]                       │ proc [kibana]   }
[00:09:43]                       │ proc [kibana] ] name: "Signal Testing Query" id: "dd24e090-0a6c-11ec-9c9e-efee86215f82" rule id: "rule-1" signals index: ".siem-signals-default"
[00:09:43]                       │ proc [kibana]   log   [15:05:30.561] [info][eventLog][plugins] event logged: {"@timestamp":"2021-08-31T15:05:27.815Z","event":{"provider":"alerting","action":"execute","kind":"alert","category":["siem"],"start":"2021-08-31T15:05:27.815Z","outcome":"success","end":"2021-08-31T15:05:30.560Z","duration":2745000000},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"dd24e090-0a6c-11ec-9c9e-efee86215f82","type_id":"siem.signals"}],"task":{"scheduled":"2021-08-31T15:05:25.500Z","schedule_delay":2315000000},"alerting":{"status":"ok"},"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"8.0.0"},"rule":{"id":"dd24e090-0a6c-11ec-9c9e-efee86215f82","license":"basic","category":"siem.signals","ruleset":"siem","name":"Signal Testing Query"},"message":"alert executed: siem.signals:dd24e090-0a6c-11ec-9c9e-efee86215f82: 'Signal Testing Query'","ecs":{"version":"1.8.0"}}
[00:09:43]                       └- ✓ pass  (12.3s) "detection engine api security and spaces enabled  Detection exceptions data types and operators  Rule exception operators for data type ip "is in list" operator will return 3 results if we have a list that includes 1 ip"
[00:09:43]                     └-> "after each" hook for "will return 3 results if we have a list that includes 1 ip"
[00:09:43]                       │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.siem-signals-default-000001/TBSn3GG2TMeP4kyAmlCOsQ] deleting index
[00:09:43]                       │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] removing index template [.siem-signals-default]
[00:09:45]                       │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.lists-default-000001/BM0drRjJSVO5Ke7U78king] deleting index
[00:09:45]                       │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.items-default-000001/sX0NUkBzQ4q8g8gkVBjTHA] deleting index
[00:09:45]                       │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] removing template [.lists-default]
[00:09:45]                       │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] removing template [.items-default]
[00:09:45]                     └-> will return 2 results if we have a list that includes 2 ips
[00:09:45]                       └-> "before each" hook: global before each for "will return 2 results if we have a list that includes 2 ips"
[00:09:45]                       └-> "before each" hook for "will return 2 results if we have a list that includes 2 ips"
[00:09:45]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [node-01] adding index lifecycle policy [.siem-signals-default]
[00:09:45]                         │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] adding index template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:09:45]                         │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1]
[00:09:45]                         │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:09:45]                         │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.siem-signals-default]
[00:09:45]                         │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.siem-signals-default]
[00:09:45]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [node-01] adding index lifecycle policy [.lists-default]
[00:09:45]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [node-01] adding index lifecycle policy [.items-default]
[00:09:45]                         │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] adding template [.lists-default] for index patterns [.lists-default-*]
[00:09:45]                         │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] adding template [.items-default] for index patterns [.items-default-*]
[00:09:45]                         │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.lists-default-000001] creating index, cause [api], templates [.lists-default], shards [1]/[1]
[00:09:45]                         │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.lists-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.lists-default]
[00:09:45]                         │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.items-default-000001] creating index, cause [api], templates [.items-default], shards [1]/[1]
[00:09:45]                         │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.items-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.items-default]
[00:09:45]                       │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.lists-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.lists-default]
[00:09:45]                       │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.items-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.items-default]
[00:09:45]                       │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.lists-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.lists-default]
[00:09:45]                       │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.items-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.items-default]
[00:09:55]                       │ proc [kibana]   log   [15:05:42.780] [info][eventLog][plugins] event logged: {"@timestamp":"2021-08-31T15:05:42.780Z","event":{"provider":"alerting","action":"execute-start","kind":"alert","category":["siem"],"start":"2021-08-31T15:05:42.780Z"},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"e59389c0-0a6c-11ec-9c9e-efee86215f82","type_id":"siem.signals"}],"task":{"scheduled":"2021-08-31T15:05:39.643Z","schedule_delay":3137000000},"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"8.0.0"},"rule":{"id":"e59389c0-0a6c-11ec-9c9e-efee86215f82","license":"basic","category":"siem.signals","ruleset":"siem"},"message":"alert execution start: \"e59389c0-0a6c-11ec-9c9e-efee86215f82\"","ecs":{"version":"1.8.0"}}
[00:09:58]                       │ proc [kibana]   log   [15:05:45.686] [info][plugins][securitySolution] [+] Finished indexing 2  signals searched between date ranges [
[00:09:58]                       │ proc [kibana]   {
[00:09:58]                       │ proc [kibana]     "to": "2021-08-31T15:05:44.682Z",
[00:09:58]                       │ proc [kibana]     "from": "1900-01-01T00:00:00.000Z",
[00:09:58]                       │ proc [kibana]     "maxSignals": 100
[00:09:58]                       │ proc [kibana]   }
[00:09:58]                       │ proc [kibana] ] name: "Signal Testing Query" id: "e59389c0-0a6c-11ec-9c9e-efee86215f82" rule id: "rule-1" signals index: ".siem-signals-default"
[00:09:58]                       │ proc [kibana]   log   [15:05:45.728] [info][eventLog][plugins] event logged: {"@timestamp":"2021-08-31T15:05:42.780Z","event":{"provider":"alerting","action":"execute","kind":"alert","category":["siem"],"start":"2021-08-31T15:05:42.780Z","outcome":"success","end":"2021-08-31T15:05:45.727Z","duration":2947000000},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"e59389c0-0a6c-11ec-9c9e-efee86215f82","type_id":"siem.signals"}],"task":{"scheduled":"2021-08-31T15:05:39.643Z","schedule_delay":3137000000},"alerting":{"status":"ok"},"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"8.0.0"},"rule":{"id":"e59389c0-0a6c-11ec-9c9e-efee86215f82","license":"basic","category":"siem.signals","ruleset":"siem","name":"Signal Testing Query"},"message":"alert executed: siem.signals:e59389c0-0a6c-11ec-9c9e-efee86215f82: 'Signal Testing Query'","ecs":{"version":"1.8.0"}}
[00:09:58]                       └- ✓ pass  (12.4s) "detection engine api security and spaces enabled  Detection exceptions data types and operators  Rule exception operators for data type ip "is in list" operator will return 2 results if we have a list that includes 2 ips"
[00:09:58]                     └-> "after each" hook for "will return 2 results if we have a list that includes 2 ips"
[00:09:58]                       │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.siem-signals-default-000001/I7N_EHUqTlelL43yeKoxWQ] deleting index
[00:09:58]                       │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] removing index template [.siem-signals-default]
[00:10:00]                       │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.lists-default-000001/o-qSPFs8QDisr_OQpGYqKQ] deleting index
[00:10:00]                       │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.items-default-000001/H63mILYATF2NksOwJqRzEA] deleting index
[00:10:00]                       │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] removing template [.lists-default]
[00:10:00]                       │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] removing template [.items-default]
[00:10:00]                     └-> will return 1 result if we have a list that includes all ips
[00:10:00]                       └-> "before each" hook: global before each for "will return 1 result if we have a list that includes all ips"
[00:10:00]                       └-> "before each" hook for "will return 1 result if we have a list that includes all ips"
[00:10:00]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [node-01] adding index lifecycle policy [.siem-signals-default]
[00:10:00]                         │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] adding index template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:10:00]                         │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1]
[00:10:00]                         │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:10:00]                         │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.siem-signals-default]
[00:10:00]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [node-01] adding index lifecycle policy [.lists-default]
[00:10:00]                         │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.siem-signals-default]
[00:10:00]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [node-01] adding index lifecycle policy [.items-default]
[00:10:00]                         │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] adding template [.lists-default] for index patterns [.lists-default-*]
[00:10:00]                         │ info [o.e.c.m.MetadataIndexTemplateService] [node-01] adding template [.items-default] for index patterns [.items-default-*]
[00:10:00]                         │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.lists-default-000001] creating index, cause [api], templates [.lists-default], shards [1]/[1]
[00:10:00]                         │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.lists-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.lists-default]
[00:10:00]                         │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.items-default-000001] creating index, cause [api], templates [.items-default], shards [1]/[1]
[00:10:00]                         │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.lists-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.lists-default]
[00:10:00]                       │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.items-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.items-default]
[00:10:00]                       │ info [o.e.x.i.IndexLifecycleTransition] [node-01] moving index [.lists-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.lists-default]
[00:10:10]                       │ proc [kibana]   log   [15:05:57.818] [info][eventLog][plugins] event logged: {"@timestamp":"2021-08-31T15:05:57.817Z","event":{"provider":"alerting","action":"execute-start","kind":"alert","category":["siem"],"start":"2021-08-31T15:05:57.817Z"},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"ee9b3ea0-0a6c-11ec-9c9e-efee86215f82","type_id":"siem.signals"}],"task":{"scheduled":"2021-08-31T15:05:54.804Z","schedule_delay":3013000000},"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"8.0.0"},"rule":{"id":"ee9b3ea0-0a6c-11ec-9c9e-efee86215f82","license":"basic","category":"siem.signals","ruleset":"siem"},"message":"alert execution start: \"ee9b3ea0-0a6c-11ec-9c9e-efee86215f82\"","ecs":{"version":"1.8.0"}}
[00:10:13]                       │ proc [kibana]   log   [15:06:00.861] [info][plugins][securitySolution] [+] Finished indexing 1  signals searched between date ranges [
[00:10:13]                       │ proc [kibana]   {
[00:10:13]                       │ proc [kibana]     "to": "2021-08-31T15:05:59.894Z",
[00:10:13]                       │ proc [kibana]     "from": "1900-01-01T00:00:00.000Z",
[00:10:13]                       │ proc [kibana]     "maxSignals": 100
[00:10:13]                       │ proc [kibana]   }
[00:10:13]                       │ proc [kibana] ] name: "Signal Testing Query" id: "ee9b3ea0-0a6c-11ec-9c9e-efee86215f82" rule id: "rule-1" signals index: ".siem-signals-default"
[00:10:13]                       │ proc [kibana]   log   [15:06:00.871] [info][eventLog][plugins] event logged: {"@timestamp":"2021-08-31T15:05:57.817Z","event":{"provider":"alerting","action":"execute","kind":"alert","category":["siem"],"start":"2021-08-31T15:05:57.817Z","outcome":"success","end":"2021-08-31T15:06:00.870Z","duration":3053000000},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"ee9b3ea0-0a6c-11ec-9c9e-efee86215f82","type_id":"siem.signals"}],"task":{"scheduled":"2021-08-31T15:05:54.804Z","schedule_delay":3013000000},"alerting":{"status":"ok"},"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"8.0.0"},"rule":{"id":"ee9b3ea0-0a6c-11ec-9c9e-efee86215f82","license":"basic","category":"siem.signals","ruleset":"siem","name":"Signal Testing Query"},"message":"alert executed: siem.signals:ee9b3ea0-0a6c-11ec-9c9e-efee86215f82: 'Signal Testing Query'","ecs":{"version":"1.8.0"}}
[00:10:13]                       └- ✖ fail: detection engine api security and spaces enabled  Detection exceptions data types and operators  Rule exception operators for data type ip "is in list" operator will return 1 result if we have a list that includes all ips
[00:10:13]                       │       Error: expected [] to sort of equal [ [] ]
[00:10:13]                       │       + expected - actual
[00:10:13]                       │ 
[00:10:13]                       │       -[]
[00:10:13]                       │       +[
[00:10:13]                       │       +  []
[00:10:13]                       │       +]
[00:10:13]                       │       
[00:10:13]                       │       at Assertion.assert (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:10:13]                       │       at Assertion.eql (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:10:13]                       │       at Context.<anonymous> (test/detection_engine_api_integration/security_and_spaces/tests/exception_operators_data_types/ip_array.ts:513:24)
[00:10:13]                       │       at runMicrotasks (<anonymous>)
[00:10:13]                       │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:10:13]                       │       at Object.apply (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:10:13]                       │ 
[00:10:13]                       │

Stack Trace

Error: expected [] to sort of equal [ [] ]
    at Assertion.assert (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at Context.<anonymous> (test/detection_engine_api_integration/security_and_spaces/tests/exception_operators_data_types/ip_array.ts:513:24)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.apply (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16) {
  actual: '[]',
  expected: '[\n  []\n]',
  showDiff: true
}

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`core`	998	997	-1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	417.5KB	417.6KB	+110.0B

Unknown metric groups

API count

id	before	after	diff
`core`	2247	2248	+1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-09-01T10:13:36Z

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 109840

… (#110776) * merge conflicts * fix snapshot

initial changes

de0aa02

Bamieh added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Aug 24, 2021

alisonelizabeth reviewed Aug 24, 2021

View reviewed changes

Bamieh added 3 commits August 25, 2021 15:08

update titles + README

4c410c0

Merge branch 'master' of github.com:elastic/kibana into deprecations/…

161021e

…add_title_field

finalize PR

d7375aa

Bamieh marked this pull request as ready for review August 25, 2021 16:02

Bamieh requested a review from a team August 25, 2021 16:02

Bamieh requested review from a team as code owners August 25, 2021 16:02

api docs

0e2d4b3

Bamieh requested a review from alisonelizabeth August 25, 2021 17:25

alisonelizabeth approved these changes Aug 26, 2021

View reviewed changes

code review fixes

4e496de

Bamieh requested a review from a team as a code owner August 26, 2021 11:56

Bamieh assigned gchaps and unassigned gchaps Aug 26, 2021

Bamieh requested a review from gchaps August 26, 2021 11:57

jportner approved these changes Aug 26, 2021

View reviewed changes

jloleysens approved these changes Aug 26, 2021

View reviewed changes

debadair reviewed Aug 30, 2021

View reviewed changes

stratoula approved these changes Aug 31, 2021

View reviewed changes

Bamieh added 3 commits August 31, 2021 11:37

Merge branch 'master' of github.com:elastic/kibana into deprecations/…

5572525

…add_title_field

docs code review changes

c4998a1

jeans code review changes

3f4e9f7

Bamieh added 2 commits August 31, 2021 13:47

run i18n check

d120bc6

update snapshots after changes

87deb1a

rudolf approved these changes Aug 31, 2021

View reviewed changes

update snapshots after changes

623579c

alisonelizabeth mentioned this pull request Aug 31, 2021

[Upgrade Assistant] New Kibana deprecations page #110101

Merged

Bamieh merged commit 249c5fb into elastic:master Sep 1, 2021

Bamieh deleted the deprecations/add_title_field branch September 1, 2021 10:10

Bamieh mentioned this pull request Sep 1, 2021

[7.x] [Core deprecations] Add title field to deprecation info (#109840) #110776

Merged

Bamieh added a commit that referenced this pull request Sep 1, 2021

[7.x] [Core deprecations] Add title field to deprecation info (#109840)…

f85a7b9

… (#110776) * merge conflicts * fix snapshot

	defaultMessage: 'Found scripted fields',
	defaultMessage: 'Found index patterns using scripted fields',

Conversation

Bamieh commented Aug 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Note to reviewers:

Updated deprecation titles

Uh oh!

alisonelizabeth left a comment

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jportner left a comment

Choose a reason for hiding this comment

Uh oh!

jloleysens left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jloleysens Aug 26, 2021

Choose a reason for hiding this comment

Uh oh!

debadair left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

debadair Aug 30, 2021

Choose a reason for hiding this comment

Uh oh!

Bamieh Aug 31, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Aug 31, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Public APIs missing comments

Page load bundle

API count

History

Uh oh!

kibanamachine commented Sep 1, 2021

💔 Backport failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Bamieh commented Aug 24, 2021 •

edited

Loading