jeans code review changes

Bamieh · Bamieh · commit 3f4e9f7ec796 · 2021-08-31T13:21:23.000+03:00
diff --git a/src/plugins/data/server/index_patterns/deprecations/scripted_fields.ts b/src/plugins/data/server/index_patterns/deprecations/scripted_fields.ts
@@ -43,7 +43,7 @@ export const createScriptedFieldsDeprecationsConfig: (
       return [
         {
           title: i18n.translate('data.deprecations.scriptedFieldsTitle', {
-            defaultMessage: 'Found scripted fields',
+            defaultMessage: 'Found index patterns using scripted fields',
           }),
           message: i18n.translate('data.deprecations.scriptedFieldsMessage', {
             defaultMessage: `You have {numberOfIndexPatternsWithScriptedFields} index patterns ({titlesPreview}...) that use scripted fields. Scripted fields are deprecated and will be removed in future. Use runtime fields instead.`,
diff --git a/x-pack/plugins/reporting/server/deprecations/migrage_existing_indices_ilm_policy.test.ts b/x-pack/plugins/reporting/server/deprecations/migrage_existing_indices_ilm_policy.test.ts
@@ -66,7 +66,7 @@ describe("Migrate existing indices' ILM policy deprecations", () => {
           },
           "level": "warning",
           "message": "New reporting indices will be managed by the \\"kibana-reporting\\" provisioned ILM policy. You must edit this policy to manage the report lifecycle. This change targets all indices prefixed with \\".reporting-*\\".",
-          "title": "Found reporting indices with deprecated policy.",
+          "title": "Found reporting indices managed by custom ILM policy.",
         },
       ]
     `);
diff --git a/x-pack/plugins/reporting/server/deprecations/migrate_existing_indices_ilm_policy.ts b/x-pack/plugins/reporting/server/deprecations/migrate_existing_indices_ilm_policy.ts
@@ -31,7 +31,7 @@ export const getDeprecationsInfo = async (
     return [
       {
         title: i18n.translate('xpack.reporting.deprecations.migrateIndexIlmPolicyActionTitle', {
-          defaultMessage: 'Found reporting indices with deprecated policy.',
+          defaultMessage: 'Found reporting indices managed by custom ILM policy.',
         }),
         level: 'warning',
         message: i18n.translate('xpack.reporting.deprecations.migrateIndexIlmPolicyActionMessage', {

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ export const createScriptedFieldsDeprecationsConfig: (`
`43`	`43`	`return [`
`44`	`44`	`{`
`45`	`45`	`title: i18n.translate('data.deprecations.scriptedFieldsTitle', {`
`46`		`- defaultMessage: 'Found scripted fields',`
	`46`	`+ defaultMessage: 'Found index patterns using scripted fields',`
`47`	`47`	`}),`
`48`	`48`	`message: i18n.translate('data.deprecations.scriptedFieldsMessage', {`
`49`	`49`	defaultMessage: `You have {numberOfIndexPatternsWithScriptedFields} index patterns ({titlesPreview}...) that use scripted fields. Scripted fields are deprecated and will be removed in future. Use runtime fields instead.`,
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ describe("Migrate existing indices' ILM policy deprecations", () => {`
`66`	`66`	`},`
`67`	`67`	`"level": "warning",`
`68`	`68`	`"message": "New reporting indices will be managed by the \\"kibana-reporting\\" provisioned ILM policy. You must edit this policy to manage the report lifecycle. This change targets all indices prefixed with \\".reporting-*\\".",`
`69`		`- "title": "Found reporting indices with deprecated policy.",`
	`69`	`+ "title": "Found reporting indices managed by custom ILM policy.",`
`70`	`70`	`},`
`71`	`71`	`]`
`72`	`72`	`);
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ export const getDeprecationsInfo = async (`
`31`	`31`	`return [`
`32`	`32`	`{`
`33`	`33`	`title: i18n.translate('xpack.reporting.deprecations.migrateIndexIlmPolicyActionTitle', {`
`34`		`- defaultMessage: 'Found reporting indices with deprecated policy.',`
	`34`	`+ defaultMessage: 'Found reporting indices managed by custom ILM policy.',`
`35`	`35`	`}),`
`36`	`36`	`level: 'warning',`
`37`	`37`	`message: i18n.translate('xpack.reporting.deprecations.migrateIndexIlmPolicyActionMessage', {`