Redirect endpoint#103899
Redirect endpoint#103899streamich merged 30 commits intoelastic:masterfrom streamich:redirect-endpoint-3
Conversation
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
|
@elasticmachine merge upstream |
| throw error; | ||
| } | ||
|
|
||
| const { state: migratedParams } = migrateToLatest(locator.migrations, { |
There was a problem hiding this comment.
cc @stacey-gammon should we make migration happen internally inside navigate() ? one less thing that to worry about for the consumer, but not really. navigate would change and optionally accept version in. consumer would still need to make sure correct version is provided if the state is not of latest version. having to do them explicitly is kind of nice as you can check if anything changed in the state and warn the user about it.
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
* feat: 🎸 add redirect endpoint app * feat: 🎸 improve spinner design * feat: 🎸 implement basic version of redirect endpoint * feat: 🎸 render errors for user on the screen * feat: 🎸 improve error message display * feat: 🎸 improve error display * feat: 🎸 improve locator errors * feat: 🎸 improve errors * feat: 🎸 improve persistable state types * feat: 🎸 implement migrateToLatest function * feat: 🎸 migrate locator params to the latest in redirect endp * Update src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.ts * refactor: 💡 make Versioned state be an object * fix: 🐛 use new VersionedState interface in redirect endpoint * refactor: 💡 move parseSearchParams into a separate function * feat: 🎸 implement redirect URL formatter * feat: 🎸 export redirect URL parsing and formatting functions * refactor: 💡 use relative import * test: 💍 add example links through redirect endpoint * test: 💍 use updated VersionedState type * test: 💍 add redirect manager tests * feat: 🎸 add redirect endpoint app to common schema * chore: 🤖 update telemetry schema Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* feat: 🎸 add redirect endpoint app * feat: 🎸 improve spinner design * feat: 🎸 implement basic version of redirect endpoint * feat: 🎸 render errors for user on the screen * feat: 🎸 improve error message display * feat: 🎸 improve error display * feat: 🎸 improve locator errors * feat: 🎸 improve errors * feat: 🎸 improve persistable state types * feat: 🎸 implement migrateToLatest function * feat: 🎸 migrate locator params to the latest in redirect endp * Update src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.ts * refactor: 💡 make Versioned state be an object * fix: 🐛 use new VersionedState interface in redirect endpoint * refactor: 💡 move parseSearchParams into a separate function * feat: 🎸 implement redirect URL formatter * feat: 🎸 export redirect URL parsing and formatting functions * refactor: 💡 use relative import * test: 💍 add example links through redirect endpoint * test: 💍 use updated VersionedState type * test: 💍 add redirect manager tests * feat: 🎸 add redirect endpoint app to common schema * chore: 🤖 update telemetry schema Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Vadim Dalecky <streamich@gmail.com>
|
How do I test this pease? Thanks! |
Summary
Closes #98112
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers