Skip to content

[7.x] Redirect endpoint (#103899)#104412

Merged
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-103899
Jul 6, 2021
Merged

[7.x] Redirect endpoint (#103899)#104412
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-103899

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* feat: 🎸 add redirect endpoint app

* feat: 🎸 improve spinner design

* feat: 🎸 implement basic version of redirect endpoint

* feat: 🎸 render errors for user on the screen

* feat: 🎸 improve error message display

* feat: 🎸 improve error display

* feat: 🎸 improve locator errors

* feat: 🎸 improve errors

* feat: 🎸 improve persistable state types

* feat: 🎸 implement migrateToLatest function

* feat: 🎸 migrate locator params to the latest in redirect endp

* Update src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.ts

* refactor: 💡 make Versioned state be an object

* fix: 🐛 use new VersionedState interface in redirect endpoint

* refactor: 💡 move parseSearchParams into a separate function

* feat: 🎸 implement redirect URL formatter

* feat: 🎸 export redirect URL parsing and formatting functions

* refactor: 💡 use relative import

* test: 💍 add example links through redirect endpoint

* test: 💍 use updated VersionedState type

* test: 💍 add redirect manager tests

* feat: 🎸 add redirect endpoint app to common schema

* chore: 🤖 update telemetry schema

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Jul 6, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) July 6, 2021 11:04
@kibanamachine kibanamachine mentioned this pull request Jul 6, 2021
4 tasks
@kibanamachine
Copy link
Copy Markdown
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
kibanaUtils 191 236 +45
share 55 66 +11
total +56

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
kibanaUtils 365 356 -9
share 81 83 +2
total -7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
kibanaUtils 108.3KB 105.8KB -2.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
share 7 8 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaUtils 136.9KB 171.8KB +34.9KB
share 74.8KB 83.1KB +8.3KB
total +43.2KB
Unknown metric groups

API count

id before after diff
kibanaUtils 543 549 +6
share 119 123 +4
total +10

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @streamich

@kibanamachine kibanamachine merged commit 15302f5 into elastic:7.x Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants