[Deprecations service] add deprecationType and use it in configs deprecations#100983
Merged
Bamieh merged 6 commits intoelastic:masterfrom Jun 1, 2021
Merged
[Deprecations service] add deprecationType and use it in configs deprecations#100983Bamieh merged 6 commits intoelastic:masterfrom
deprecationType and use it in configs deprecations#100983Bamieh merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
pgayvallet
reviewed
May 31, 2021
Contributor
pgayvallet
left a comment
There was a problem hiding this comment.
Implementation looks fine. A few NITs and comment on the tests
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| /* eslint-disable dot-notation */ |
Contributor
Author
There was a problem hiding this comment.
I have a test suite #registerConfigDeprecationsInfo which is a private method
Contributor
There was a problem hiding this comment.
Method method = TargetClass.getDeclaredMethod(methodName, argClasses);
method.setAccessible(true);
method.invoke(targetObject, argObjects);
pgayvallet
approved these changes
Jun 1, 2021
Contributor
💚 Build SucceededMetrics [docs]Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ada a new field
deprecationType. The field is used to identify between different deprecation types. Example use case: in Upgrade Assistant, we may want to allow the user to sort by deprecation type or show each type in a separate tab.Current TS definition of the field:
The
deprecationTypevalues are predefined to reduce having similar definitions with different keywords across kibana deprecations. Allowing anystringto be used as adeprecationTypewould reduce the usefulness of this field.The new field is optional. UA might need to categorize deprecations with no
deprecationTypespecified to anuncategorizedgrouping.The field is optional to:
uncategorizedas a dedicated category but that would be almost identical to making the field optional.Changes
deprecationTypeto deprecations service external contractDeprecationsDetails.deprecationType: 'config'for configs deprecations.Closes #96060