add deprecationType and use it in configs deprecations

Bamieh · Bamieh · commit 3f1056d2a060 · 2021-05-31T11:35:20.000+03:00
diff --git a/src/core/server/deprecations/deprecations_service.ts b/src/core/server/deprecations/deprecations_service.ts
@@ -156,6 +156,7 @@ export class DeprecationsService implements CoreService<InternalDeprecationsServ
           return deprecationsContexts.map(({ message, correctiveActions, documentationUrl }) => {
             return {
               level: 'critical',
+              deprecationType: 'config',
               message,
               correctiveActions: correctiveActions ?? {},
               documentationUrl,
diff --git a/src/core/server/deprecations/types.ts b/src/core/server/deprecations/types.ts
@@ -25,6 +25,16 @@ export interface DeprecationsDetails {
    * - fetch_error: Deprecations service failed to grab the deprecation details for the domain.
    */
   level: 'warning' | 'critical' | 'fetch_error';
+  /**
+   * (optiional) Used to identify between different deprecation types.
+   * Example use case: in Upgrade Assistant, we may want to allow the user to sort by
+   * deprecation type or show each type in a separate tab.
+   *
+   * Feel free to add new types if necessary.
+   * Predefined types are necessary to reduce similar definitions with different keywords
+   * across all kibana deprecations.
+   */
+  deprecationType?: 'config' | 'feature';
   /* (optional) link to the documentation for more details on the deprecation. */
   documentationUrl?: string;
   /* corrective action needed to fix this deprecation. */
