Adding package changelogs by ycombinator · Pull Request #675 · elastic/integrations

ycombinator · 2021-02-08T21:17:24Z

What does this PR do?

This PR does the following:

Create initial skeleton changelog.yml files for every package.
Adds an item to the PR checklist that reminds package authors to add entries to their package's changelog.yml.

Related issues

Package CHANGELOGs package-spec#17

elasticmachine · 2021-02-08T21:47:08Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #675 updated
Start Time: 2021-02-17T16:28:55.452+0000
Duration: 43 min 50 sec
Commit: 560f58f

Test stats 🧪

Test	Results
Failed	0
Passed	1674
Skipped	3
Total	1677

Trends 🧪

ycombinator · 2021-02-16T19:05:44Z

packages/mysql/changelog.yml

+  changes:
+    - description: initial release
+      type: enhancement                # can be one of: enhancement, bugfix, breaking-change
+      link: TODO


Hey @mtojek, any chance you could help me track down the initial PR that introduced the mysql package?

In the package-registry: https://github.com/elastic/package-registry/pulls?q=is%3Apr+is%3Aclosed+MySQL+integration

(manual prepare: elastic/package-registry#323)

Ignoring in favor of #675 (comment).

ycombinator · 2021-02-16T19:08:37Z

packages/nginx/changelog.yml

+  changes:
+    - description: initial release
+      type: enhancement                # can be one of: enhancement, bugfix, breaking-change
+      link: TODO


Hey @mtojek, any chance you could help me track down the initial PR that introduced the nginx package?

In the package-registry: https://github.com/elastic/package-registry/pulls?q=is%3Apr+is%3Aclosed+nginx+integration+

I would vote for: elastic/package-registry#346

Ignoring in favor of #675 (comment).

ycombinator · 2021-02-16T19:19:58Z

packages/redis/changelog.yml

+  changes:
+    - description: initial release
+      type: enhancement                # can be one of: enhancement, bugfix, breaking-change
+      link: TODO


Hey @mtojek, any chance you could help me track down the initial PR that introduced the redis package?

Ah, thanks so much! I will use #21 as the link for the redis, mysql, nginx, system, and aws packages initial changelog entries.

Sorry I removed the post as I believe there might be something before, but let's stick to this: #21 :)

Actually, I left system alone as I found an even older PR that introduced the 0.0.3 version: #8.

elasticmachine · 2021-02-16T19:28:15Z

Pinging @elastic/integrations (Team:Integrations)

mtojek

If the CI is happy, I'm happy too :)

ycombinator · 2021-02-16T20:32:37Z

If the CI is happy, I'm happy too :)

Actually, now that this PR is ready, I will update elastic-package with the changes from elastic/package-spec#131 and then update this PR with the changes to elastic-package. Then let's see if CI is still happy on this PR. 🙂

ycombinator · 2021-02-17T01:04:54Z

I just added a commit to this PR to update the dependency on elastic-package: 44ffaed. This version of elastic-package will enforce changelog.yml files. So if CI goes green on this PR now, I will go ahead and merge it.

ycombinator · 2021-02-17T02:17:25Z

CI is failing on two system tests: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/PR-675/19/tests.

Re-running to see if this is a flaky failure: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/PR-675/20/tests.

Also re-running the master build so we can check if the failures are isolated to this PR: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/master/82/tests.

ycombinator · 2021-02-17T02:56:02Z

CI is failing on two system tests: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/PR-675/19/tests.

Re-running to see if this is a flaky failure: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/PR-675/20/tests.

The same two system tests failed again so this doesn't appear to be a flaky failure.

Also re-running the master build so we can check if the failures are isolated to this PR: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/master/82/tests.

All tests passed on this master build. So the failures are definitely related to this PR.

Will investigate both system test failures in this PR tomorrow.

mtojek · 2021-02-17T09:20:33Z

It looks really weird what happened here. I wonder if it's not due to other changes in elastic-package.

EDIT:

Fixes:
f676ead
112a6e7

Regarding the zoom integration I would consider it as temporary patch, although the docker-compose with akroh/stream runs with STREAM_INSECURE=true var (I think you can open a separate issue for zoom).

EDIT2:

I think that more packages came to master: #477

ycombinator · 2021-02-17T13:26:52Z

Thanks for the fixes, @mtojek! Any idea why these issues only came up with the newer version of elastic-package? Just curious what changed in elastic-package to expose these two problems that we weren't catching before. 🤔

And thanks for the heads up about #477. I will update this PR with changelog.yml files for those packages as well.

mtojek · 2021-02-17T13:41:57Z

I suppose that they're related with 7.12.0 bump. I don't have an idea if sth has been added to filebeat/metricbeat there.

ycombinator · 2021-02-17T14:07:31Z

Hmm, same test failures as before. Plus now we have 3 skipped tests too for the radware package. Investigating...

mtojek · 2021-02-17T14:08:39Z

Did you apply the suggested fixes for zoom and kubernetes? I don't see them here: https://github.com/elastic/integrations/pull/675/files

ycombinator · 2021-02-17T14:09:59Z

Did you apply the suggested fixes for zoom and kubernetes? I don't see them here: https://github.com/elastic/integrations/pull/675/files

I thought I did when I rebased this PR on master. Let me check...

mtojek · 2021-02-17T14:11:04Z

Sorry for the confusion, I didn't put them on master, but in a side branch (just to investigate problems with this PR). For reference: #703

ycombinator · 2021-02-17T14:13:42Z

Ah, sorry, I missed that. I will cherry-pick those commits over to this PR now, thanks!

mtojek · 2021-02-17T14:15:01Z

Ah, sorry, I missed that. I will cherry-pick those commits over to this PR now, thanks!

Most likely you will need some formatting as well.

mtojek · 2021-02-17T14:36:28Z

... and elastic-package build for Kubernetes.

ycombinator mentioned this pull request Feb 8, 2021

Package CHANGELOGs elastic/package-spec#17

Closed

8 tasks

ycombinator changed the title ~~Adding PR checklist item~~ Adding package changelogs Feb 8, 2021

andresrc added the Team:Integrations Label for the Integrations team label Feb 9, 2021

ycombinator force-pushed the pkg-changelogs branch from f95f714 to ec5cea2 Compare February 16, 2021 18:37

ycombinator commented Feb 16, 2021

View reviewed changes

ycombinator requested a review from mtojek February 16, 2021 19:28

ycombinator marked this pull request as ready for review February 16, 2021 19:28

mtojek approved these changes Feb 16, 2021

View reviewed changes

ycombinator force-pushed the pkg-changelogs branch from 44ffaed to 71bc36f Compare February 17, 2021 13:12

ycombinator added 6 commits February 17, 2021 06:11

Adding PR checklist item

da2165f

Adding initial changelog entry for apache package

cded13d

Adding initial changelog entry for auditd package

38dbf6c

Adding initial changelog entry for aws package

acab2c5

Adding initial changelog entry for azure package

ea7c471

Adding initial changelog entry for cef package

0803237

ycombinator added 18 commits February 17, 2021 06:11

Adding initial changelog entry for postgresql package

df84e5f

Adding initial changelog entry for prometheus package

968c348

Adding initial changelog entry for rabbitmq package

6e63424

Fixing links for cisco and netflow integrations

cbb97bb

Adding initial changelog entry for redis package

63cd140

Adding initial changelog entry for santa package

0aa0ee1

Adding initial changelog entry for stan package

58a9cd0

Adding initial changelog entry for suricata package

b476841

Adding initial changelog entry for system package

26856ab

Adding initial changelog entry for windows package

be57061

Adding initial changelog entry for zeek package

9504ea7

Adding initial changelog entry for zookeeper package

3df8fbe

Adding initial changelog entry for zoom package

30c3073

Updating links

16ec7e2

Formatting

ddb14a9

Updating dependency on elastic-package

7f349f8

Adding changelogs for new packages

3742021

More changelogs

3cffc5e

ycombinator force-pushed the pkg-changelogs branch from 618b978 to 3cffc5e Compare February 17, 2021 14:11

mtojek added 2 commits February 17, 2021 06:14

Fix: missing field in Kubernetes

1108a77

Fix: verification_mode none

ee8a4a0

Formatting

174165b

Running elastic-package build on all packages

0b5e199

mtojek mentioned this pull request Feb 17, 2021

Enable kubernetes service deployer #717

Merged

2 tasks

Forgot proofpoint

560f58f

ycombinator merged commit 2e49314 into elastic:master Feb 17, 2021

ycombinator deleted the pkg-changelogs branch February 17, 2021 17:45

Conversation

ycombinator commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Related issues

Uh oh!

elasticmachine commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

Trends 🧪

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Feb 16, 2021

Uh oh!

mtojek left a comment

Choose a reason for hiding this comment

Uh oh!

ycombinator commented Feb 16, 2021

Uh oh!

ycombinator commented Feb 17, 2021

Uh oh!

ycombinator commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ycombinator commented Feb 17, 2021

Uh oh!

mtojek commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ycombinator commented Feb 17, 2021

Uh oh!

mtojek commented Feb 17, 2021

Uh oh!

ycombinator commented Feb 17, 2021

Uh oh!

mtojek commented Feb 17, 2021

Uh oh!

ycombinator commented Feb 17, 2021

Uh oh!

mtojek commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ycombinator commented Feb 17, 2021

Uh oh!

mtojek commented Feb 17, 2021

Uh oh!

mtojek commented Feb 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ycombinator commented Feb 8, 2021 •

edited

Loading

elasticmachine commented Feb 8, 2021 •

edited

Loading

ycombinator commented Feb 17, 2021 •

edited

Loading

mtojek commented Feb 17, 2021 •

edited

Loading

mtojek commented Feb 17, 2021 •

edited

Loading