Skip to content

Move RSA packages from package-storage to integrations#477

Merged
adriansr merged 57 commits intoelastic:masterfrom
adriansr:move_rsa_packages_to_integrations
Feb 17, 2021
Merged

Move RSA packages from package-storage to integrations#477
adriansr merged 57 commits intoelastic:masterfrom
adriansr:move_rsa_packages_to_integrations

Conversation

@adriansr
Copy link
Copy Markdown
Contributor

@adriansr adriansr commented Dec 18, 2020

What does this PR do?

Moves the new version of RSA packages into this repository to avoid maintaining two separate repositories for some packages.

Until now only the packages that had non-RSA filesets existed in integrations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Comment on lines +13 to +14
entrypoint: /bin/bash
command: -c "/stream log --start-signal=SIGHUP --delay=5s --addr elastic-agent:9540 -p=udp /sample_logs/barracuda-spamfirewall-*.log"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here overriding the entrypoint is necessary to have globs working in the arguments.

I need this because the tests are autogenerated and it's not easy to list all the test files that are going to be there when the template is applied.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been wanted to have stream expand the glob too. I just created https://github.com/andrewkroh/stream/issues/8.

@adriansr adriansr requested a review from andrewkroh February 16, 2021 20:07
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at one and it LGTM.

Comment on lines +13 to +14
entrypoint: /bin/bash
command: -c "/stream log --start-signal=SIGHUP --delay=5s --addr elastic-agent:9540 -p=udp /sample_logs/barracuda-spamfirewall-*.log"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been wanted to have stream expand the glob too. I just created https://github.com/andrewkroh/stream/issues/8.

- ${SERVICE_LOGS_DIR}:/var/log
command: /bin/sh -c "cp /sample_logs/* /var/log/"
barracuda-spamfirewall-udp:
image: akroh/stream:v0.0.1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a v0.2.0 now. https://github.com/andrewkroh/stream/blob/main/CHANGELOG.md

None of the changes affect log streaming so it doesn't matter if you update.

@adriansr
Copy link
Copy Markdown
Contributor Author

run tests

@adriansr adriansr merged commit f99e924 into elastic:master Feb 17, 2021
@adriansr adriansr deleted the move_rsa_packages_to_integrations branch February 17, 2021 10:10
@mtojek mtojek mentioned this pull request Feb 17, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants