Skip to content

Add missing internal packagees#8

Merged
mtojek merged 1 commit intoelastic:masterfrom
mtojek:missing-internal-packages
May 6, 2020
Merged

Add missing internal packagees#8
mtojek merged 1 commit intoelastic:masterfrom
mtojek:missing-internal-packages

Conversation

@mtojek
Copy link
Copy Markdown
Contributor

@mtojek mtojek commented May 6, 2020

This PR adds missing but mandatory internal packages.

@mtojek mtojek requested a review from ruflin May 6, 2020 12:20
@mtojek mtojek self-assigned this May 6, 2020
@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented May 6, 2020

I'm ok to add these here for now at the same time I don't think they belong here. In the future they should be pulled in from a remote source during build time to only have a single point of truth.

@mtojek
Copy link
Copy Markdown
Contributor Author

mtojek commented May 6, 2020

I'm ok to add these here for now at the same time I don't think they belong here. In the future they should be pulled in from a remote source during build time to only have a single point of truth.

I can adjust it in the follow-ups. Could you please link me to the right location (source of truth)?

EDIT: ... or I can copy them from EPR repository.

@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented May 6, 2020

Today, EPR is the source of truth. In the near future it should be package-storage.

@mtojek
Copy link
Copy Markdown
Contributor Author

mtojek commented May 6, 2020

@ruflin

  1. Would you prefer to approve this as is and let me adjust in next follow-ups or it's better to do now?
  2. Which way do you think is better? git clone the package-registory (package-store in the future), fetch data from https://epr.elastic.co/, extract from docker image. I need to simply mount a volume with custom package. If I need to update the package, I don't have to rebuild/restart docker containers.

Copy link
Copy Markdown
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get it in and we iterate.

@mtojek mtojek merged commit 9095b76 into elastic:master May 6, 2020
@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented May 7, 2020

For the future, I think the best path is to get it out of the package-storage. Like this you have what is currently deployed + your packages on top of it.

@mtojek
Copy link
Copy Markdown
Contributor Author

mtojek commented May 7, 2020

For the future, I think the best path is to get it out of the package-storage. Like this you have what is currently deployed + your packages on top of it.

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants