Remove invalid ips used in tests#3410
Conversation
|
Will wait for elastic/elastic-package#826, to have more available ipv6 addresses, and to solve issues with addresses with leading zeroes. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
b7d3c53 to
81e66fb
Compare
|
Pending validation of IPv6 address will be fixed by elastic/elastic-package#826, opening this for review. |
efd6
left a comment
There was a problem hiding this comment.
Where there are a number of IPv6 addresses in IP arrays and they are distinct and not in the first position (so not tagged as not-allowed under the current testing) I'd suggest to keep the distinctness so that they can be used to test fixes for allow_duplicates: false. This can be done with no loss of information by using RFC 4193 private IPs for those replacements.
...ages/aws/data_stream/route53_resolver_logs/_dev/test/pipeline/test-route53.log-expected.json
Outdated
Show resolved
Hide resolved
...ages/aws/data_stream/route53_resolver_logs/_dev/test/pipeline/test-route53.log-expected.json
Outdated
Show resolved
Hide resolved
|
@efd6 thanks for the review! I will wait then for elastic/elastic-package#826 so we can have different ipv6 addresses, and address your comments. |
|
Open for review. @efd6 it'd be great if you could give it another look. Thanks! |
What does this PR do?
elastic-package only allows the use of IPs that have geoip data in the included geoip database (see elastic/elastic-package#605).
Fields validation is only done with the first element when the field contains an array. In elastic/elastic-package#771 we are introducing the check for all elements in the array, what will make these packages to fail.
There are IPs in arrays that are not allowed by this check. Replace them.
Related issues