Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
mtojek
left a comment
There was a problem hiding this comment.
It looks like a good PR, but I'm concerned about system tests. See the test output:
one or more errors found in documents stored in metrics-aws.ec2_metrics-ep data stream: [0] parsing field value failed: the IP "3.84.55.9" is not one of the allowed test IPs
mtojek
left a comment
There was a problem hiding this comment.
I think the only one left thing is adjusting pipeline tests?
|
I think you have to update pipeline tests for the AWS test package. |
|
/test |
5c1a6d2 to
c96514e
Compare
| func initializeAllowedIPsList() map[string]struct{} { | ||
| m := map[string]struct{}{ | ||
| "0.0.0.0": {}, "255.255.255.255": {}, | ||
| "0:0:0:0:0:0:0:0": {}, "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff": {}, |
There was a problem hiding this comment.
If this testing takes output from the net package, this should also probably have "::" since an IPv6 address renders as the abbreviation.
| } | ||
|
|
||
| if v.enabledAllowedIPCheck && !v.isAllowedIPValue(valStr) { | ||
| return fmt.Errorf("the IP %q is not one of the allowed test IPs", valStr) |
There was a problem hiding this comment.
It would be nice if this emitted a link to the list of acceptable IPs.
To identify any IP in the testing value that is not in the supported Maxmind's allowed set (found here https://github.com/elastic/elastic-package/blob/master/docs/howto/ingest_geoip.md) a validation check is added at test time.
Will output something similar to