Use CIDRs to decide allowed IPs for testing#826
Merged
jsoriano merged 2 commits intoelastic:mainfrom May 24, 2022
Merged
Conversation
This fixes validation of IPv6 addresses, their string representation may vary depending on leading zeroes or abbreviated addresses. It also extends the number of IP addresses that can be used for testing, specially IPv6 addresses.
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Collaborator
🌐 Coverage report
|
mtojek
approved these changes
May 24, 2022
This was referenced May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes validation of IPv6 addresses, their string representation may
vary depending on leading zeroes or abbreviated addresses.
2a02:cf40:0add:4002:91f2:a9b2:e09a:6fc6was not being accepted evenwhen it is one of the addresses in the list. Seen in https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations%2FPR-3410/detail/PR-3410/1/tests.
It also extends the number of IP addresses that can be used for testing,
specially IPv6 addresses.