Skip to content

bk: use a buildkite plugin and be declarative#14408

Merged
v1v merged 2 commits intoelastic:mainfrom
v1v:feature/use-bk-plugin-vault-gh-token
Jul 3, 2025
Merged

bk: use a buildkite plugin and be declarative#14408
v1v merged 2 commits intoelastic:mainfrom
v1v:feature/use-bk-plugin-vault-gh-token

Conversation

@v1v
Copy link
Member

@v1v v1v commented Jul 2, 2025

Proposed commit message

Use https://github.com/elastic/vault-github-token-buildkite-plugin instead of using pre-command hooks with complicated conditions.
This helps to know what Buildkite step uses VAULT_GITHUB_TOKEN and self-document those sensitive details as it's a declarative syntax.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

NA - only in the CI

Related issues

Screenshots

@v1v v1v self-assigned this Jul 2, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 2, 2025

🚀 Benchmarks report

Package azure 👍(6) 💚(2) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
signinlogs 2369.67 1930.5 -439.17 (-18.53%) 💔
application_gateway 2994.01 2463.05 -530.96 (-17.73%) 💔
identity_protection 3484.32 2785.52 -698.8 (-20.06%) 💔

Package microsoft_sqlserver 👍(0) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 12500 5208.33 -7291.67 (-58.33%) 💔

To see the full report comment with /test benchmark fullreport

image: "${LINUX_AGENT_IMAGE}"
cpu: "8"
memory: "4G"
plugins:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v1v v1v marked this pull request as ready for review July 3, 2025 13:05
@v1v v1v requested a review from a team as a code owner July 3, 2025 13:05
@v1v v1v requested review from a team July 3, 2025 13:05
Copy link
Collaborator

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It needs to be checked once this is merged, that the next builds of the CI daily jobs are able to create new GitHub issues for the failing tests.

The other pipeline that requires this token is the one creating the backport branches, and it has been tested here:
https://buildkite.com/elastic/integrations-backport/builds/185#0197d091-6c01-4a51-b05b-eec85c2ea8ce

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @v1v

@v1v v1v merged commit afcda7a into elastic:main Jul 3, 2025
7 checks passed
@v1v
Copy link
Member Author

v1v commented Jul 3, 2025

@Mergifyio backport backport-security_detection_engine-8.18 backport-cloud_security_posture-1.13 backport-crowdstrike-1.52

@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2025

backport backport-security_detection_engine-8.18 backport-cloud_security_posture-1.13 backport-crowdstrike-1.52

✅ Backports have been created

Details

@v1v
Copy link
Member Author

v1v commented Jul 4, 2025

@Mergifyio backport backport-security_detection_engine-8.18

@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2025

backport backport-security_detection_engine-8.18

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jul 4, 2025
(cherry picked from commit afcda7a)

# Conflicts:
#	.buildkite/pipeline.backport.yml
@v1v
Copy link
Member Author

v1v commented Jul 4, 2025

@Mergifyio backport backport-cloud_security_posture-1.13 backport-crowdstrike-1.52

mergify bot pushed a commit that referenced this pull request Jul 4, 2025
(cherry picked from commit afcda7a)

# Conflicts:
#	.buildkite/pipeline.backport.yml
mergify bot pushed a commit that referenced this pull request Jul 4, 2025
(cherry picked from commit afcda7a)

# Conflicts:
#	.buildkite/pipeline.backport.yml
@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2025

backport backport-cloud_security_posture-1.13 backport-crowdstrike-1.52

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jul 4, 2025
(cherry picked from commit afcda7a)

# Conflicts:
#	.buildkite/pipeline.backport.yml
mergify bot pushed a commit that referenced this pull request Jul 4, 2025
(cherry picked from commit afcda7a)

# Conflicts:
#	.buildkite/pipeline.backport.yml
v1v pushed a commit that referenced this pull request Jul 4, 2025
v1v pushed a commit that referenced this pull request Jul 4, 2025
v1v pushed a commit that referenced this pull request Jul 7, 2025
robester0403 pushed a commit to robester0403/integrations that referenced this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants