bk: use a buildkite plugin and be declarative#14408
Conversation
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
signinlogs |
2369.67 | 1930.5 | -439.17 (-18.53%) | 💔 |
application_gateway |
2994.01 | 2463.05 | -530.96 (-17.73%) | 💔 |
identity_protection |
3484.32 | 2785.52 | -698.8 (-20.06%) | 💔 |
Package microsoft_sqlserver 👍(0) 💚(2) 💔(1)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
log |
12500 | 5208.33 | -7291.67 (-58.33%) | 💔 |
To see the full report comment with /test benchmark fullreport
| image: "${LINUX_AGENT_IMAGE}" | ||
| cpu: "8" | ||
| memory: "4G" | ||
| plugins: |
There was a problem hiding this comment.
mrodm
left a comment
There was a problem hiding this comment.
LGTM
It needs to be checked once this is merged, that the next builds of the CI daily jobs are able to create new GitHub issues for the failing tests.
The other pipeline that requires this token is the one creating the backport branches, and it has been tested here:
https://buildkite.com/elastic/integrations-backport/builds/185#0197d091-6c01-4a51-b05b-eec85c2ea8ce
|
💚 Build Succeeded
History
cc @v1v |
|
@Mergifyio backport backport-security_detection_engine-8.18 backport-cloud_security_posture-1.13 backport-crowdstrike-1.52 |
✅ Backports have been createdDetails
|
|
@Mergifyio backport backport-security_detection_engine-8.18 |
✅ Backports have been createdDetails
|
(cherry picked from commit afcda7a) # Conflicts: # .buildkite/pipeline.backport.yml
|
@Mergifyio backport backport-cloud_security_posture-1.13 backport-crowdstrike-1.52 |
(cherry picked from commit afcda7a) # Conflicts: # .buildkite/pipeline.backport.yml
(cherry picked from commit afcda7a) # Conflicts: # .buildkite/pipeline.backport.yml
✅ Backports have been createdDetails
|
(cherry picked from commit afcda7a) # Conflicts: # .buildkite/pipeline.backport.yml
(cherry picked from commit afcda7a) # Conflicts: # .buildkite/pipeline.backport.yml
…ildkite plugin and be declarative (#14420)
… buildkite plugin and be declarative (#14419)






Proposed commit message
Use https://github.com/elastic/vault-github-token-buildkite-plugin instead of using pre-command hooks with complicated conditions.
This helps to know what Buildkite step uses
VAULT_GITHUB_TOKENand self-document those sensitive details as it's a declarative syntax.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
NA - only in the CI
Related issues
Screenshots