Skip to content

[backport-crowdstrike-1.52] (backport #14408) bk: use a buildkite plugin and be declarative#14421

Merged
v1v merged 2 commits intobackport-crowdstrike-1.52from
mergify/bp/backport-crowdstrike-1.52/pr-14408
Jul 4, 2025
Merged

[backport-crowdstrike-1.52] (backport #14408) bk: use a buildkite plugin and be declarative#14421
v1v merged 2 commits intobackport-crowdstrike-1.52from
mergify/bp/backport-crowdstrike-1.52/pr-14408

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jul 4, 2025

Proposed commit message

Use https://github.com/elastic/vault-github-token-buildkite-plugin instead of using pre-command hooks with complicated conditions.
This helps to know what Buildkite step uses VAULT_GITHUB_TOKEN and self-document those sensitive details as it's a declarative syntax.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

NA - only in the CI

Related issues

Screenshots

This is an automatic backport of pull request #14408 done by [Mergify](https://mergify.com).

@v1v @mergify
bk: use a buildkite plugin and be declarative (#14408)
332b7f5 
(cherry picked from commit afcda7a)

# Conflicts:
#	.buildkite/pipeline.backport.yml
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jul 4, 2025
@mergify mergify bot requested a review from a team as a code owner July 4, 2025 09:13
@mergify mergify bot assigned v1v Jul 4, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Jul 4, 2025

Cherry-pick of afcda7a has failed:

On branch mergify/bp/backport-crowdstrike-1.52/pr-14408
Your branch is up to date with 'origin/backport-crowdstrike-1.52'.

You are currently cherry-picking commit afcda7a7a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .buildkite/hooks/pre-command
	modified:   .buildkite/pipeline.serverless.yml
	modified:   .buildkite/pipeline.yml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .buildkite/pipeline.backport.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Jul 4, 2025
Merged
5 tasks
v1v
v1v reviewed Jul 4, 2025
View reviewed changes
@v1v v1v removed the conflicts There is a conflict in the backported pull request label Jul 4, 2025
@elasticmachine
Copy link

elasticmachine commented Jul 4, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @v1v

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 4, 2025

🚀 Benchmarks report

Package azure_network_watcher_nsg 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 1531.39 1210.65 -320.74 (-20.94%) 💔

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Jul 4, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@v1v v1v merged commit cd2b702 into backport-crowdstrike-1.52 Jul 4, 2025
5 of 6 checks passed
@v1v v1v deleted the mergify/bp/backport-crowdstrike-1.52/pr-14408 branch July 4, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v1v v1v v1v left review comments

@mrodm mrodm mrodm approved these changes

Assignees

@v1v v1v

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elasticmachine @v1v @mrodm