Skip to content

cloudflare_logpush.gateway_http: Fix duplicate key number_of_workers#14270

Merged
kcreddy merged 2 commits intoelastic:mainfrom
kcreddy:cloudflare_logpush-fix-aws-s3
Jun 20, 2025
Merged

cloudflare_logpush.gateway_http: Fix duplicate key number_of_workers#14270
kcreddy merged 2 commits intoelastic:mainfrom
kcreddy:cloudflare_logpush-fix-aws-s3

Conversation

@kcreddy
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy commented Jun 19, 2025

Proposed commit message

#13346 introduced a bug inside gateway_http data stream which allows 
input config to have a duplicate of number_of_workers since it was not
removed from the S3 options logic.

Fix this by removing number_of_workers dependency on S3 bucket collection 
being enabled, similar to other data streams in #13346.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Screenshots

Before
Screenshot 2025-06-19 at 9 42 49 PM

After
Screenshot 2025-06-19 at 9 46 02 PM

@kcreddy kcreddy marked this pull request as ready for review June 19, 2025 16:33
@kcreddy kcreddy requested a review from a team as a code owner June 19, 2025 16:33
@kcreddy kcreddy self-assigned this Jun 19, 2025
@kcreddy kcreddy added Integration:cloudflare_logpush Cloudflare Logpush bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jun 19, 2025
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube
Copy link
Copy Markdown

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

cc @kcreddy

Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify the commit message? Suggest something like

#13346 introduced a bug inside gateway_http data stream which allows 
input config to have a duplicate of number_of_workers since it was not
removed from the S3 options logic.

Fix this by removing number_of_workers dependency on S3 bucket collection 
being enabled, similar to other data streams in #13346.

@kcreddy kcreddy merged commit 6cb68ed into elastic:main Jun 20, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package cloudflare_logpush - 1.38.3 containing this change is available at https://epr.elastic.co/package/cloudflare_logpush/1.38.3/

shmsr pushed a commit to shmsr/integrations that referenced this pull request Jun 30, 2025
elastic#14270)

elastic#13346 introduced a bug inside gateway_http data stream which allows 
input config to have a duplicate of number_of_workers since it was not
removed from the S3 options logic.

Fix this by removing number_of_workers dependency on S3 bucket collection 
being enabled, similar to other data streams in elastic#13346.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cloudflare_logpush Cloudflare Logpush Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants