Cloudflare Logpush - fix SQS worker setting#13346
Merged
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
3 tasks
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
network_analytics |
3095.98 | 2450.98 | -645 (-20.83%) | 💔 |
access_request |
3663 | 2724.8 | -938.2 (-25.61%) | 💔 |
audit |
7874.02 | 4405.29 | -3468.73 (-44.05%) | 💔 |
device_posture |
6993.01 | 5813.95 | -1179.06 (-16.86%) | 💔 |
dns |
14705.88 | 11764.71 | -2941.17 (-20%) | 💔 |
firewall_event |
3154.57 | 2314.81 | -839.76 (-26.62%) | 💔 |
gateway_dns |
5181.35 | 3906.25 | -1275.1 (-24.61%) | 💔 |
To see the full report comment with /test benchmark fullreport
efd6
reviewed
Mar 30, 2025
packages/cloudflare_logpush/data_stream/access_request/manifest.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
…t.yml Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
andrewkroh
reviewed
Apr 1, 2025
packages/cloudflare_logpush/data_stream/device_posture/manifest.yml
Outdated
Show resolved
Hide resolved
packages/cloudflare_logpush/data_stream/dns_firewall/manifest.yml
Outdated
Show resolved
Hide resolved
packages/cloudflare_logpush/data_stream/network_analytics/manifest.yml
Outdated
Show resolved
Hide resolved
packages/cloudflare_logpush/data_stream/network_session/manifest.yml
Outdated
Show resolved
Hide resolved
packages/cloudflare_logpush/data_stream/sinkhole_http/manifest.yml
Outdated
Show resolved
Hide resolved
packages/cloudflare_logpush/data_stream/spectrum_event/manifest.yml
Outdated
Show resolved
Hide resolved
packages/cloudflare_logpush/data_stream/workers_trace/manifest.yml
Outdated
Show resolved
Hide resolved
3 tasks
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
andrewkroh
approved these changes
Apr 1, 2025
💚 Build Succeeded
History
|
|
|
Package cloudflare_logpush - 1.35.2 containing this change is available at https://epr.elastic.co/package/cloudflare_logpush/1.35.2/ |
flexitrev
added a commit
that referenced
this pull request
Apr 3, 2025
kcreddy
added a commit
that referenced
this pull request
Jun 20, 2025
#14270) #13346 introduced a bug inside gateway_http data stream which allows input config to have a duplicate of number_of_workers since it was not removed from the S3 options logic. Fix this by removing number_of_workers dependency on S3 bucket collection being enabled, similar to other data streams in #13346.
shmsr
pushed a commit
to shmsr/integrations
that referenced
this pull request
Jun 30, 2025
elastic#14270) elastic#13346 introduced a bug inside gateway_http data stream which allows input config to have a duplicate of number_of_workers since it was not removed from the S3 options logic. Fix this by removing number_of_workers dependency on S3 bucket collection being enabled, similar to other data streams in elastic#13346.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Fixes number_of_workers setting so it is not dependent on S3 bucket collection being enabled
Checklist
changelog.ymlfile.How to test this PR locally
Modify number of worker settings on previous version of the integration without enabling S3 bucket selection.
Download policy
Observe that default number of workers is still present or not present at all, relying on aws-s3 input defaults
Modify number of worker settings on this version of the integration without enabling S3 bucket selection.
Download policy
Observe that default number of workers is the value of user input
Related issues
Screenshots