Skip to content

[forgerock] Map forgerock.response.elapsedTime as a long not a date#13959

Merged
chrisberkhout merged 3 commits intoelastic:mainfrom
chrisberkhout:forgerock-duration-as-long
May 22, 2025
Merged

[forgerock] Map forgerock.response.elapsedTime as a long not a date#13959
chrisberkhout merged 3 commits intoelastic:mainfrom
chrisberkhout:forgerock-duration-as-long

Conversation

@chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented May 21, 2025

Proposed commit message

[forgerock] Map `forgerock.response.elapsedTime` as a long not a date (#)

The field represents a duration, not a point in time.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@chrisberkhout chrisberkhout self-assigned this May 21, 2025
@chrisberkhout chrisberkhout requested a review from a team as a code owner May 21, 2025 12:50
@chrisberkhout chrisberkhout added bugfix Pull request that fixes a bug issue Integration:forgerock ForgeRock Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels May 21, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented May 21, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

field: event.duration
copy_from: forgerock.response.elapsedTime
ignore_empty_value: true
- script:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

milliseconds to nanoseconds conversion logic

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit then LGTM

@chrisberkhout chrisberkhout changed the title [forgerock] Map the duration elaspsedTime as a long not a date [forgerock] Map the duration forgerock.response.elapsedTime as a long not a date May 22, 2025
@chrisberkhout chrisberkhout changed the title [forgerock] Map the duration forgerock.response.elapsedTime as a long not a date [forgerock] Map forgerock.response.elapsedTime as a long not a date May 22, 2025
@chrisberkhout chrisberkhout force-pushed the forgerock-duration-as-long branch from 377daaa to 68c3bd2 Compare May 22, 2025 07:22
@chrisberkhout chrisberkhout requested a review from efd6 May 22, 2025 07:24
@chrisberkhout chrisberkhout force-pushed the forgerock-duration-as-long branch from 68c3bd2 to a98a8f5 Compare May 22, 2025 15:10
@chrisberkhout chrisberkhout enabled auto-merge (squash) May 22, 2025 15:10
@elastic-sonarqube
Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chrisberkhout

@chrisberkhout chrisberkhout merged commit 51e8e49 into elastic:main May 22, 2025
8 checks passed
@elastic-vault-github-plugin-prod

Package forgerock - 1.21.1 containing this change is available at https://epr.elastic.co/package/forgerock/1.21.1/

v1v added a commit to v1v/integrations that referenced this pull request May 26, 2025
* main: (42 commits)
  [jamf_pro] Fix `flattened` field types for non-object values (elastic#13985)
  [Netskope Alerts] Add text multi-field to netskope.alerts.breach.description field (elastic#13977)
  zscaler_zia: add strict field template mode for tcp and http_endpoint input data streams (elastic#13904)
  apm: Add config for tail-based sampling discard on write (elastic#13950)
  [CI] Add dev/coverage into backport script (elastic#13987)
  Update configuration updatecli for 8.x snapshot (elastic#13981)
  [Prometheus] Add username, password, and SSL related fields for query dataset (elastic#13969)
  o365: Ignore failures in rename processors for organization fields (elastic#13983)
  aws.firewall: Document ingested log types of AWS Network Firewall (elastic#13978)
  mimecast: resolve field data type conflicts between data streams (elastic#13825)
  [Infoblox NIOS] Handle the parsing of IPv6 address (elastic#13947)
  [Cribl] Fix handling of metric event type (elastic#13930)
  zscaler_zpa: fix handling of multiple remote IPs, and event categorisation (elastic#13755)
  Adding agentless deployment to the sublime security integration (elastic#13963)
  [integration/system] add use_performance_counters in system integration (elastic#13150)
  crowdstrike,m365_defender,microsoft_defender_{cloud,endpoint},sentinel_one: normalise severity handling (elastic#13955)
  [forgerock] Map `forgerock.response.elapsedTime` as a long not a date (elastic#13959)
  github: squelch errors from pagination ends (elastic#13965)
  cisco_secure_endpoint: squelch errors from pagination ends (elastic#13964)
  [Cloud Security] Cloud Asset Inventory:  fixed cloud formation URL (elastic#13971)
  ...
v1v added a commit that referenced this pull request May 26, 2025
* feature/use-google-secrets: (43 commits)
  use -ci account
  [jamf_pro] Fix `flattened` field types for non-object values (#13985)
  [Netskope Alerts] Add text multi-field to netskope.alerts.breach.description field (#13977)
  zscaler_zia: add strict field template mode for tcp and http_endpoint input data streams (#13904)
  apm: Add config for tail-based sampling discard on write (#13950)
  [CI] Add dev/coverage into backport script (#13987)
  Update configuration updatecli for 8.x snapshot (#13981)
  [Prometheus] Add username, password, and SSL related fields for query dataset (#13969)
  o365: Ignore failures in rename processors for organization fields (#13983)
  aws.firewall: Document ingested log types of AWS Network Firewall (#13978)
  mimecast: resolve field data type conflicts between data streams (#13825)
  [Infoblox NIOS] Handle the parsing of IPv6 address (#13947)
  [Cribl] Fix handling of metric event type (#13930)
  zscaler_zpa: fix handling of multiple remote IPs, and event categorisation (#13755)
  Adding agentless deployment to the sublime security integration (#13963)
  [integration/system] add use_performance_counters in system integration (#13150)
  crowdstrike,m365_defender,microsoft_defender_{cloud,endpoint},sentinel_one: normalise severity handling (#13955)
  [forgerock] Map `forgerock.response.elapsedTime` as a long not a date (#13959)
  github: squelch errors from pagination ends (#13965)
  cisco_secure_endpoint: squelch errors from pagination ends (#13964)
  ...
anupratharamachandran pushed a commit to anupratharamachandran/integrations that referenced this pull request Jun 2, 2025
…elastic#13959)

The field represents a duration, not a point in time.

---------

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:forgerock ForgeRock Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants