[Infoblox NIOS] Handle the parsing of IPv6 address#13947
Merged
efd6 merged 4 commits intoelastic:mainfrom May 23, 2025
Merged
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
efd6
reviewed
May 20, 2025
Comment on lines
+123
to
+129
| if (ip.charAt(i) == (char)92) { | ||
| output.append(':'); | ||
| i += 4; | ||
| } else { | ||
| output.append(ip.charAt(i)); | ||
| i++; | ||
| } |
Contributor
There was a problem hiding this comment.
I don't think this is correct (though it does reflect what I wrote — sorry); it only handles the case that the octal encoding is directly encoding the colon (0o072), but this is not the case in the failing sample that was provided in the issue, 2001\063210\063210\0653\061\07123.
If that encoding is included in the tests, we get an IP of 2001:210:210:3::23, but I think we should be getting something that reflects the values that are octal encoded, which we don't. However, if I try to do that (https://go.dev/play/p/QwfsMKbHiY5), it fails because the last octal encoding specifies a 9, which leaves us with invalid IPv6 syntax (if I replace the \071 with \072 it is correct).
I think we should take this back to the issue and clarify the situation.
| StringBuilder output = new StringBuilder(); | ||
| int i = 0; | ||
| while (i < ip.length()) { | ||
| if (ip.charAt(i) == (char)92) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (ip.charAt(i) == (char)92) { | |
| if (ip.charAt(i) == (char)'\\') { |
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
efd6
reviewed
May 22, 2025
packages/infoblox_nios/data_stream/log/_dev/test/pipeline/test-audit.log
Show resolved
Hide resolved
|
💚 Build Succeeded
History
|
|
Package infoblox_nios - 1.29.1 containing this change is available at https://epr.elastic.co/package/infoblox_nios/1.29.1/ |
v1v
added a commit
to v1v/integrations
that referenced
this pull request
May 26, 2025
* main: (42 commits) [jamf_pro] Fix `flattened` field types for non-object values (elastic#13985) [Netskope Alerts] Add text multi-field to netskope.alerts.breach.description field (elastic#13977) zscaler_zia: add strict field template mode for tcp and http_endpoint input data streams (elastic#13904) apm: Add config for tail-based sampling discard on write (elastic#13950) [CI] Add dev/coverage into backport script (elastic#13987) Update configuration updatecli for 8.x snapshot (elastic#13981) [Prometheus] Add username, password, and SSL related fields for query dataset (elastic#13969) o365: Ignore failures in rename processors for organization fields (elastic#13983) aws.firewall: Document ingested log types of AWS Network Firewall (elastic#13978) mimecast: resolve field data type conflicts between data streams (elastic#13825) [Infoblox NIOS] Handle the parsing of IPv6 address (elastic#13947) [Cribl] Fix handling of metric event type (elastic#13930) zscaler_zpa: fix handling of multiple remote IPs, and event categorisation (elastic#13755) Adding agentless deployment to the sublime security integration (elastic#13963) [integration/system] add use_performance_counters in system integration (elastic#13150) crowdstrike,m365_defender,microsoft_defender_{cloud,endpoint},sentinel_one: normalise severity handling (elastic#13955) [forgerock] Map `forgerock.response.elapsedTime` as a long not a date (elastic#13959) github: squelch errors from pagination ends (elastic#13965) cisco_secure_endpoint: squelch errors from pagination ends (elastic#13964) [Cloud Security] Cloud Asset Inventory: fixed cloud formation URL (elastic#13971) ...
v1v
added a commit
that referenced
this pull request
May 26, 2025
* feature/use-google-secrets: (43 commits) use -ci account [jamf_pro] Fix `flattened` field types for non-object values (#13985) [Netskope Alerts] Add text multi-field to netskope.alerts.breach.description field (#13977) zscaler_zia: add strict field template mode for tcp and http_endpoint input data streams (#13904) apm: Add config for tail-based sampling discard on write (#13950) [CI] Add dev/coverage into backport script (#13987) Update configuration updatecli for 8.x snapshot (#13981) [Prometheus] Add username, password, and SSL related fields for query dataset (#13969) o365: Ignore failures in rename processors for organization fields (#13983) aws.firewall: Document ingested log types of AWS Network Firewall (#13978) mimecast: resolve field data type conflicts between data streams (#13825) [Infoblox NIOS] Handle the parsing of IPv6 address (#13947) [Cribl] Fix handling of metric event type (#13930) zscaler_zpa: fix handling of multiple remote IPs, and event categorisation (#13755) Adding agentless deployment to the sublime security integration (#13963) [integration/system] add use_performance_counters in system integration (#13150) crowdstrike,m365_defender,microsoft_defender_{cloud,endpoint},sentinel_one: normalise severity handling (#13955) [forgerock] Map `forgerock.response.elapsedTime` as a long not a date (#13959) github: squelch errors from pagination ends (#13965) cisco_secure_endpoint: squelch errors from pagination ends (#13964) ...
anupratharamachandran
pushed a commit
to anupratharamachandran/integrations
that referenced
this pull request
Jun 2, 2025
The convert processor failed to parse IPv6 addresses with octal encoding. So a script processor has been added to parse the octal-encoded IPv6 address before applying the convert processor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues