Skip to content

aws: ignore long cloudtrail.{request_parameters,response_elements} fields#12755

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:10818-aws
Feb 18, 2025
Merged

aws: ignore long cloudtrail.{request_parameters,response_elements} fields#12755
efd6 merged 1 commit intoelastic:mainfrom
efd6:10818-aws

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Feb 12, 2025

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:aws AWS Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Feb 12, 2025
@efd6 efd6 self-assigned this Feb 12, 2025
@efd6 efd6 force-pushed the 10818-aws branch 2 times, most recently from c342133 to b6e7f17 Compare February 12, 2025 21:06
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Feb 12, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review February 12, 2025 22:52
@efd6 efd6 requested review from a team as code owners February 12, 2025 22:53
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 12, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

kcreddy
kcreddy approved these changes Feb 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just for clarification, I believe we are completely ignoring instead of partially capturing it like #11982 because we already have a multi_field .text that is searchable?

@efd6 efd6 enabled auto-merge (squash) February 18, 2025 00:32
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 18, 2025

💚 Build Succeeded

History

  • 💚 Build #22221 succeeded b6e7f1767a01fd3d5187374f10061534044a1491

cc @efd6

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Feb 18, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@efd6 efd6 added Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] labels Feb 18, 2025
@efd6 efd6 merged commit c16baef into elastic:main Feb 18, 2025
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Feb 18, 2025

Package aws - 2.41.0 containing this change is available at https://epr.elastic.co/package/aws/2.41.0/

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
@efd6 @flexitrev
aws: ignore long cloudtrail.{request_parameters,response_elements} fi…
c44aa73 
…elds (#12755)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcreddy kcreddy kcreddy approved these changes

@ritalwar ritalwar ritalwar approved these changes

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:aws AWS Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@efd6 @elasticmachine @kcreddy @ritalwar