Skip to content

servicenow: truncate very long field values#11982

Merged
efd6 merged 0 commit intoelastic:mainfrom
efd6:s5431-servicenow
Dec 4, 2024
Merged

servicenow: truncate very long field values#11982
efd6 merged 0 commit intoelastic:mainfrom
efd6:s5431-servicenow

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Dec 3, 2024

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

It seems that some people store very long string values in servicenow tables, resulting in failure to ingest. This change truncates those fields to fit within the field length limit.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:servicenow ServiceNow labels Dec 3, 2024
@efd6 efd6 self-assigned this Dec 3, 2024
@efd6 efd6 force-pushed the s5431-servicenow branch 3 times, most recently from 0d71db6 to 3d4b597 Compare December 3, 2024 05:27
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review December 3, 2024 05:57
@efd6 efd6 requested a review from a team as a code owner December 3, 2024 05:57
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 force-pushed the s5431-servicenow branch from 3d4b597 to 25389a1 Compare December 3, 2024 09:23
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💚 Build #19006 succeeded 3d4b597f54c373325fec67a876cca6b7e3f5e521

cc @efd6

@efd6 efd6 force-pushed the s5431-servicenow branch 2 times, most recently from f0ae177 to 5aa24e6 Compare December 3, 2024 19:33
@efd6 efd6 merged commit ba2aab7 into elastic:main Dec 4, 2024
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package servicenow - 0.5.0 containing this change is available at https://epr.elastic.co/package/servicenow/0.5.0/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
It seems that some people store very long string values in servicenow
tables, resulting in failure to ingest. This change truncates those
fields to fit within the field length limit.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
It seems that some people store very long string values in servicenow
tables, resulting in failure to ingest. This change truncates those
fields to fit within the field length limit.
@efd6 efd6 deleted the s5431-servicenow branch February 5, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:servicenow ServiceNow Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants