Skip to content

[MS365] [One Drive] Add One Drive datastream#11814

Merged
lucian-ioan merged 0 commit intoelastic:mainfrom
lucian-ioan:add_o365_onedrive_datastream
Dec 19, 2024
Merged

[MS365] [One Drive] Add One Drive datastream#11814
lucian-ioan merged 0 commit intoelastic:mainfrom
lucian-ioan:add_o365_onedrive_datastream

Conversation

@lucian-ioan
Copy link
Copy Markdown
Contributor

@lucian-ioan lucian-ioan commented Nov 21, 2024 •
edited
Loading

Proposed commit message

Add One Drive datastream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@lucian-ioan lucian-ioan added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Nov 21, 2024
@lucian-ioan lucian-ioan self-assigned this Nov 21, 2024
@lucian-ioan lucian-ioan marked this pull request as draft November 21, 2024 15:18
@andrewkroh andrewkroh added the New Integration Issue or pull request for creating a new integration package. label Nov 21, 2024
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Dec 1, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

ritalwar
ritalwar reviewed Dec 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the review comments from this PR as a reference to apply consistent improvements across all other O365 PRs.

packages/o365_metrics/data_stream/onedrive/agent/stream/cel.yml.hbs Outdated
Copy link
Copy Markdown
Contributor

@ritalwar ritalwar Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The period value can be made configurable, I've implemented it here.

Copy link
Copy Markdown
Contributor

@ritalwar ritalwar Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can we store method names or endpoints as comma-separated values in a variable and use them for chaining as done here?

I mean, we could define a variable, similar to content-type, to hold method names or endpoints as a comma-separated list. Then, by splitting this list, we can construct the URLs dynamically. Just checking if this approach is feasible

Copy link
Copy Markdown
Contributor

@ritalwar ritalwar Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can open an issue to explore the possibility of implementing this later.

@andrewkroh andrewkroh added the Integration:o365_metrics Microsoft Office 365 Metrics label Dec 16, 2024
@lucian-ioan lucian-ioan marked this pull request as ready for review December 17, 2024 03:30
@lucian-ioan lucian-ioan requested a review from a team as a code owner December 17, 2024 03:30
@lucian-ioan lucian-ioan requested a review from ritalwar December 17, 2024 03:30
ritalwar
ritalwar reviewed Dec 17, 2024
View reviewed changes
@andrewkroh andrewkroh added enhancement New feature or request and removed New Integration Issue or pull request for creating a new integration package. labels Dec 17, 2024
@lucian-ioan lucian-ioan requested a review from ritalwar December 18, 2024 01:56
ritalwar
ritalwar reviewed Dec 18, 2024
View reviewed changes
@lucian-ioan lucian-ioan requested a review from ritalwar December 18, 2024 12:57
@lucian-ioan lucian-ioan force-pushed the add_o365_onedrive_datastream branch from 5621de5 to ecd8acd Compare December 18, 2024 13:09
@lucian-ioan
Copy link
Copy Markdown
Contributor Author

lucian-ioan commented Dec 18, 2024 •
edited
Loading

Will update changelog version to 0.1.1 if this PR will be approved before #11934.

ritalwar
ritalwar reviewed Dec 18, 2024
View reviewed changes
@lucian-ioan lucian-ioan requested a review from ritalwar December 18, 2024 13:42
@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Dec 18, 2024

Quality Gate failed Quality Gate failed

Failed conditions
46.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 18, 2024

💚 Build Succeeded

History

  • 💚 Build #19659 succeeded 704d6ab8a6c05a917c7706b3b60c84fa04142db4
  • 💚 Build #19632 succeeded 5621de5c6ca0d2ef6b6f24c6699dd7f72d4e70ed
  • 💚 Build #19590 succeeded 583d3608f3a8078b3bcc1e4bcf50f4a921578fd3
  • 💚 Build #19249 succeeded 7c215d28e44bae42792f4dda464b1bfff48e3a3b
  • 💚 Build #18933 succeeded 3ff290cd57cc49be099fc9039b3ca88a42f5d402
  • 💔 Build #18931 failed 09511033396533a803cdd2aff809739466191712

cc @lucian-ioan

ritalwar
ritalwar approved these changes Dec 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucian-ioan lucian-ioan merged commit 28978f8 into elastic:main Dec 19, 2024
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Dec 19, 2024

Package o365_metrics - 0.1.2 containing this change is available at https://epr.elastic.co/package/o365_metrics/0.1.2/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@lucian-ioan
[MS365] [One Drive] Add One Drive datastream (elastic#11814)
4b637ec
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@lucian-ioan
[MS365] [One Drive] Add One Drive datastream (elastic#11814)
6588394
@lucian-ioan lucian-ioan deleted the add_o365_onedrive_datastream branch February 6, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ritalwar ritalwar ritalwar approved these changes

Assignees

@lucian-ioan lucian-ioan

Labels

enhancement New feature or request Integration:o365_metrics Microsoft Office 365 Metrics Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucian-ioan @elasticmachine @ritalwar @andrewkroh