[MS365] [Active Users] Add Active Users datastream by lucian-ioan · Pull Request #11934 · elastic/integrations

lucian-ioan · 2024-12-01T18:27:36Z

Proposed commit message

Add Active Users datastream.

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.
I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

[ ]

How to test this PR locally

Related issues

Screenshots

elastic-vault-github-plugin-prod · 2024-12-01T21:30:08Z

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

ritalwar · 2024-12-17T10:31:05Z

packages/o365_metrics/data_stream/active_users/fields/fields.yml

shall we follow naming as o365.metrics.active.users ?

ritalwar · 2024-12-17T10:35:25Z

packages/o365_metrics/data_stream/active_users/manifest.yml

we can use this link for Processors: https://www.elastic.co/guide/en/fleet/current/elastic-agent-processor-configuration.html

ritalwar · 2024-12-17T10:36:52Z

packages/o365_metrics/data_stream/outlook_activity/fields/fields.yml

Suggested change

description: "The count of email messages sent by users during the reporting period. \n"

description: "The count of email messages sent by users during the reporting period."

ritalwar · 2024-12-17T10:38:00Z

packages/o365_metrics/changelog.yml

Suggested change

- version: "0.2.0"

- version: "0.1.1"

packages/o365_metrics/changelog.yml

ritalwar · 2024-12-19T05:09:58Z

packages/o365_metrics/data_stream/active_users/fields/fields.yml

Can we add the unit suffix "count" wherever applicable to the fields in this stream?

ritalwar · 2024-12-19T05:11:44Z

packages/o365_metrics/data_stream/active_users/fields/fields.yml

The data for the skype_for_business field is not listed among the required metrics for this API. We can remove it for both active and inactive counts.

ritalwar · 2024-12-19T05:14:37Z

packages/o365_metrics/data_stream/outlook_activity/manifest.yml

Use agent link for processors

ritalwar · 2024-12-19T05:15:52Z

packages/o365_metrics/data_stream/active_users/manifest.yml

Suggested change

description: Collect Office 365 Active Users metrics via the Microsoft Graph API using CEL Input.

description: Collect Office 365 Active Users metrics.

packages/o365_metrics/_dev/build/docs/README.md

ritalwar · 2024-12-24T13:55:46Z

packages/o365_metrics/data_stream/active_users/elasticsearch/ingest_pipeline/default.yml

We need to update this, as the JSON in Elasticsearch contains a BOM character, which needs to be handled.

Suggested change

return /[ -]/.matcher(s).replaceAll('_').toLowerCase();

String result = /[ -]/.matcher(s).replaceAll('_').toLowerCase();

return /[\ufeff]/.matcher(result).replaceAll('')

elastic-sonarqube · 2024-12-26T11:32:02Z

Quality Gate failed

Failed conditions
55.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

elasticmachine · 2024-12-26T11:32:08Z

💚 Build Succeeded

Buildkite Build
Commit: 88bf5dccc50e225cc043bb851838a983d2b577e7

History

💚 Build #19813 succeeded 3199b05f722383736897bf1627ccb395a4845671
💔 Build #19812 failed 6607016ab58f3f4cfd8ba1c177a76cfc0ff92fb4
💔 Build #19810 failed 9b5a35c88acc8906ec5fbdb3baed2123a1054def
💚 Build #19794 succeeded f9620640047952b2c9e2e262f05b984a6b87cd1a
💚 Build #19635 succeeded 86295cd7e3e8df2e8cea47ee5cf3da9a31e62c2d
💔 Build #19633 failed fca367f1f410002c47358dd214d4e46929f32f23

cc @lucian-ioan

ritalwar

LGTM!

elastic-vault-github-plugin-prod · 2025-01-21T14:03:45Z

Package o365_metrics - 0.2.0 containing this change is available at https://epr.elastic.co/package/o365_metrics/0.2.0/

lucian-ioan added New Integration Issue or pull request for creating a new integration package. Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Dec 1, 2024

lucian-ioan self-assigned this Dec 1, 2024

lucian-ioan marked this pull request as draft December 1, 2024 18:30

lucian-ioan changed the title ~~[MS365] [One Drive] Add Active Users datastream~~ [MS365] [Active Users] Add Active Users datastream Dec 1, 2024

lucian-ioan marked this pull request as ready for review December 10, 2024 10:47

lucian-ioan requested review from ritalwar and tommyers-elastic December 10, 2024 10:47

andrewkroh added the Integration:o365_metrics Microsoft Office 365 Metrics label Dec 16, 2024

lucian-ioan requested a review from a team as a code owner December 17, 2024 01:24

ritalwar reviewed Dec 17, 2024

View reviewed changes

lucian-ioan requested a review from ritalwar December 17, 2024 13:03

andrewkroh reviewed Dec 17, 2024

View reviewed changes

packages/o365_metrics/changelog.yml Outdated Show resolved Hide resolved

andrewkroh added enhancement New feature or request and removed New Integration Issue or pull request for creating a new integration package. labels Dec 17, 2024

lucian-ioan requested a review from andrewkroh December 18, 2024 01:07

lucian-ioan force-pushed the add_o365_active_users_datastream branch from 1f1e918 to fca367f Compare December 18, 2024 02:09

lucian-ioan mentioned this pull request Dec 18, 2024

[MS365] [One Drive] Add One Drive datastream #11814

Merged

5 tasks

ritalwar reviewed Dec 19, 2024

View reviewed changes

lucian-ioan requested a review from ritalwar December 24, 2024 05:59

ritalwar reviewed Dec 24, 2024

View reviewed changes

lucian-ioan requested a review from ritalwar December 26, 2024 11:18

ritalwar approved these changes Dec 27, 2024

View reviewed changes

lucian-ioan merged commit 5fd8339 into elastic:main Dec 27, 2024

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025

[MS365] [Active Users] Add Active Users datastream (elastic#11934)

f8c7c58

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025

[MS365] [Active Users] Add Active Users datastream (elastic#11934)

ca12ac4

lucian-ioan deleted the add_o365_active_users_datastream branch February 6, 2025 19:09

	description: "The count of email messages sent by users during the reporting period. \n"
	description: "The count of email messages sent by users during the reporting period."

	description: Collect Office 365 Active Users metrics via the Microsoft Graph API using CEL Input.
	description: Collect Office 365 Active Users metrics.

	return /[ -]/.matcher(s).replaceAll('_').toLowerCase();
	String result = /[ -]/.matcher(s).replaceAll('_').toLowerCase();
	return /[\ufeff]/.matcher(result).replaceAll('')

Conversation

lucian-ioan commented Dec 1, 2024

Proposed commit message

Checklist

Author's Checklist

How to test this PR locally

Related issues

Screenshots

Uh oh!

elastic-vault-github-plugin-prod bot commented Dec 1, 2024

🚀 Benchmarks report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elastic-sonarqube bot commented Dec 26, 2024

Quality Gate failed

Uh oh!

elasticmachine commented Dec 26, 2024

💚 Build Succeeded

History

Uh oh!

ritalwar left a comment

Choose a reason for hiding this comment

Uh oh!

elastic-vault-github-plugin-prod bot commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants