Navigation related icons change (1) by ek-so · Pull Request #9301 · elastic/eui

ek-so · 2026-01-08T10:19:16Z

Summary

I'm doing an easy part of changes related to the navigtaion — adding the new ones, and changing 2 glyphs of those that don't require renaming. The full list include:

productDashboard — added
productCloudInfra - added
bolt - glyph chaged
briefcase - added
productML - added
bullseye - glyph changed

General checklist

Browser QA
- Checked in both light and dark modes
- Checked in both MacOS and Windows high contrast modes
  - (emulate forced colors if you do not have access to a Windows machine.)
- Checked in mobile
- Checked in Chrome, Safari, Edge, and Firefox
- Checked for accessibility including keyboard-only and screenreader modes
Docs site QA
- Added documentation
- Props have proper autodocs (using @default if default values are missing) and playground toggles
- Checked Code Sandbox works for any docs examples
Code quality checklist
- Added or updated jest and cypress tests
- Updated visual regression tests
Release checklist
- A changelog entry exists and is marked appropriately
- If applicable, added the breaking change issue label (and filled out the breaking change checklist)
- If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)
Designer checklist
- If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

ek-so · 2026-01-08T10:50:20Z

Hey @MichaelMarcialis @JoseLuisGJ, tagging you both for awareness and also to please take a look at naming, if everything is as expected? I didn't include somewhat "complicated" work in here, meaning that I didn't touch the icons that need renaming, just completely new icons and updating the glyphs for a couple of them. I will reflect this in Figma library and our icons release file too.

weronikaolejniczak · 2026-01-08T10:52:32Z

Hey, Kate 👋🏻 thank you for contributing, you're the best! 🙏🏻 @JoseLuisGJ recently opened a PR (#9279) for renaming icons and it's almost close to being wrapped (I think?). I envision conflicts with this one. At the same time, this PR is small and it'd be a shame to have it blocked. Maybe it'd be worthwhile to sync!

EDIT: Oh, only after I wrote the comment I saw ⬆️ 🙈 Good call!

weronikaolejniczak · 2026-01-08T10:53:47Z

packages/eui/src/components/icon/svgs/product_cloud_infra.svg

The svgs should have snake_case naming. Could you update it and regenerate icons? 🙏🏻

Hmm... I was under the impression that we use camel case for the icons names. Currently it's all different though... so we decided to stick to snake case? I guess we need some clarification from @JoseLuisGJ and @MichaelMarcialis 🤔 since they are all camel case in Figma...

And also, I think there should be no conflicts with Jose's PR, because I didn't touch the icons that should be renamed intentionally — only updated glyphs for 2 old icons (bolt, bullseye), and added 4 completely new ones.

@ek-so Sorry, I could've been clearer. We do use camelCase for icon types but for svg filenames we use snake_case. You can see it in Jose's PR! 😄

You're right, I don't think there should be conflicts either! Just thought I'll mention it because at times, git does see conflicts in the weirdest of places just because branches are divergent 😄

Renamed them, thank you for clarifying!
(mamma mia, 546 files... Jose is a superman)

That is very true, our 🦸🏻‍♂️ superhero!

Thanks for this work @ek-so Indeed there is a big renaming batch PR that I think we should merge first and then do the same with this one. The renaming batch is a big lift and it will clean up some inconsistent SVG naming convention as you commented above making all SVG to use snake_case and will sync the same names as we do have in the Fimga library.

packages/eui/src/components/icon/assets/productDashboard.tsx

weronikaolejniczak

Looks perfect, thank you, Kate! 🙌🏻 💚

(CI seems to pass as well, it's just one flaky test, I re-ran it)

mgadewoll · 2026-01-08T12:19:44Z

@ek-so Just to confirm: Did you run VRT (considering that some icons are updated)?

ek-so · 2026-01-08T12:31:27Z

@ek-so Just to confirm: Did you run VRT (considering that some icons are updated)?

Just re-ran it, all ✅

weronikaolejniczak · 2026-01-08T12:31:51Z

@mgadewoll I ran VRT on this PR and all tests passed. bullseye and bolt are not used in any of our Loki stories. So we're fine 👍🏻

Thank you for the vigilance, though! 🙏🏻 It's easy to miss running VRT with our current setup.

mgadewoll · 2026-01-08T12:33:31Z

@ek-so @weronikaolejniczak Awesome, thank you two for checking and the confirmation! ❤️

ek-so · 2026-01-08T15:25:55Z

@weronikaolejniczak could you pls take a look? Are the failures due to some other changes?

This reverts commit 6e09a30.

JoseLuisGJ

Changes LGTM 🚀

packages/eui/src/components/icon/icon_map.ts

weronikaolejniczak · 2026-01-09T10:19:19Z

Re-reviewed the changed and re-ran visual regression tests. We're good to go! 👍🏻 Thank you Kate for contributing 🙏🏻

elasticmachine · 2026-01-09T11:00:51Z

💚 Build Succeeded

History

💚 Build #2372 succeeded 28b0ebd
💚 Build #2364 succeeded be867e1
💔 Build #2362 failed 6e09a30
💔 Build #2361 failed ef87d2e
💔 Build #2358 failed a8b3121
💚 Build #2354 succeeded ca208c4

elasticmachine · 2026-01-09T11:13:56Z

💚 Build Succeeded

Buildkite Build
Commit: 189bd51

History

💚 Build #5551 succeeded be867e1
💔 Build #5549 failed 6e09a30
💔 Build #5548 failed ef87d2e
💔 Build #5546 failed a8b3121
💚 Build #5543 succeeded ca208c4

## Dependency updates - `@elastic/eui`: `v111.1.0` ⏩ `v112.0.0` - `@elastic/eslint-plugin-eui`: `v2.6.0` ⏩ `v2.7.0` --- ## Package updates ### `@elastic/eui` [v112.0.0](https://github.com/elastic/eui/releases/tag/v112.0.0) - Added `productDiscover` icon ([#9311](elastic/eui#9311)) - Updated `chartGauge` icon glyph ([#9311](elastic/eui#9311)) - Updated icon glyphs `endpoint` `eraser` `errorFill` `error` `eyeSlash` `faceHappy` `faceNeutral` `faceSad` `folder` `fullScreenExit` `fullScreen` `gradient` `grid` `heart` `home` `if` `image` `infinity` `inputOutput` `key` `keyboard` `lineBreakSlash` `lineBreak` `lineDash` `lineDot` `lineSolid` `logOut` `magnifyMinus` `magnifyPlus` `magnify` `mail` `map` `mapping` `menuLeft` `menuRight` `menu` `merge` `minusCircle` `minusSquare` `minus` `money` `moon` `move` `nested` `number` `package` `paintBucket` `palette` `paperClip` `partial` `pattern` `pause` `pencil` `percent` `pinFill` `pin` `pivot` `plusCircle` `plusSquare` `plus` `popper` `presentation` `processor` `productStreamsWired` `queryField` `queryOperand` `querySelector` `queryValue` `query` `question` `quote` `radar` `readOnly` `redo` `reporter` `return` `rocket` `scissors` `send` `shard` `share` `snowflake` `sortAscending` `sortDescending` `starFill` `star` `stop` `sun` `tableInfo` `tableTime` `textAlignCenter` `textAlignLeft` `textAlignRight` `textBold` `textHeading` `textItalic` `textStrike` `textUnderline` `thermometer` `thumbDown` `thumbUp` `timeline` `transitionLeftIn` `transitionLeftOut` `transitionTopIn` `transitionTopOut` `undo` `vectorSquare` `vectorTriangle` `videoPlayer` `warningFill` `waypoint` `wifiSlash` `wifi` ([#9303](elastic/eui#9303)) ([#9303](elastic/eui#9303)) - Added icons - `archive` `unarchive` `axisX` `axisYLeft` `axisYRight` `bulb` `cloud` `hourglass` `megaphone` `workflow` ([#9303](elastic/eui#9303)) - Added `headerVisibility` prop on `EuiDataGrid` to support rendering the datagrid header element optionally ([#9281](elastic/eui#9281)) - Updated 244 icon definitions to a more consistent naming convention. All 100 renamed icons include a backward-compatible alias in the icon map to support legacy references. ([#9279](elastic/eui#9279)) - Added icons `briefcase`, `productCloudInfra`, `productDashboard`, `productML` ([#9301](elastic/eui#9301)) - Updated glyphs `bullseye`, `bolt` ([#9301](elastic/eui#9301)) - Added `dismissButtonProps` prop to `EuiCallOut` ([#9285](elastic/eui#9285)) **Bug fixes** - Fixed `EuiFlyout` to properly forward refs when `session` prop is used. ([#9318](elastic/eui#9318)) - Fixed `EuiDataGrid` cells scrolling into view while trying to select text ([#9276](elastic/eui#9276)) **Breaking changes** - Removed `euiPaletteForLightBackground` and `euiPaletteForDarkBackground` deprecated palette functions. Use `euiTheme.colors.vis.euiColorVisText{NUMBER}` tokens instead. ([#9296](elastic/eui#9296)) **Accessibility** - Improved the accessibility of `EuiDataGrid`s column selector drag handle buttons by ensuring distinctive labels ([#9282](elastic/eui#9282)) ### `@elastic/eslint-plugin-eui` v2.7.0 - Added `no-static-z-index` rule ([#9236](elastic/eui#9236))

## Dependency updates - `@elastic/eui`: `v111.1.0` ⏩ `v112.0.0` - `@elastic/eslint-plugin-eui`: `v2.6.0` ⏩ `v2.7.0` --- ## Package updates ### `@elastic/eui` [v112.0.0](https://github.com/elastic/eui/releases/tag/v112.0.0) - Added `productDiscover` icon ([elastic#9311](elastic/eui#9311)) - Updated `chartGauge` icon glyph ([elastic#9311](elastic/eui#9311)) - Updated icon glyphs `endpoint` `eraser` `errorFill` `error` `eyeSlash` `faceHappy` `faceNeutral` `faceSad` `folder` `fullScreenExit` `fullScreen` `gradient` `grid` `heart` `home` `if` `image` `infinity` `inputOutput` `key` `keyboard` `lineBreakSlash` `lineBreak` `lineDash` `lineDot` `lineSolid` `logOut` `magnifyMinus` `magnifyPlus` `magnify` `mail` `map` `mapping` `menuLeft` `menuRight` `menu` `merge` `minusCircle` `minusSquare` `minus` `money` `moon` `move` `nested` `number` `package` `paintBucket` `palette` `paperClip` `partial` `pattern` `pause` `pencil` `percent` `pinFill` `pin` `pivot` `plusCircle` `plusSquare` `plus` `popper` `presentation` `processor` `productStreamsWired` `queryField` `queryOperand` `querySelector` `queryValue` `query` `question` `quote` `radar` `readOnly` `redo` `reporter` `return` `rocket` `scissors` `send` `shard` `share` `snowflake` `sortAscending` `sortDescending` `starFill` `star` `stop` `sun` `tableInfo` `tableTime` `textAlignCenter` `textAlignLeft` `textAlignRight` `textBold` `textHeading` `textItalic` `textStrike` `textUnderline` `thermometer` `thumbDown` `thumbUp` `timeline` `transitionLeftIn` `transitionLeftOut` `transitionTopIn` `transitionTopOut` `undo` `vectorSquare` `vectorTriangle` `videoPlayer` `warningFill` `waypoint` `wifiSlash` `wifi` ([elastic#9303](elastic/eui#9303)) ([elastic#9303](elastic/eui#9303)) - Added icons - `archive` `unarchive` `axisX` `axisYLeft` `axisYRight` `bulb` `cloud` `hourglass` `megaphone` `workflow` ([elastic#9303](elastic/eui#9303)) - Added `headerVisibility` prop on `EuiDataGrid` to support rendering the datagrid header element optionally ([elastic#9281](elastic/eui#9281)) - Updated 244 icon definitions to a more consistent naming convention. All 100 renamed icons include a backward-compatible alias in the icon map to support legacy references. ([elastic#9279](elastic/eui#9279)) - Added icons `briefcase`, `productCloudInfra`, `productDashboard`, `productML` ([elastic#9301](elastic/eui#9301)) - Updated glyphs `bullseye`, `bolt` ([elastic#9301](elastic/eui#9301)) - Added `dismissButtonProps` prop to `EuiCallOut` ([elastic#9285](elastic/eui#9285)) **Bug fixes** - Fixed `EuiFlyout` to properly forward refs when `session` prop is used. ([elastic#9318](elastic/eui#9318)) - Fixed `EuiDataGrid` cells scrolling into view while trying to select text ([elastic#9276](elastic/eui#9276)) **Breaking changes** - Removed `euiPaletteForLightBackground` and `euiPaletteForDarkBackground` deprecated palette functions. Use `euiTheme.colors.vis.euiColorVisText{NUMBER}` tokens instead. ([elastic#9296](elastic/eui#9296)) **Accessibility** - Improved the accessibility of `EuiDataGrid`s column selector drag handle buttons by ensuring distinctive labels ([elastic#9282](elastic/eui#9282)) ### `@elastic/eslint-plugin-eui` v2.7.0 - Added `no-static-z-index` rule ([elastic#9236](elastic/eui#9236))

Co-authored-by: Weronika Olejniczak <weronika.olejniczak@elastic.co> Co-authored-by: Weronika Olejniczak <32842468+weronikaolejniczak@users.noreply.github.com>

ek-so added 2 commits January 8, 2026 11:09

All changes done

a557ad4

Changelog

2a4d24f

ek-so marked this pull request as ready for review January 8, 2026 10:47

ek-so requested a review from a team as a code owner January 8, 2026 10:47

weronikaolejniczak self-requested a review January 8, 2026 10:49

ek-so requested review from JoseLuisGJ and MichaelMarcialis January 8, 2026 10:50

weronikaolejniczak reviewed Jan 8, 2026

View reviewed changes

ek-so added 2 commits January 8, 2026 12:08

Changed names

a3fa29d

Unit tests

8f13150

weronikaolejniczak reviewed Jan 8, 2026

View reviewed changes

packages/eui/src/components/icon/assets/productDashboard.tsx Show resolved Hide resolved

ek-so added 3 commits January 8, 2026 12:21

Delete packages/eui/src/components/icon/assets/productCloudInfra.tsx

7f50bee

Delete packages/eui/src/components/icon/assets/productML.tsx

95f4900

Delete packages/eui/src/components/icon/assets/productDashboard.tsx

ca208c4

weronikaolejniczak approved these changes Jan 8, 2026

View reviewed changes

Merge branch 'main' into ekso-nav-related-icons

a8b3121

weronikaolejniczak and others added 6 commits January 8, 2026 16:51

fix(eui): remove duplicate property in icon_map

42b8e56

Merge branch 'main' into ekso-nav-related-icons

ef87d2e

Re-ran unit testing and VRT

6e09a30

Revert "Re-ran unit testing and VRT"

3747a0d

This reverts commit 6e09a30.

fix: remove duplicate push property in icon_map

13cd2e4

Unit tests

be867e1

JoseLuisGJ approved these changes Jan 9, 2026

View reviewed changes

weronikaolejniczak reviewed Jan 9, 2026

View reviewed changes

packages/eui/src/components/icon/icon_map.ts Show resolved Hide resolved

revert: push icon changes

28b0ebd

Merge branch 'main' into ekso-nav-related-icons

189bd51

ek-so merged commit 91dfa91 into elastic:main Jan 9, 2026
5 checks passed

ek-so deleted the ekso-nav-related-icons branch January 9, 2026 13:04

tkajtoch mentioned this pull request Jan 19, 2026

Update EUI to v112.0.0 elastic/kibana#249573

Merged

Conversation

ek-so commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

General checklist

Uh oh!

ek-so commented Jan 8, 2026

Uh oh!

weronikaolejniczak commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

weronikaolejniczak left a comment

Choose a reason for hiding this comment

Uh oh!

mgadewoll commented Jan 8, 2026

Uh oh!

ek-so commented Jan 8, 2026

Uh oh!

weronikaolejniczak commented Jan 8, 2026

Uh oh!

mgadewoll commented Jan 8, 2026

Uh oh!

ek-so commented Jan 8, 2026

Uh oh!

JoseLuisGJ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

weronikaolejniczak commented Jan 9, 2026

Uh oh!

elasticmachine commented Jan 9, 2026

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Jan 9, 2026

💚 Build Succeeded

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ek-so commented Jan 8, 2026 •

edited

Loading

weronikaolejniczak commented Jan 8, 2026 •

edited

Loading