Add compressed props on basic/memory tables#687
Conversation
|
@cchaos This is now rebased against your PR. I've noted the compressed prop in the propdocs but not the display docs. That page is getting super heavy now and I don't want to distract from the content. |
cchaos
left a comment
There was a problem hiding this comment.
Works.
Quick question, should we be changing the font-size of the header and pagination as well?
I just realized that I changed the font size on the header at too low of a level:
|
I don't think we want the font bumping down bellow 12px/.75rem. At that point it becomes hard to read for people with not perfect eyes. I think the header actually looks fine in yours. I like it a little smaller, helps it stand out a bit 👍 |
|
@snide I think this PR forgot to add the |
* pagination labeling fixes #735 * fixes #621 adds menubar roles to side nav * fixes #734, adds more descriptive aria labeling for pagination * fixes #729, apply aria-live to popovers * fixes #723, provides screen reader notice for bottom bar appearance * fix ownFocus needing to be true for non-context menu sitations. apply aria labels depending upon ownFocus state * fixes #616 adds home page label * fixes #687, documentation button labeling * fixes #617 applies aria label to theme selector * fixes #746 applies proper label to select all checkboxes in table * clone element and id no longer needed for popover
Fixed #460
Adds in the ability to use the
compressedprop onEuiBasicTableandEuiInMemoryTable