[EuiPopoverFooter] Fix buggy panel padding size context#6698
Merged
cee-chen merged 6 commits intoelastic:mainfrom Apr 6, 2023
Merged
[EuiPopoverFooter] Fix buggy panel padding size context#6698cee-chen merged 6 commits intoelastic:mainfrom
cee-chen merged 6 commits intoelastic:mainfrom
Conversation
This component only should be *setting* context, not *using* it (which is causing incorrect inheritance from nested popovers)
- use Emotion keys and an internal helper util instead + comment cleanup so
breehall
approved these changes
Apr 6, 2023
Contributor
breehall
left a comment
There was a problem hiding this comment.
✅ I can confirm that this is fixed. I pulled the branch locally and did not find a padding issue when changing the dates.
This reverts commit 3d6f396.
Contributor
Author
|
🎉 Thanks a ton for confirming the fix Bree! |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6698/ |
jbudz
added a commit
to elastic/kibana
that referenced
this pull request
Apr 18, 2023
EUI `77.0.0` ➡️ `77.1.1` ## [`77.1.0`](https://github.com/elastic/eui/tree/v77.1.0) - Updated `EuiDatePicker` to display a warning icon and correctly set `aria-invalid` when `isInvalid` is passed ([#6677](elastic/eui#6677)) - Updated `EuiFilePicker` to display an alert icon when `isInvalid` ([#6678](elastic/eui#6678)) - Updated `EuiTextArea` to display an alert icon when `isInvalid` ([#6679](elastic/eui#6679)) - Updated `EuiTextArea` to support the `isLoading` prop ([#6679](elastic/eui#6679)) - Updated `EuiComboBox` to display a warning icon and correctly set `aria-invalid` when `isInvalid` is passed ([#6680](elastic/eui#6680)) **Bug fixes** - Fixed `EuiAccordion` to not set an `aria-expanded` attribute on non-interactive `buttonElement`s ([#6694](elastic/eui#6694)) - Fixed an `EuiPopoverFooter` bug causing nested popovers within popovers (note: not a recommended use-case) to unintentionally override its panel padding size inherited from context ([#6698](elastic/eui#6698)) - Fixed `EuiComboBox` to only delete the last selected item on backspace if the input caret is present ([#6699](elastic/eui#6699)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jon <jon@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #6695
The main (fairly simple) context fix is in 7619bfc.
The other commits are an Emotion cleanup that I noticed while here and should have caught when cleaning up
EuiPopoverTitlein #6221Repro steps
QA
General checklist
- [ ] Added or updated jest and cypress testsI skipped writing a specific regression test for this bug as nested popovers are generally a recommended-against edge-case, and code regression is incredibly unlikely as the context usage was simply wrong in the first place