[EuiComboBox] Add alert icon when isInvalid#6680
Merged
cee-chen merged 5 commits intoelastic:mainfrom Apr 4, 2023
Merged
Conversation
+ remove classNames that were only being used for icon detection
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6680/ |
1Copenut
approved these changes
Apr 4, 2023
Contributor
1Copenut
left a comment
There was a problem hiding this comment.
👍 LGTM!
I tested this one with VoiceOver + Safari (Mac) and NVDA + Chrome (Win). Worked as expected announcing the "invalid entry" when I toggled the isInvalid prop.
jbudz
added a commit
to elastic/kibana
that referenced
this pull request
Apr 18, 2023
EUI `77.0.0` ➡️ `77.1.1` ## [`77.1.0`](https://github.com/elastic/eui/tree/v77.1.0) - Updated `EuiDatePicker` to display a warning icon and correctly set `aria-invalid` when `isInvalid` is passed ([#6677](elastic/eui#6677)) - Updated `EuiFilePicker` to display an alert icon when `isInvalid` ([#6678](elastic/eui#6678)) - Updated `EuiTextArea` to display an alert icon when `isInvalid` ([#6679](elastic/eui#6679)) - Updated `EuiTextArea` to support the `isLoading` prop ([#6679](elastic/eui#6679)) - Updated `EuiComboBox` to display a warning icon and correctly set `aria-invalid` when `isInvalid` is passed ([#6680](elastic/eui#6680)) **Bug fixes** - Fixed `EuiAccordion` to not set an `aria-expanded` attribute on non-interactive `buttonElement`s ([#6694](elastic/eui#6694)) - Fixed an `EuiPopoverFooter` bug causing nested popovers within popovers (note: not a recommended use-case) to unintentionally override its panel padding size inherited from context ([#6698](elastic/eui#6698)) - Fixed `EuiComboBox` to only delete the last selected item on backspace if the input caret is present ([#6699](elastic/eui#6699)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jon <jon@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of my on-call work this week, I'm finishing up some older backlog work, in this case #2017.
This PR DRYs out some manual padding logic in
EuiComboBoxto usegetFormControlClassNameForIconCount()instead. However, the icon classes added by the previous utility didn't have a high enough specificity to overrideEuiComboBox's input wrap padding, so I added a CSS--var()workaround instead.Before
After
QA
General checklist