Parse composite after_key eagerly#94979
Merged
romseygeek merged 2 commits intoelastic:mainfrom Apr 3, 2023
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-1 |
not-napoleon
approved these changes
Apr 3, 2023
Member
not-napoleon
left a comment
There was a problem hiding this comment.
I think this makes sense. Thanks for taking care of it.
romseygeek
added a commit
that referenced
this pull request
Apr 4, 2023
romseygeek
added a commit
to romseygeek/elasticsearch
that referenced
this pull request
Apr 5, 2023
…lastic#94979)"" This reverts commit 7c830cd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composite after_keys are currently only formatted when they are serialized
to xcontent, meaning that a key that cannot be formatted will not be caught
until after all the results from an aggregation have been reduced. This
wastes CPU time, and also blocks any move to chunked xcontent handling
in search responses.
This commit moves formatting of an after_key into InternalComposite's
constructor, catching these errors earlier.
Resolves #94760