Skip to content

Revert "Check formatting of after keys at construction time (#94979)"#95015

Merged
romseygeek merged 1 commit intoelastic:mainfrom
romseygeek:bug/composite-bwc
Apr 4, 2023
Merged

Revert "Check formatting of after keys at construction time (#94979)"#95015
romseygeek merged 1 commit intoelastic:mainfrom
romseygeek:bug/composite-bwc

Conversation

@romseygeek
Copy link
Copy Markdown
Contributor

This reverts commit 092fa8d.

We can't throw exceptions during construction from a StreamInput, as this
can kill nodes in mixed clusters.

…94979)"

This reverts commit 092fa8d.

We can't throw exceptions during construction from a StreamInput, as
this can kill nodes in mixed clusters.
@romseygeek romseygeek self-assigned this Apr 4, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 4, 2023
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Copy link
Copy Markdown
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craigtaverner
Copy link
Copy Markdown
Contributor

Does this also fix #95009?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants