Merged
Conversation
the memory has to be accounted only after circuitBreaker.addEstimateBytesAndMaybeBreak() succeeded otherwise the cleanup is performed with a wrong value
Collaborator
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-ql (Team:QL) |
bpintea
approved these changes
Nov 10, 2022
astefan
approved these changes
Nov 10, 2022
Contributor
astefan
left a comment
There was a problem hiding this comment.
LGTM. I've left one comment.
Also, please update the description of the PR to include the list of PRs that are part of this larger one. Thanks.
docs/changelog/85206.yaml
Outdated
| @@ -0,0 +1,5 @@ | |||
| pr: 85206 | |||
Contributor
There was a problem hiding this comment.
I don't think this file is needed anymore.
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Nov 15, 2022
* main: (163 commits) [DOCS] Edits frequent items aggregation (elastic#91564) Handle providers of optional services in ubermodule classloader (elastic#91217) Add `exportDockerImages` lifecycle task for exporting docker tarballs (elastic#91571) Fix CSV dependency report output file location in DRA CI job Fix variable placeholder for Strings.format calls (elastic#91531) Fix output dir creation in ConcatFileTask (elastic#91568) Fix declaration of dependencies in DRA snapshots CI job (elastic#91569) Upgrade Gradle Enterprise plugin to 3.11.4 (elastic#91435) Ingest DateProcessor (small) speedup, optimize collections code in DateFormatter.forPattern (elastic#91521) Fix inter project handling of generateDependenciesReport (elastic#91555) [Synthetics] Add synthetics-* read to fleet-server (elastic#91391) [ML] Copy more settings when creating DF analytics destination index (elastic#91546) Reduce CartesianCentroidIT flakiness (elastic#91553) Propagate last node to reinitialized routing tables (elastic#91549) Forecast write load during rollovers (elastic#91425) [DOCS] Warn about potential overhead of named queries (elastic#91512) Datastream unavailable exception metadata (elastic#91461) Generate docker images and dependency report in DRA ci job (elastic#91545) Support cartesian_bounds aggregation on point and shape (elastic#91298) Add support for EQL samples queries (elastic#91312) ... # Conflicts: # x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/RollupShardIndexer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Sample query searches for events matching the defined filters, regardless of their temporal order (unlike Sequences, where events have to form a temporal sequence).
Like for sequences, a sample query can define one or more join keys.
As an example, a sample query could look like the following:
The result is a set of samples, where each sample is made of N events, one per filter. Events in a sample have the same value for the join key(s) (defined with the
bykeyword;hostandos/op_sysin the example above).With current implementation, the result contains at most one sample for each join key value.
Includes the following PRs: