Fix memory calculation on circuit breaker addMemory()#88882
Merged
luigidellaquila merged 2 commits intoelastic:feature/eql_samplesfrom Aug 1, 2022
Merged
Conversation
the memory has to be accounted only after circuitBreaker.addEstimateBytesAndMaybeBreak() succeeded otherwise the cleanup is performed with a wrong value
Collaborator
|
Pinging @elastic/es-ql (Team:QL) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The memory has to be accounted only after circuitBreaker.addEstimateBytesAndMaybeBreak() succeeds, otherwise the cleanup is performed with a wrong value.
Same as #88538
Unfortunately, unlike sequences, unit-testing the fix here is extremely complicated, due to the fact that mock result sets of intermediate results cannot be instantiated (private constructors in Server classes)