Revert "Update RareClusterStateIT to work with ... (#87922)"#90720
Merged
pxsalehi merged 1 commit intoelastic:mainfrom Oct 18, 2022
Merged
Revert "Update RareClusterStateIT to work with ... (#87922)"#90720pxsalehi merged 1 commit intoelastic:mainfrom
pxsalehi merged 1 commit intoelastic:mainfrom
Conversation
…or (elastic#87922)" This reverts commit ae53fab.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
approved these changes
Oct 18, 2022
Member
Author
|
Thanks @idegtiarenko |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 3, 2022
Reverts elastic#90720 and adds some additional logging to further investigate the failure here. Relates elastic#87922
DaveCTurner
added a commit
that referenced
this pull request
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in the reverted commit are only to the a portion of the test (setup) itself. They have failed fairly often despite a previous attempt to fix the new test addition in #62662.
Running the test suite with:
(and even more runs), the suite seems to be more stable w/o the changes. What was the reason for those code changes?
Closes #89905