Fix RareClusterStateIT Publication Cancel#62662
Merged
original-brownbear merged 1 commit intoelastic:masterfrom Sep 25, 2020
original-brownbear:62446
Merged
Fix RareClusterStateIT Publication Cancel#62662original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:62446
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:62446
Conversation
We have to make sure the applier and not the accept state versions allign here. Otherwise we can get into the situation where the data node is so slow to process one version that the next one arrives, gets rejected and the request return with ack `false` and we fail the assertion that the put mapping request didn't complete. Closes #62446
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
| }); | ||
| final Coordinator masterCoordinator = (Coordinator) internalCluster().getCurrentMasterNodeInstance(Discovery.class); | ||
| assertBusy(() -> { | ||
| assertFalse(masterCoordinator.publicationInProgress()); |
Contributor
Author
There was a problem hiding this comment.
Made this whole thing a little less weird to read as well here, the stream + iterator + array size assertion was just weirdly complicated.
henningandersen
approved these changes
Sep 25, 2020
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
LGTM, thanks for the additional explanations elsewhere, @original-brownbear .
Contributor
Author
|
Thanks Henning! |
original-brownbear
added a commit
that referenced
this pull request
Sep 25, 2020
We have to make sure the applier and not the accept state versions allign here. Otherwise we can get into the situation where the data node is so slow to process one version that the next one arrives, gets rejected and the request return with ack `false` and we fail the assertion that the put mapping request didn't complete. Closes #62446
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have to make sure the applier and not the accept state versions allign here.
Otherwise we can get into the situation where the data node is so slow to process
one version that the next one arrives, gets rejected and the request return with
ack
falseand we fail the assertion that the put mapping request didn't complete.Closes #62446