Skip to content

[TEST] Change to atomic file contents save#90695

Merged
grcevski merged 1 commit intoelastic:mainfrom
grcevski:fix/file_settings_tests
Oct 6, 2022
Merged

[TEST] Change to atomic file contents save#90695
grcevski merged 1 commit intoelastic:mainfrom
grcevski:fix/file_settings_tests

Conversation

@grcevski
Copy link
Copy Markdown
Contributor

@grcevski grcevski commented Oct 5, 2022

The unit tests we have for File settings didn't save the contents atomically, so in theory they can trigger more than one file save operation. This PR changes all file saves to atomic saves.

Closes #90693

@grcevski grcevski added :Core/Infra/Core Core issues without another label >test-failure Triaged test failures from CI Team:Core/Infra Meta label for core/infra team auto-backport-and-merge v8.5.1 v8.6.0 labels Oct 5, 2022
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Copy Markdown
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grcevski grcevski merged commit 9fe1ac7 into elastic:main Oct 6, 2022
@grcevski
Copy link
Copy Markdown
Contributor Author

grcevski commented Oct 6, 2022

Thanks Chris!

@grcevski grcevski deleted the fix/file_settings_tests branch October 6, 2022 15:08
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💔 Backport failed

Status Branch Result
8.5 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 90695

weizijun added a commit to weizijun/elasticsearch that referenced this pull request Oct 10, 2022
* main: (150 commits)
  Remove ToXContent interface from ChunkedToXContent (elastic#90409)
  Remove extra SearchService constructor (elastic#90733)
  Update min version for the diagnosis yaml test (elastic#90731)
  Use the AggTestConfig object in testCase (elastic#90699)
  [DOCS] Add links to clear trained model deployment cache API (elastic#90727)
  Assert wildcards are not expanded as specified by request options  (elastic#90641)
  [TEST] Fix exit snapshot restore exit condition (elastic#90696)
  [TEST] Change to atomic file contents save (elastic#90695)
  Update forbiddenapis to 3.4 (elastic#90624)
  [Tests] Don't use concurrent search in scripted field type tests (elastic#90712)
  [ML] Move scaling is possible check for starting trained model (elastic#90706)
  Add new base test case for chunked xcontent types  (elastic#90707)
  Fix testRedNoBlockedIndicesAndRedAllRoleNodes (elastic#90671)
  Fix nullpointer in docs test setup (elastic#90660)
  Don't produce build logs artifact when in a composite build
  Fixing a race condition in EnrichCoordinatorProxyAction that can leave an item stuck in its queue (elastic#90688)
  docs: update fleet/agent pipeline docs (elastic#90659)
  [HealthAPI] Use plural consistently in resource types (elastic#90682)
  [Testing] Enable bwc and fix sorting for 500_date_range (elastic#90681)
  Add profiling and documentation for dfs phase (elastic#90536)
  ...

# Conflicts:
#	x-pack/plugin/mapper-aggregate-metric/src/test/java/org/elasticsearch/xpack/aggregatemetric/mapper/AggregateDoubleMetricFieldMapperTests.java
@csoulios csoulios added v8.5.0 and removed v8.5.1 labels Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI v8.5.0 v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] FileSettingsServiceTests testCallsProcessing failing

4 participants