Skip to content

Update forbiddenapis to 3.4#90624

Merged
breskeby merged 14 commits intoelastic:mainfrom
breskeby:update-forbiddenapis
Oct 6, 2022
Merged

Update forbiddenapis to 3.4#90624
breskeby merged 14 commits intoelastic:mainfrom
breskeby:update-forbiddenapis

Conversation

@breskeby
Copy link
Copy Markdown
Contributor

@breskeby breskeby commented Oct 4, 2022

Fixes #90445

@breskeby breskeby self-assigned this Oct 4, 2022
@breskeby breskeby added :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.17.7 labels Oct 4, 2022
@breskeby breskeby force-pushed the update-forbiddenapis branch 3 times, most recently from 8721eb9 to b4530e2 Compare October 6, 2022 09:25
@breskeby breskeby force-pushed the update-forbiddenapis branch from b4530e2 to 6bac5d2 Compare October 6, 2022 12:19
@breskeby breskeby marked this pull request as ready for review October 6, 2022 14:42
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby merged commit 43a0377 into elastic:main Oct 6, 2022
@uschindler
Copy link
Copy Markdown
Contributor

uschindler commented Oct 6, 2022

I wondered why you needed so many updates. But you were on 3.2 before. Since then the unsafe format() was added, a recent addition in java. But relies on default locale.

See policeman-tools/forbidden-apis#184

weizijun added a commit to weizijun/elasticsearch that referenced this pull request Oct 10, 2022
* main: (150 commits)
  Remove ToXContent interface from ChunkedToXContent (elastic#90409)
  Remove extra SearchService constructor (elastic#90733)
  Update min version for the diagnosis yaml test (elastic#90731)
  Use the AggTestConfig object in testCase (elastic#90699)
  [DOCS] Add links to clear trained model deployment cache API (elastic#90727)
  Assert wildcards are not expanded as specified by request options  (elastic#90641)
  [TEST] Fix exit snapshot restore exit condition (elastic#90696)
  [TEST] Change to atomic file contents save (elastic#90695)
  Update forbiddenapis to 3.4 (elastic#90624)
  [Tests] Don't use concurrent search in scripted field type tests (elastic#90712)
  [ML] Move scaling is possible check for starting trained model (elastic#90706)
  Add new base test case for chunked xcontent types  (elastic#90707)
  Fix testRedNoBlockedIndicesAndRedAllRoleNodes (elastic#90671)
  Fix nullpointer in docs test setup (elastic#90660)
  Don't produce build logs artifact when in a composite build
  Fixing a race condition in EnrichCoordinatorProxyAction that can leave an item stuck in its queue (elastic#90688)
  docs: update fleet/agent pipeline docs (elastic#90659)
  [HealthAPI] Use plural consistently in resource types (elastic#90682)
  [Testing] Enable bwc and fix sorting for 500_date_range (elastic#90681)
  Add profiling and documentation for dfs phase (elastic#90536)
  ...

# Conflicts:
#	x-pack/plugin/mapper-aggregate-metric/src/test/java/org/elasticsearch/xpack/aggregatemetric/mapper/AggregateDoubleMetricFieldMapperTests.java
arteam added a commit to arteam/elasticsearch that referenced this pull request Dec 5, 2022
elastic#90624 introduced a `formatted` utility method in ESTestCase as a safe version of the
`String.formatted` method which is forbidden by the forbidden API checker.

We can replace `String.format(Locale.ROOT)` calls with it as well as `String.formatted`
calls that were replaced in elastic#90624.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.17.7 v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] o.e.g.i.p.ThirdPartyAuditTask.runThirdPartyAudit failing

3 participants