Skip to content

Add a test for checking for misspelled "dry_run" parameters for Desired Nodes API#88898

Merged
arteam merged 1 commit intoelastic:mainfrom
arteam:add-test-for-misspeled-dry-run
Jul 28, 2022
Merged

Add a test for checking for misspelled "dry_run" parameters for Desired Nodes API#88898
arteam merged 1 commit intoelastic:mainfrom
arteam:add-test-for-misspeled-dry-run

Conversation

@arteam
Copy link
Copy Markdown
Contributor

@arteam arteam commented Jul 28, 2022

Check we the API doesn't accept a misspelled parameter and returns a client error.

…ed Nodes API

Check we the API doesn't accept a misspelled parameter and returns a client error.
@arteam arteam added >test Issues or PRs that are addressing/adding tests :Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. labels Jul 28, 2022
@elasticsearchmachine elasticsearchmachine added v8.5.0 Team:Distributed Meta label for distributed team. labels Jul 28, 2022
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Copy Markdown
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Contributor

@fcofdez fcofdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @arteam!

@arteam arteam merged commit f4e617e into elastic:main Jul 28, 2022
@arteam arteam deleted the add-test-for-misspeled-dry-run branch July 28, 2022 14:15
@arteam
Copy link
Copy Markdown
Contributor Author

arteam commented Jul 28, 2022

Thank you both!

weizijun added a commit to weizijun/elasticsearch that referenced this pull request Jul 29, 2022
* upstream/main:
  Add 8.5 migration docs (elastic#88923)
  Script: Reindex & UpdateByQuery Metadata (elastic#88665)
  Remove unused plugins dir var from server CLI (elastic#88917)
  Use tracing API in TaskManager (elastic#88885)
  Add source fallback for keyword fields using operation (elastic#88735)
  Prune changelogs after 8.3.3 release
  Bump versions after 8.3.3 release
  Add a test for checking for misspelled "dry_run" parameters for Desired Nodes API (elastic#88898)
  Speedup BalanceUnbalancedClusterTests (elastic#88794)
  Preventing exceptions on node shutdown in integration tests (elastic#88827)
  Do not trigger check part3 for test mute and docs PRs (elastic#88895)
  Add troubleshooting docs about data corruption (elastic#88760)
  Mute RollupActionSingleNodeTests#testRollupDatastream (elastic#88891)
  [DOCS] Domain splitting impacts API keys (elastic#88677)
  Fix SqlSearchIT testAllTypesWithRequestToOldNodes (elastic#88866) (elastic#88883)
  Update synthetic-source.asciidoc (elastic#88880)
  Log more details in TaskAssertions (elastic#88864)
  Make Tuple a record (elastic#88280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. Team:Distributed Meta label for distributed team. >test Issues or PRs that are addressing/adding tests v8.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the ability to run the Desired Nodes API in dry mode

4 participants