Skip to content

Update synthetic-source.asciidoc#88880

Merged
giladgal merged 2 commits intomainfrom
giladgal-patch-1
Jul 28, 2022
Merged

Update synthetic-source.asciidoc#88880
giladgal merged 2 commits intomainfrom
giladgal-patch-1

Conversation

@giladgal
Copy link
Copy Markdown

@giladgal giladgal commented Jul 28, 2022

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.5.0 labels Jul 28, 2022
abdonpijpelink
abdonpijpelink approved these changes Jul 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a small suggestion. Apart from that LGTM.

@abdonpijpelink abdonpijpelink added >docs General docs changes Team:Docs Meta label for docs team and removed needs:triage Requires assignment of a team area label labels Jul 28, 2022
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Jul 28, 2022

Pinging @elastic/es-docs (Team:Docs)

@abdonpijpelink
Update docs/reference/mapping/fields/synthetic-source.asciidoc
fef4441 
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
@giladgal giladgal merged commit c35cfc9 into main Jul 28, 2022
@giladgal giladgal deleted the giladgal-patch-1 branch July 28, 2022 07:35
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Jul 29, 2022
@weizijun
Merge branch 'upstream/main' into number-support-single-type
964ab92 
* upstream/main:
  Add 8.5 migration docs (elastic#88923)
  Script: Reindex & UpdateByQuery Metadata (elastic#88665)
  Remove unused plugins dir var from server CLI (elastic#88917)
  Use tracing API in TaskManager (elastic#88885)
  Add source fallback for keyword fields using operation (elastic#88735)
  Prune changelogs after 8.3.3 release
  Bump versions after 8.3.3 release
  Add a test for checking for misspelled "dry_run" parameters for Desired Nodes API (elastic#88898)
  Speedup BalanceUnbalancedClusterTests (elastic#88794)
  Preventing exceptions on node shutdown in integration tests (elastic#88827)
  Do not trigger check part3 for test mute and docs PRs (elastic#88895)
  Add troubleshooting docs about data corruption (elastic#88760)
  Mute RollupActionSingleNodeTests#testRollupDatastream (elastic#88891)
  [DOCS] Domain splitting impacts API keys (elastic#88677)
  Fix SqlSearchIT testAllTypesWithRequestToOldNodes (elastic#88866) (elastic#88883)
  Update synthetic-source.asciidoc (elastic#88880)
  Log more details in TaskAssertions (elastic#88864)
  Make Tuple a record (elastic#88280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abdonpijpelink abdonpijpelink abdonpijpelink approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

>docs General docs changes Team:Docs Meta label for docs team v8.5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@giladgal @elasticsearchmachine @abdonpijpelink