[TSDB] Expose aggregate_metric_double fields as their own field type instead of double#87849
Merged
csoulios merged 6 commits intoelastic:mainfrom Sep 15, 2022
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
nik9000
reviewed
Jun 20, 2022
...ck/plugin/src/yamlRestTest/resources/rest-api-spec/test/aggregate-metrics/100_field_caps.yml
Outdated
Show resolved
Hide resolved
Collaborator
|
Pinging @elastic/clients-team (Team:Clients) |
romseygeek
approved these changes
Jun 21, 2022
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
LGTM, thanks @csoulios
Contributor
Author
|
@elasticmachine update branch |
csoulios
added a commit
that referenced
this pull request
Sep 15, 2022
Since aggregate_metric_field was presented as a double in the field caps API, we had a committed a temporary change that would treat aggregate_metric_double fields as a special case. After merging PR #87849 that exposes aggregate_metric_field with its own field type in all cases, we can revert this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fields of type
aggregate_metric_doubleare currently exposed in the field caps API as fields of typedoubleThis PR changes this behavior so that
aggregate_metric_doublefields are exposed with their own field type.Context
In the past, we had taken the decision to expose fields of type
aggregate_metric_doubleas regulardoublefields in the field caps API. This decision intended to hide the complexity of this field from Kibana and only expose it as a simple numeric field. After recent discussions with the Kibana team, we decided that Elasticsearch should be transparent as to when a field is anaggregate_metric_doublefield and Kibana will deal with managing the field type.Consequences
This is a breaking change
Relates to #74660