Skip to content

Revert change that would return type name in the field caps API#90083

Merged
csoulios merged 1 commit intoelastic:mainfrom
csoulios:clean-field-caps
Sep 15, 2022
Merged

Revert change that would return type name in the field caps API#90083
csoulios merged 1 commit intoelastic:mainfrom
csoulios:clean-field-caps

Conversation

@csoulios
Copy link
Copy Markdown
Contributor

Since aggregate_metric_field was presented as a double in the field caps API,
we had a committed a temporary change that would treat aggregate_metric_double
fields as a special case.

After merging PR #87849 that exposes aggregate_metric_field with its own field type
in all cases, we can revert this change.

@csoulios csoulios added >non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types v8.5.0 labels Sep 15, 2022
@csoulios csoulios requested a review from romseygeek September 15, 2022 09:00
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Sep 15, 2022
Copy link
Copy Markdown
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csoulios csoulios merged commit e582032 into elastic:main Sep 15, 2022
@csoulios csoulios deleted the clean-field-caps branch September 15, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v8.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants